bf2f6f8104
The descendant query in `WP_Comment_Query::fill_descendants()` uses the clauses of the main `get_comment_ids()` query as a basis, discarding the `parent`, `parent__in`, and `parent__not_in` clauses. As implemented in WP 4.4 [34546], the WHERE clause was assembled in such a way that any modifications applied using the `comments_clauses` filter were not inherited by `fill_descendants()`. This resulted in descendant queries that did not always properly filter results, and sometimes contained syntax errors. The current changeset fixes the problem by using the post-filter WHERE clause as the basis for the `fill_descendants()` query. This change requires a new approach for eliminating the unneeded parent-related clauses: instead of eliminating values in an associative array, we must use regular expressions. Props boonebgorges, firebird75. Fixes #35192. git-svn-id: https://develop.svn.wordpress.org/trunk@36277 602fd350-edb4-49c9-b593-d223f7449a82 |
||
---|---|---|
.. | ||
data | ||
includes | ||
tests | ||
build.xml | ||
multisite.xml | ||
README.txt | ||
wp-mail-real-test.php |
The short version: 1. Create a clean MySQL database and user. DO NOT USE AN EXISTING DATABASE or you will lose data, guaranteed. 2. Copy wp-tests-config-sample.php to wp-tests-config.php, edit it and include your database name/user/password. 3. $ svn up 4. Run the tests from the "trunk" directory: To execute a particular test: $ phpunit tests/phpunit/tests/test_case.php To execute all tests: $ phpunit Notes: Test cases live in the 'tests' subdirectory. All files in that directory will be included by default. Extend the WP_UnitTestCase class to ensure your test is run. phpunit will initialize and install a (more or less) complete running copy of WordPress each time it is run. This makes it possible to run functional interface and module tests against a fully working database and codebase, as opposed to pure unit tests with mock objects and stubs. Pure unit tests may be used also, of course. Changes to the test database will be rolled back as tests are finished, to ensure a clean start next time the tests are run. phpunit is intended to run at the command line, not via a web server.