0ae22e5f4c
The `$delete_all` flag in `delete_metadata()` triggers cache invalidation for multiple objects. Previously, invalidation took place for all objects matching the `$meta_key` parameter, regardless of whether `$meta_value` was also set. This resulted in overly aggressive invalidation. Props rahal.aboulfeth. Fixes #35797. git-svn-id: https://develop.svn.wordpress.org/trunk@36511 602fd350-edb4-49c9-b593-d223f7449a82
146 lines
4.0 KiB
PHP
146 lines
4.0 KiB
PHP
<?php
|
|
|
|
/**
|
|
* @group meta
|
|
*/
|
|
class Tests_Meta_DeleteMetadata extends WP_UnitTestCase {
|
|
public function test_all_metas_for_key_should_be_deleted_when_no_meta_value_is_provided() {
|
|
$vals = array( '0', '1', '2' );
|
|
foreach ( $vals as $val ) {
|
|
add_metadata( 'post', 12345, 'foo', $val );
|
|
}
|
|
$m = get_metadata( 'post', 12345, 'foo', false );
|
|
$this->assertEqualSets( $vals, $m );
|
|
|
|
delete_metadata( 'post', 12345, 'foo' );
|
|
$m = get_metadata( 'post', 12345, 'foo', false );
|
|
$this->assertEqualSets( array(), $m );
|
|
}
|
|
|
|
public function test_with_meta_value() {
|
|
$vals = array( '0', '1', '2' );
|
|
foreach ( $vals as $val ) {
|
|
add_metadata( 'post', 12345, 'foo', $val );
|
|
}
|
|
$m = get_metadata( 'post', 12345, 'foo', false );
|
|
$this->assertEqualSets( $vals, $m );
|
|
|
|
delete_metadata( 'post', 12345, 'foo', '1' );
|
|
$m = get_metadata( 'post', 12345, 'foo', false );
|
|
$expected = array_diff( $vals, array( '1' ) );;
|
|
$this->assertEqualSets( $expected, $m );
|
|
}
|
|
|
|
/**
|
|
* @ticket 32224
|
|
*/
|
|
public function test_with_falsey_meta_value_should_not_delete_all_meta() {
|
|
$vals = array( '0', '1', '2' );
|
|
foreach ( $vals as $val ) {
|
|
add_metadata( 'post', 12345, 'foo', $val );
|
|
}
|
|
$m = get_metadata( 'post', 12345, 'foo', false );
|
|
$this->assertEqualSets( $vals, $m );
|
|
|
|
delete_metadata( 'post', 12345, 'foo', '0' );
|
|
$m = get_metadata( 'post', 12345, 'foo', false );
|
|
$expected = array_diff( $vals, array( '0' ) );;
|
|
$this->assertEqualSets( $expected, $m );
|
|
}
|
|
|
|
/**
|
|
* @ticket 32224
|
|
*
|
|
* This is a backwards compatiblity quirk.
|
|
*/
|
|
public function test_meta_value_should_be_ignored_when_empty_string() {
|
|
$vals = array( '0', '1', '2', '' );
|
|
foreach ( $vals as $val ) {
|
|
add_metadata( 'post', 12345, 'foo', $val );
|
|
}
|
|
$m = get_metadata( 'post', 12345, 'foo', false );
|
|
$this->assertEqualSets( $vals, $m );
|
|
|
|
delete_metadata( 'post', 12345, 'foo', '' );
|
|
$m = get_metadata( 'post', 12345, 'foo', false );
|
|
$this->assertEqualSets( array(), $m );
|
|
}
|
|
|
|
/**
|
|
* @ticket 32224
|
|
*/
|
|
public function test_meta_value_should_be_ignored_when_null() {
|
|
$vals = array( '0', '1', '2', '' );
|
|
foreach ( $vals as $val ) {
|
|
add_metadata( 'post', 12345, 'foo', $val );
|
|
}
|
|
$m = get_metadata( 'post', 12345, 'foo', false );
|
|
$this->assertEqualSets( $vals, $m );
|
|
|
|
delete_metadata( 'post', 12345, 'foo', null );
|
|
$m = get_metadata( 'post', 12345, 'foo', false );
|
|
$this->assertEqualSets( array(), $m );
|
|
}
|
|
|
|
/**
|
|
* @ticket 32224
|
|
*/
|
|
public function test_meta_value_should_be_ignored_when_false() {
|
|
$vals = array( '0', '1', '2', '' );
|
|
foreach ( $vals as $val ) {
|
|
add_metadata( 'post', 12345, 'foo', $val );
|
|
}
|
|
$m = get_metadata( 'post', 12345, 'foo', false );
|
|
$this->assertEqualSets( $vals, $m );
|
|
|
|
delete_metadata( 'post', 12345, 'foo', false );
|
|
$m = get_metadata( 'post', 12345, 'foo', false );
|
|
$this->assertEqualSets( array(), $m );
|
|
}
|
|
|
|
/**
|
|
* @ticket 35797
|
|
*/
|
|
public function test_delete_all_should_only_invalidate_cache_for_objects_matching_meta_value() {
|
|
$p1 = 1234;
|
|
$p2 = 5678;
|
|
|
|
add_metadata( 'post', $p1, 'foo', 'value1' );
|
|
add_metadata( 'post', $p2, 'foo', 'value2' );
|
|
|
|
// Prime caches.
|
|
update_meta_cache( 'post', array( $p1, $p2 ) );
|
|
|
|
$deleted = delete_metadata( 'post', 5, 'foo', 'value1', true );
|
|
|
|
$p1_cache = wp_cache_get( $p1, 'post_meta' );
|
|
$this->assertFalse( $p1_cache );
|
|
|
|
// Should not have been touched.
|
|
$p2_cache = wp_cache_get( $p2, 'post_meta' );
|
|
$this->assertNotEmpty( $p2_cache );
|
|
}
|
|
|
|
/**
|
|
* @ticket 35797
|
|
*/
|
|
public function test_delete_all_should_invalidate_cache_for_all_objects_with_meta_key_when_meta_value_is_not_provided() {
|
|
$p1 = 1234;
|
|
$p2 = 5678;
|
|
|
|
add_metadata( 'post', $p1, 'foo', 'value1' );
|
|
add_metadata( 'post', $p2, 'foo', 'value2' );
|
|
|
|
// Prime caches.
|
|
update_meta_cache( 'post', array( $p1, $p2 ) );
|
|
|
|
$deleted = delete_metadata( 'post', 5, 'foo', false, true );
|
|
|
|
$p1_cache = wp_cache_get( $p1, 'post_meta' );
|
|
$this->assertFalse( $p1_cache );
|
|
|
|
$p2_cache = wp_cache_get( $p2, 'post_meta' );
|
|
$this->assertFalse( $p2_cache );
|
|
}
|
|
}
|