sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
e70ebea219
Wordpress/tests/phpunit/tests
History
Scott Taylor e70ebea219 Unit Tests: one $factory to rule them all, and it shall be static. 
Using more than one instance of `WP_UnitTest_Factory` causes all kinds of craziness, due to out-of-sync internal generator sequences. Since we want to use `setUpBeforeClass`, we were creating ad hoc instances. To avoid that, we were injecting one `static` instance via Dependency Injection in `wpSetUpBeforeClass`. All tests should really use the `static` instance, so we will remove the instance prop `$factory`.

Replace `$this->factory` with `self::$factory` over 2000 times.
Rewrite all of the tests that were hard-coding dynamic values. 

#YOLOFriday



git-svn-id: https://develop.svn.wordpress.org/trunk@35225 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-16 21:04:12 +00:00
..
actions Move PHPUnit tests into a tests/phpunit directory. 2013-08-29 18:39:34 +00:00
admin Unit Tests: one $factory to rule them all, and it shall be static. 2015-10-16 21:04:12 +00:00
ajax Unit Tests: one $factory to rule them all, and it shall be static. 2015-10-16 21:04:12 +00:00
attachment Unit Tests: one $factory to rule them all, and it shall be static. 2015-10-16 21:04:12 +00:00
canonical Unit Tests: one $factory to rule them all, and it shall be static. 2015-10-16 21:04:12 +00:00
category Unit Tests: one $factory to rule them all, and it shall be static. 2015-10-16 21:04:12 +00:00
comment Unit Tests: one $factory to rule them all, and it shall be static. 2015-10-16 21:04:12 +00:00
customize Unit Tests: one $factory to rule them all, and it shall be static. 2015-10-16 21:04:12 +00:00
date Unit Tests: one $factory to rule them all, and it shall be static. 2015-10-16 21:04:12 +00:00
db Unit Tests: implement setUpBeforeClass() and tearDownAfterClass() on WP_UnitTestCase. Use late static binding (plus a gross fallback for PHP 5.2) to check if wpSetUpBeforeClass() or wpTearDownAfterClass() exist on the called class, and then call it and pass a static WP_UnitTest_Factory instance via Dependency Injection, if it exists. 2015-10-15 04:43:37 +00:00
dependencies Add a return value to wp_register_script() and wp_register_style() which matches the return value of WP_Dependencies::add(). 2015-05-10 19:56:15 +00:00
external-http Unit Tests: move some oEmbed tests that can trigger HTTP calls to Tests_External_HTTP_OEmbed. 2015-10-15 01:28:05 +00:00
feed Unit Tests: since [32953], we can just use self::delete_user() instead of using if logic for Multisite. 2015-10-16 19:51:32 +00:00
filesystem Require dependencies when appropriate in some unit test files. 2015-07-14 03:07:13 +00:00
formatting Unit Tests: one $factory to rule them all, and it shall be static. 2015-10-16 21:04:12 +00:00
functions Unit Tests: one $factory to rule them all, and it shall be static. 2015-10-16 21:04:12 +00:00
general Unit Tests: one $factory to rule them all, and it shall be static. 2015-10-16 21:04:12 +00:00
http Adjust detection of stream timeouts in maybe skip tests for https tests 2015-10-06 17:39:14 +00:00
image More explicit tests for image_get_intermediate_size(). 2015-10-02 14:13:15 +00:00
import Require dependencies when appropriate in some unit test files. 2015-07-14 03:07:13 +00:00
includes Unit Tests: one $factory to rule them all, and it shall be static. 2015-10-16 21:04:12 +00:00
link Unit Tests: one $factory to rule them all, and it shall be static. 2015-10-16 21:04:12 +00:00
meta Unit Tests: one $factory to rule them all, and it shall be static. 2015-10-16 21:04:12 +00:00
multisite Unit Tests: one $factory to rule them all, and it shall be static. 2015-10-16 21:04:12 +00:00
oembed Unit Tests: one $factory to rule them all, and it shall be static. 2015-10-16 21:04:12 +00:00
option Unit Tests: one $factory to rule them all, and it shall be static. 2015-10-16 21:04:12 +00:00
pomo Fix strict notices in Tests_POMO_PO. 2013-12-01 12:47:35 +00:00
post Unit Tests: one $factory to rule them all, and it shall be static. 2015-10-16 21:04:12 +00:00
query Unit Tests: one $factory to rule them all, and it shall be static. 2015-10-16 21:04:12 +00:00
rest-api Unit Tests: one $factory to rule them all, and it shall be static. 2015-10-16 21:04:12 +00:00
rewrite Unit Tests: one $factory to rule them all, and it shall be static. 2015-10-16 21:04:12 +00:00
term Unit Tests: one $factory to rule them all, and it shall be static. 2015-10-16 21:04:12 +00:00
theme Clean up 'post-thumbnail' theme support unit tests. 2014-11-01 04:00:59 +00:00
user Unit Tests: one $factory to rule them all, and it shall be static. 2015-10-16 21:04:12 +00:00
xmlrpc Unit Tests: one $factory to rule them all, and it shall be static. 2015-10-16 21:04:12 +00:00
actions.php Introduce doing_filter() and doing_action() to identify hooks in progress. 2014-02-26 18:43:59 +00:00
adminbar.php Unit Tests: one $factory to rule them all, and it shall be static. 2015-10-16 21:04:12 +00:00
auth.php Unit Tests: since [32953], we can just use self::delete_user() instead of using if logic for Multisite. 2015-10-16 19:51:32 +00:00
avatar.php Unit Tests: one $factory to rule them all, and it shall be static. 2015-10-16 21:04:12 +00:00
basic.php Unit Tests: move ->test_readme() out of Tests_Basic and into Tests_External_HTTP_Basic in tests/external-http/. 2015-10-15 00:22:50 +00:00
cache.php In cache tests, determine cache class name dynamically. 2015-10-13 02:06:19 +00:00
canonical.php Unit Tests: after [35186], "upgrade" the Canonical fixtures. 2015-10-15 05:50:40 +00:00
category.php Unit Tests: one $factory to rule them all, and it shall be static. 2015-10-16 21:04:12 +00:00
comment-submission.php Unit Tests: one $factory to rule them all, and it shall be static. 2015-10-16 21:04:12 +00:00
comment.php Unit Tests: one $factory to rule them all, and it shall be static. 2015-10-16 21:04:12 +00:00
compat.php WPDB: When checking that a string can be sent to MySQL, we shouldn't use mb_convert_encoding(), as it behaves differently to MySQL's character encoding conversion. 2015-05-06 02:59:50 +00:00
cron.php In PHPUnit test classes, parent::tearDown() should be the last thing done in tearDown() methods. 2015-03-05 13:14:15 +00:00
db.php Unit Tests: one $factory to rule them all, and it shall be static. 2015-10-16 21:04:12 +00:00
dbdelta.php Remove svn:executable from test files. 2015-07-26 09:40:58 +00:00
dependencies.php Remove tests for code still in development, see #22229. If accidentally run, they produce fatal errors. 2013-10-07 14:17:13 +00:00
file.php Tests: Clean up the resulting /tmp/foo* files from the tempnam call. 2015-03-31 02:10:52 +00:00
filters.php In remove_all_filters(), only remove callbacks that match the $priority parameter. 2014-12-31 19:06:29 +00:00
functions.php Unit Tests: one $factory to rule them all, and it shall be static. 2015-10-16 21:04:12 +00:00
kses.php KSES: have you ever heard of the <bdo> HTML tag? Same. http://www.w3schools.com/tags/tag_bdo.asp 2015-10-13 17:17:13 +00:00
l10n.php Remove failing is_textdomain_loaded() test. 2014-11-22 20:36:51 +00:00
link.php Unit Tests: one $factory to rule them all, and it shall be static. 2015-10-16 21:04:12 +00:00
mail.php Docs: Put "it's" in its place (again). 2015-09-16 12:45:51 +00:00
media.php Unit Tests: one $factory to rule them all, and it shall be static. 2015-10-16 21:04:12 +00:00
meta.php Unit Tests: one $factory to rule them all, and it shall be static. 2015-10-16 21:04:12 +00:00
multisite.php Initialise $_SERVER[ 'REMOTE_ADDR' ] during the test bootstrap so individual tests need not. 2015-09-15 08:04:33 +00:00
pluggable.php Improve [35146] to only skip pluggable function signature tests for wp-includes/cache.php when an external object cache is in use. 2015-10-13 20:44:16 +00:00
post.php Unit Tests: one $factory to rule them all, and it shall be static. 2015-10-16 21:04:12 +00:00
query.php Unit Tests: one $factory to rule them all, and it shall be static. 2015-10-16 21:04:12 +00:00
rest-api.php REST API: Introduce baby API to the world. 2015-10-08 02:30:18 +00:00
rewrite.php Unit Tests: one $factory to rule them all, and it shall be static. 2015-10-16 21:04:12 +00:00
shortcode.php Abstract the shortcode attribute parsing regex into its own function, update the JavaScript counterpart, and introduce a test to ensure they do not diverge again. 2015-10-08 03:11:59 +00:00
taxonomy.php Unit Tests: one $factory to rule them all, and it shall be static. 2015-10-16 21:04:12 +00:00
term.php Unit Tests: one $factory to rule them all, and it shall be static. 2015-10-16 21:04:12 +00:00
theme.php Themes: Get the correct theme when template and stylesheet were both passed as arguments. 2015-08-30 21:44:38 +00:00
upload.php wp_upload_dir() has a (little-known?) side effect: if you call it, it will attempt to create an uploads directory for the current month. As such, tearDown() and cleanup routines have to be in sync with this behavior when deleting bogus directories used in unit tests. 2014-11-30 19:05:52 +00:00
url.php Unit Tests: one $factory to rule them all, and it shall be static. 2015-10-16 21:04:12 +00:00
user.php Unit Tests: one $factory to rule them all, and it shall be static. 2015-10-16 21:04:12 +00:00
walker.php Add unit tests for Walker class. 2014-08-01 20:35:25 +00:00
widgets.php Unit Tests: one $factory to rule them all, and it shall be static. 2015-10-16 21:04:12 +00:00