sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
ee2c079ade
Wordpress/tests/phpunit/tests
History
Boone Gorges ee2c079ade Ensure that comment permalinks reflect pagination. 
After [34561], `wp_list_comments()` no longer passed all of a post's comments
to `Walker_Comments`. As a result, calls to `get_comment_link()` occurring
inside the comment loop had insufficient context to determine the proper
'cpage' value to use when generating comment permalinks. This, in turn, caused
comment permalinks to behave erratically.

The current changeset addresses the problem as follows:

* `get_comment_link()` now accepts a 'cpage' parameter. When present, 'cpage' will be used to build the comment permalink - no automatic calculation will take place.
* When called within the main loop, `wp_list_comments()` calculates the proper 'cpage' value for comments in the loop, and passes it down to `get_comment_link()`.
* `cpage` and `comment-page-x` query vars are generally required in comment permalinks (see #34068), but an exception is made when 'default_comment_page=oldest': the bare post permalink will always be the same as `cpage=1`, so `cpage` is excluded in this case.

Props peterwilsoncc for assiduous spreadsheeting.
Fixes #34073.

git-svn-id: https://develop.svn.wordpress.org/trunk@34735 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-01 05:12:39 +00:00
..
actions
admin Add unit tests for post_exists(). 2015-09-29 04:02:00 +00:00
ajax Initialise $_SERVER[ 'REMOTE_ADDR' ] during the test bootstrap so individual tests need not. 2015-09-15 08:04:33 +00:00
attachment
canonical Canonical/Rewrite: sanity check posts that are paged with <!--nextpage-->. Page numbers past the max number of pages are returning the last page of content and causing infinite duplicate content. 2015-09-24 14:03:05 +00:00
category Fix 'exclude_tree' in wp_list_categories(). 2015-09-29 19:11:12 +00:00
comment Ensure that comment permalinks reflect pagination. 2015-10-01 05:12:39 +00:00
customize Customizer: Defer embedding widget controls to improve DOM performance and initial load time. 2015-09-25 21:01:46 +00:00
date
db WPDB: Make sure we don't run sanity checks on DB dropins. 2015-09-28 01:16:29 +00:00
dependencies Add a return value to wp_register_script() and wp_register_style() which matches the return value of WP_Dependencies::add(). 2015-05-10 19:56:15 +00:00
feed Tests: Update Tests_Feed_RSS::test_items to expect new comment permalink structure. 2015-09-12 23:30:11 +00:00
filesystem Require dependencies when appropriate in some unit test files. 2015-07-14 03:07:13 +00:00
formatting Revert r34674 due to failures on PHP < 5.4. 2015-09-29 01:00:17 +00:00
functions Allow wp_get_archives() to accept post_type as an arg. 2015-09-29 05:10:10 +00:00
general Tests: Relocate tests for general-template.php to a more logically-placed (and named) file, tests/general/template.php. 2015-09-29 05:51:14 +00:00
http Switch several assertions to assertNotWPError() so more context is provided when the assertion fails. 2015-09-27 22:26:16 +00:00
image Media: In wp_read_image_metadata(), include IPTC Keywords when available in $meta. 2015-09-22 04:18:02 +00:00
import Require dependencies when appropriate in some unit test files. 2015-07-14 03:07:13 +00:00
includes Remove svn:executable from test files. 2015-07-26 09:40:58 +00:00
link Force comment pagination on single posts. 2015-09-25 20:39:18 +00:00
meta Avoid returning duplicate matches when using a meta query in WP_User_Query. 2015-06-09 17:41:35 +00:00
multisite Revert change from true to false in multisite upload test 2015-09-26 20:58:22 +00:00
option Use WP_TESTS_DOMAIN where it should be used in tests in place of hard-coded uses of example.org. 2015-09-24 21:01:10 +00:00
pomo
post Tests: Add two tests for the current behavior of the 'hierarchical' and 'child_of' arguments in get_pages(). 2015-09-29 21:27:03 +00:00
query Allow setup_postdata() to accept a post ID. 2015-09-12 20:57:06 +00:00
rewrite Rewrite: Redirect attachment URLs when their slug changes. 2015-09-29 04:57:02 +00:00
term Fix db_version juggling during non-multisite tests. 2015-09-30 13:27:09 +00:00
theme
user Tests: Consolidate author-template tests into a single, more logically-placed file, tests/user/author.php. 2015-09-29 05:37:00 +00:00
xmlrpc XML-RPC: add a unit test for mw.editPost. 2015-09-29 04:27:57 +00:00
actions.php
adminbar.php Update links to the user profile editing screen in the admin toolbar when the current logged in user has no role on the current site. Covers single site and Multisite and introduces tests. 2015-09-14 17:09:58 +00:00
auth.php Add 'wp_verify_nonce_failed' action that fires when nonce verification fails. 2015-08-26 00:05:11 +00:00
avatar.php Remove svn:executable from test files. 2015-07-26 09:40:58 +00:00
basic.php Tests: Check that readme.html is recommending an actively supported version of MySQL. 2015-09-08 03:23:29 +00:00
cache.php
canonical.php Canonical/Rewrite: sanity check posts that are paged with <!--nextpage-->. Page numbers past the max number of pages are returning the last page of content and causing infinite duplicate content. 2015-09-24 14:03:05 +00:00
category.php In Walker_CategoryDropdown::start_el(), cast values to strings before deciding whether to append 'selected' attribute. 2015-08-21 01:10:34 +00:00
comment.php WP_Comment::get_children() test should be order-agnostic. 2015-09-27 02:00:49 +00:00
compat.php WPDB: When checking that a string can be sent to MySQL, we shouldn't use mb_convert_encoding(), as it behaves differently to MySQL's character encoding conversion. 2015-05-06 02:59:50 +00:00
cron.php
db.php WPDB: get_table_from_query() didn't find table names with hyphens in them. 2015-08-24 00:18:49 +00:00
dbdelta.php Remove svn:executable from test files. 2015-07-26 09:40:58 +00:00
dependencies.php
file.php
filters.php
functions.php Date/Time: Add unit tests for the_date(). 2015-09-24 03:33:21 +00:00
kses.php Shortcodes: Improve the reliablity of shortcodes inside HTML tags. 2015-07-22 05:14:50 +00:00
l10n.php
link.php Permalinks: Add pretty permalinks for unattached attachments. 2015-09-29 09:41:14 +00:00
mail.php Docs: Put "it's" in its place (again). 2015-09-16 12:45:51 +00:00
media.php Cleanup image size in unit tests 2015-09-29 17:47:24 +00:00
meta.php
multisite.php Initialise $_SERVER[ 'REMOTE_ADDR' ] during the test bootstrap so individual tests need not. 2015-09-15 08:04:33 +00:00
pluggable.php Add function signature tests for the pluggable functions in wp-admin/includes/schema.php and wp-admin/includes/upgrade.php. 2015-09-26 22:03:53 +00:00
post.php In wp_insert_post(), when setting $post_author, use isset() instead of ! empty() to allow 0 to be passed as the value for $post_author. 2015-09-12 18:53:56 +00:00
query.php WP_Query should not ignore an offset of 0. 2015-09-29 19:36:16 +00:00
rewrite.php Rewrite: allow add_rewrite_rule|WP_Rewrite::add_rule() to accept an associative array for the value of $redirect instead of requiring a query string. 2015-09-30 01:10:03 +00:00
shortcode.php Add some more data for Shortcode unit tests. 2015-08-25 21:50:55 +00:00
taxonomy.php Allow taxonomies to be non-public. 2015-09-16 19:04:57 +00:00
term.php Switch several assertions to assertNotWPError() so more context is provided when the assertion fails. 2015-09-27 22:26:16 +00:00
theme.php Themes: Get the correct theme when template and stylesheet were both passed as arguments. 2015-08-30 21:44:38 +00:00
upload.php
url.php force_ssl_login() has been functionally identical to force_ssl_admin() since 4.0 (#10267), so its test assertions can be removed as the function has been deprecated in [34700]. The remaining assertions suitably cover force_ssl_admin(). 2015-09-29 21:43:04 +00:00
user.php Add unit test verifying that 60 char user_login is valid. 2015-09-27 15:41:11 +00:00
walker.php
widgets.php Customizer: Defer embedding widget controls to improve DOM performance and initial load time. 2015-09-25 21:01:46 +00:00