sergiotarxz/libvips
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

improve behaviour of pipelines with seq sources

Browse Source 
Loaders which supported random access would not set the seq flag even if
seq mode was requested.

This would make operations like shrinkv to not run in seq mode, causing
massive cache thrashing.

See https://github.com/libvips/libvips/discussions/2898
This commit is contained in:
John Cupitt 2022-06-29 17:54:20 +01:00
parent 6dfb49b976
commit 0971344785
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
libvips/foreign/foreign.c
View File

@ -1064,9 +1064,9 @@ vips_foreign_load_build( VipsObject *object )
g_object_set( load, "flags", flags, NULL );
/* Seq access has been requested and the loader supports seq.
/* Seq access has been requested, or the loader requires seq.
*/
sequential = (load->flags & VIPS_FOREIGN_SEQUENTIAL) &&
sequential = (load->flags & VIPS_FOREIGN_SEQUENTIAL) ||
load->access != VIPS_ACCESS_RANDOM;
/* We must block caching of seq loads.
@ -1136,7 +1136,7 @@ vips_foreign_load_build( VipsObject *object )
/* Tell downstream if we are reading sequentially.
*/
if( sequential )
if( sequential )
vips_image_set_int( load->out, VIPS_META_SEQUENTIAL, 1 );
return( 0 );