From 1bded6682e978d8115ed6963fcf22402dbe9fe08 Mon Sep 17 00:00:00 2001 From: John Cupitt Date: Fri, 29 Jul 2011 13:24:52 +0100 Subject: [PATCH] todo update --- TODO | 15 +++++++++++++++ benchmark/benchmarkn.sh | 11 +++++------ 2 files changed, 20 insertions(+), 6 deletions(-) diff --git a/TODO b/TODO index 8937bcf2..60b57013 100644 --- a/TODO +++ b/TODO @@ -1,3 +1,18 @@ +- in benchmark, try: + + vips im_benchmarkn temp.v temp2.v 1 + vips --vips-concurrency=99 --vips-tile-width=10 --vips-tile-height=10 \ + im_benchmarkn temp.v temp2a.v 1 + vips im_avg temp2a.v + vips im_avg temp2.v + + get different results :-( + + 7.24 seems to fail this test too argh + + first column of tiles is fine, but stuff to the right of that is broken + + - leak check, again diff --git a/benchmark/benchmarkn.sh b/benchmark/benchmarkn.sh index a2cff47e..16a40b63 100755 --- a/benchmark/benchmarkn.sh +++ b/benchmark/benchmarkn.sh @@ -7,7 +7,7 @@ vips --version # how large an image do you want to process? # sample2.v is 290x442 pixels ... replicate this many times horizontally and # vertically to get a highres image for the benchmark -tile=13 +tile=2 # how complex an operation do you want to run? # this sets the number of copies of the benchmark we chain together: @@ -27,13 +27,12 @@ echo " by" `header -f Ysize temp.v` "pixels" echo "starting benchmark ..." echo "chain=$chain" -for cpus in 1 2 3 4 5 6 ; do +for cpus in 1 2 3 4 ; do export IM_CONCURRENCY=$cpus echo IM_CONCURRENCY=$IM_CONCURRENCY echo time -p vips im_benchmarkn temp.v temp2.v $chain - time -p vips im_benchmarkn temp.v temp2.v $chain - time -p vips im_benchmarkn temp.v temp2.v $chain + time -p vips im_benchmarkn temp.v temp2-$cpus.v $chain if [ $? != 0 ]; then echo "benchmark failed -- install problem?" @@ -42,6 +41,6 @@ for cpus in 1 2 3 4 5 6 ; do # find pixel average ... should be the same for all IM_CONCURRENCY settings # or we have some kind of terrible bug - echo vips im_avg temp2.v - vips im_avg temp2.v + echo vips im_avg temp2-$cpus.v + vips im_avg temp2-$cpus.v done