From 6ea76f9632edd93a716533acb78e7f6bd7089fe4 Mon Sep 17 00:00:00 2001
From: John Cupitt <jcupitt@gmail.com>
Date: Fri, 30 Aug 2019 11:00:25 +0100
Subject: [PATCH] improve data_length handling in jpg load

libjpeg uses unsigned ints for data length, so we must use size_t
everywhere.
---
 ChangeLog                   | 1 +
 libvips/foreign/jpeg2vips.c | 8 ++++----
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index b7fad021..925eb6ff 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -17,6 +17,7 @@
 - fix sharpen with sigma 0.5 [2h4dl]
 - sharpen restores input colourspace
 - verify bands/format for coded images
+- improve data_length handling for jpeg metadata
 
 24/5/19 started 8.8.1
 - improve realpath() use on older libc
diff --git a/libvips/foreign/jpeg2vips.c b/libvips/foreign/jpeg2vips.c
index 1060bc9e..d4af258f 100644
--- a/libvips/foreign/jpeg2vips.c
+++ b/libvips/foreign/jpeg2vips.c
@@ -307,7 +307,7 @@ find_chroma_subsample( struct jpeg_decompress_struct *cinfo )
 }
 
 static int
-attach_blob( VipsImage *im, const char *field, void *data, int data_length )
+attach_blob( VipsImage *im, const char *field, void *data, size_t data_length )
 {
 	/* Only use the first one.
 	 */
@@ -333,7 +333,7 @@ attach_blob( VipsImage *im, const char *field, void *data, int data_length )
  * the real XMP.
  */
 static int
-attach_xmp_blob( VipsImage *im, void *data, int data_length )
+attach_xmp_blob( VipsImage *im, void *data, size_t data_length )
 {
 	char *p = (char *) data;
 	int i;
@@ -496,7 +496,7 @@ read_jpeg_header( ReadJpeg *jpeg, VipsImage *out )
 	for( p = cinfo->marker_list; p; p = p->next ) {
 #ifdef DEBUG
 {
-		printf( "read_jpeg_header: seen %d bytes of APP%d\n",
+		printf( "read_jpeg_header: seen %u bytes of APP%d\n",
 			p->data_length,
 			p->marker - JPEG_APP0 );
 
@@ -593,7 +593,7 @@ read_jpeg_header( ReadJpeg *jpeg, VipsImage *out )
 		default:
 #ifdef DEBUG
 			printf( "read_jpeg_header: "
-				"ignoring %d byte APP%d block\n", 
+				"ignoring %u byte APP%d block\n", 
 				p->data_length, p->marker - JPEG_APP0 );
 #endif /*DEBUG*/
 			break;