sergiotarxz
/
libvips
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

oops

This commit is contained in:
John Cupitt 2011-01-24 10:40:40 +00:00
parent 1ac1c13109
commit 823650b2b4
3 changed files with 20 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
ChangeLog
View File

@ -8,6 +8,7 @@
- don't use tables for bilinear on float data for a small speedup (thanks - don't use tables for bilinear on float data for a small speedup (thanks
Nicolas Robidoux) Nicolas Robidoux)
- no tables for uchar either, about a 15% speedup (thanks Nicolas) - no tables for uchar either, about a 15% speedup (thanks Nicolas)
- dmask write was broken
30/11/10 started 7.24.0 30/11/10 started 7.24.0
- bump for new stable - bump for new stable

10
TODO
View File

@ -1,3 +1,13 @@
- im__open_write() should take a mode (text / binary)
rw_mask.c has copies of im__open_write() etc. which use text mode, remove
them
- use |_O_TEMPORARY to open()'s mode on Windows for tmpfiles to increase the - use |_O_TEMPORARY to open()'s mode on Windows for tmpfiles to increase the
chances we actually delete chances we actually delete

15
libvips/mask/rw_mask.c
View File

@ -47,11 +47,13 @@
* error messagge * error messagge
* 21/10/10 * 21/10/10
* - gtk-doc * - gtk-doc
* - you can use commas to separate eader fields * - you can use commas to separate header fields
* - small cleanups * - small cleanups
* 30/11/10 * 30/11/10
* - im_scale_dmask() normalises to 20, not 100 ... we hit the fast * - im_scale_dmask() normalises to 20, not 100 ... we hit the fast
* conv path more often * conv path more often
* 24/1/10
* - oops, missing braces in write dmask removed spaces between items
*/ */
/* /*
@ -128,7 +130,7 @@
* written to the output image. * written to the output image.
* *
* @scale and @offset default to 1 and 0. Various functions, such as * @scale and @offset default to 1 and 0. Various functions, such as
* im_conv(), will fail of @scale is zero. * im_conv(), will fail if @scale is zero.
* *
* You can read and write the matrix elements in @coeff. * You can read and write the matrix elements in @coeff.
*/ */
@ -149,7 +151,7 @@
* written to the output image. * written to the output image.
* *
* @scale and @offset default to 1.0 and 0.0. Various functions, such as * @scale and @offset default to 1.0 and 0.0. Various functions, such as
* im_conv(), will fail of @scale is zero. * im_conv(), will fail if @scale is zero.
* *
* You can read and write the matrix elements in @coeff. * You can read and write the matrix elements in @coeff.
*/ */
@ -264,7 +266,7 @@ im_create_imask( const char *filename, int xsize, int ysize )
* @ysize: mask height * @ysize: mask height
* @Varargs: values to set for the mask * @Varargs: values to set for the mask
* *
* Create an imask and initialise it from the funtion parameter list. * Create an imask and initialise it from the function parameter list.
* *
* See also: im_create_imask(). * See also: im_create_imask().
* *
@ -347,7 +349,7 @@ im_create_dmask( const char *filename, int xsize, int ysize )
* @ysize: mask height * @ysize: mask height
* @Varargs: values to set for the mask * @Varargs: values to set for the mask
* *
* Create a dmask and initialise it from the funtion parameter list. * Create a dmask and initialise it from the function parameter list.
* *
* See also: im_create_dmask(). * See also: im_create_dmask().
* *
@ -925,9 +927,10 @@ im_write_dmask_name( DOUBLEMASK *in, const char *filename )
write_line( fp, "\n" ); write_line( fp, "\n" );
for( i = 0, y = 0; y < in->ysize; y++ ) { for( i = 0, y = 0; y < in->ysize; y++ ) {
for( x = 0; x < in->xsize; x++, i++ ) for( x = 0; x < in->xsize; x++, i++ ) {
write_double( fp, in->coeff[i] ); write_double( fp, in->coeff[i] );
write_line( fp, " " ); write_line( fp, " " );
}
if( write_line( fp, "\n" ) ) { if( write_line( fp, "\n" ) ) {
fclose( fp ); fclose( fp );