sergiotarxz/libvips
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

update notes

Browse Source
This commit is contained in:
John Cupitt 2016-04-02 20:24:54 +01:00
parent 8fb146029c
commit 8aa4566c87
2 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
TODO
View File

@ -1,7 +1,6 @@
- try - try
vips reducev ~/pics/babe.jpg x.png 2.666 $ vips reducev ~/pics/babe.jpg x.png 2.666
get 254 for white, some rounding problem get 254 for white, some rounding problem

11
libvips/resample/reducev.cpp
View File

@ -282,7 +282,7 @@ vips_reducev_compile( VipsReducev *reducev )
/* Generate passes until we've used up the whole mask. /* Generate passes until we've used up the whole mask.
*/ */
for( int i = 0;;) { for( int i = 0;; ) {
/* Allocate space for another pass. /* Allocate space for another pass.
*/ */
if( reducev->n_pass == MAX_PASS ) if( reducev->n_pass == MAX_PASS )
@ -681,7 +681,6 @@ vips_reducev_vector_gen( VipsRegion *out_region, void *vseq,
return( 0 ); return( 0 );
} }
/* Make a fixed-point version of a mask. Each out[i] = rint(in[i] * adj_scale), /* Make a fixed-point version of a mask. Each out[i] = rint(in[i] * adj_scale),
* where adj_scale is selected so that sum(out) = sum(in) * scale. * where adj_scale is selected so that sum(out) = sum(in) * scale.
* *
@ -721,12 +720,20 @@ vips_reducev_intize( double *in, int *out, int n, int scale )
for( int i = 0; i < n; i++ ) for( int i = 0; i < n; i++ )
sum += out[i]; sum += out[i];
/* If we've picked low and high correctly, see above.
*/
g_assert( sum >= low );
g_assert( sum <= high );
if( sum == target ) if( sum == target )
break; break;
if( sum < target ) if( sum < target )
low = guess; low = guess;
if( sum > target ) if( sum > target )
high = guess; high = guess;
/* This will typically produce about 5 iterations.
*/
} while( high - low > 0.01 ); } while( high - low > 0.01 );
if( sum != target ) if( sum != target )