From c6214b4d478b55bc00324fb119b93c76918fdcd5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Felix=20B=C3=BCnemann?= Date: Thu, 11 Aug 2022 17:02:03 +0200 Subject: [PATCH] Remove even pixel check for J2K subsample_mode auto (#2975) Having a different colorspace and chroma subsampling just because the source image happens to be an even or odd number of pixels is surprising and hard to debug, so let's remove it. --- libvips/foreign/jp2ksave.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libvips/foreign/jp2ksave.c b/libvips/foreign/jp2ksave.c index 5ee40ef8..5802fc39 100644 --- a/libvips/foreign/jp2ksave.c +++ b/libvips/foreign/jp2ksave.c @@ -795,8 +795,6 @@ vips_foreign_save_jp2k_build( VipsObject *object ) jp2k->subsample = !jp2k->lossless && jp2k->Q < 90 && - save->ready->Xsize % 2 == 0 && - save->ready->Ysize % 2 == 0 && (save->ready->Type == VIPS_INTERPRETATION_sRGB || save->ready->Type == VIPS_INTERPRETATION_RGB16) && save->ready->Bands == 3;