From c8ff970476fa9747963029dc753ce70ae0f5f0c7 Mon Sep 17 00:00:00 2001 From: John Cupitt Date: Tue, 27 Aug 2019 09:14:59 +0100 Subject: [PATCH] make jpeg buffer free safer possible race in free --- libvips/foreign/vips2jpeg.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libvips/foreign/vips2jpeg.c b/libvips/foreign/vips2jpeg.c index d941b961..03b97de5 100644 --- a/libvips/foreign/vips2jpeg.c +++ b/libvips/foreign/vips2jpeg.c @@ -776,9 +776,6 @@ empty_output_buffer( j_compress_ptr cinfo ) METHODDEF(void) init_destination( j_compress_ptr cinfo ) { - OutputBuffer *buf = (OutputBuffer *) cinfo->dest; - - vips_dbuf_init( &buf->dbuf ); empty_output_buffer( cinfo ); } @@ -845,6 +842,7 @@ buf_dest( j_compress_ptr cinfo, void **obuf, size_t *olen ) /* Save output parameters. */ + vips_dbuf_init( &buf->dbuf ); buf->obuf = obuf; buf->olen = olen; }