Commit Graph

6160 Commits

Author SHA1 Message Date
John Cupitt
5ddc154a81 prevent int overflow for int pixels in shrinkh
by using double for an accumulator
2019-08-06 17:00:53 +01:00
John Cupitt
6ba34e479e better shrinkv for int32 types
use double as the sum type to prevent int overflow
2019-08-06 16:55:10 +01:00
John Cupitt
25b6f2fcf1 Merge branch 'revise-pthread' 2019-08-06 16:25:16 +01:00
John Cupitt
fb92783659 musl is now 128kb, so make the comment vague
36676c59fc (commitcomment-34589167)
2019-08-06 15:53:38 +01:00
John Cupitt
5649f6d865 update for "make dist" 2019-08-06 15:33:40 +01:00
John Cupitt
36676c59fc small polish to pthread discovery
- use AC_CHECK_FUNC() not AC_CHECK_FUNCS()
- safer names for save vars
2019-08-06 14:56:05 +01:00
John Cupitt
98f3bf78a5 fix doc spelling of "optimise" 2019-08-06 14:46:43 +01:00
John Cupitt
8b76606a23
Merge pull request #1387 from omira-sch/fuzz-corpus
Add oss-fuzz fixed testcases for regression testing
2019-08-06 14:13:58 +01:00
Oscar Mira
4304ef35ee add already fixed testcases to fuzz corpus 2019-08-06 13:37:41 +02:00
Oscar Mira
7c8af4e78a remove stale file 2019-08-06 13:37:41 +02:00
Oscar Mira
2211565eee fix .gitignore 2019-08-06 13:37:41 +02:00
John Cupitt
fb0069528d
Merge pull request #1386 from omira-sch/fuzz-improve-coverage
add smaller images suitable for fuzzing
2019-08-06 12:18:51 +01:00
Oscar Mira
e14a9b9221 add small images suitable for fuzzing 2019-08-06 12:29:34 +02:00
John Cupitt
bdc61d5675 layout 2019-08-05 13:53:00 +01:00
John Cupitt
0d2c14c967 try to improve pthread discovery
we were not using all the flags we should when testing for
pthread_setattr_default_np() ... place the test line after GTHREAD and
use those flags for linking

see https://github.com/libvips/libvips/issues/1384

thanks elfring
2019-08-05 13:35:47 +01:00
John Cupitt
503e83e232 update resize C++ example 2019-08-04 17:43:35 +01:00
John Cupitt
f472df4444 block /0 in unpremultiply 2019-08-04 14:01:42 +01:00
John Cupitt
64d42be091 better invert of gray signed int tiffs 2019-08-04 03:55:39 +01:00
John Cupitt
2841504fa0 fix a possible int overflow 2019-08-03 21:14:19 +01:00
John Cupitt
2a094995a3 fix warning in rect hash 2019-08-03 04:03:43 +01:00
John Cupitt
3c8a9815ba fix int overflow in shrinkv 2019-08-03 03:31:54 +01:00
John Cupitt
42cdc8177c git switch working 2019-08-02 20:19:28 +01:00
John Cupitt
cfe0857ae1
Merge pull request #1379 from omira-sch/undefined-sanitizer
Add undefined sanitizer
2019-08-02 20:07:19 +01:00
Oscar Mira
78c0014708 add UBSAN sanitizer 2019-08-02 19:46:42 +02:00
Oscar Mira
cf655c6fbe fix fuzzing specific build macro 2019-08-02 19:46:42 +02:00
John Cupitt
4a05c67345
Merge pull request #1381 from omira-sch/fuzzing-large-images
skip large images in the fuzzers not in the lib
2019-08-02 18:41:46 +01:00
Oscar Mira
45de60e571 skip large images in the fuzzers not in the lib
This reverts commit 0accdf858b.
2019-08-02 17:56:33 +02:00
John Cupitt
4ce745dbee nudge travis 2019-08-02 11:05:49 +01:00
John Cupitt
0accdf858b band large image during fuzzing
Large images cause a lot of uninteresting OOMs and timeouts during
fuzzing. Ban them.
2019-08-02 10:53:32 +01:00
John Cupitt
0a225314b9 fix int overflow in flatten 2019-08-02 10:17:57 +01:00
John Cupitt
f0d1a5d82b note PNG comment fix 2019-08-02 10:11:16 +01:00
John Cupitt
4ea50fe6f0 better support for very long PNG comment names
pngs can have names comments -- improve support for very long comments.
2019-08-02 10:08:45 +01:00
John Cupitt
c361731693 better support for very long PNG comment names
pngs can have names comments -- improve support for very long comments.
2019-08-02 05:40:40 +01:00
John Cupitt
834acad825 fix << on signed int warnings
<< on a negative number is undefined behaviour in C, and will trigger
fuzzer warnings.
2019-08-02 05:35:18 +01:00
John Cupitt
0a51ca96c9 mostly working
still fails to exit cleanly
2019-08-01 20:57:46 +01:00
John Cupitt
0f1e278dd9 oop dropped a comment 2019-07-29 10:11:57 +01:00
John Cupitt
332e97272a Merge branch '8.8' 2019-07-29 10:07:29 +01:00
John Cupitt
5e77ab948b fix loop with malformed ppm
skip_line in ppm parse was not testing for EOF, so it could get stuck
with malformed files

thanks Kyle-Kyle

see https://github.com/libvips/libvips/issues/1377
2019-07-29 10:05:55 +01:00
John Cupitt
6078ba744c added more 2019-07-29 09:56:22 +01:00
John Cupitt
1220cc9667 start mapimage 2019-07-28 19:40:37 +01:00
John Cupitt
6a75776272 Merge branch 'loader-minimise-experiment' 2019-07-28 17:23:01 +01:00
John Cupitt
0e5447e537 final cleanup 2019-07-28 17:15:54 +01:00
John Cupitt
5ef14db544 put close-on-last-line back for jpg/tif/png
consider something like:

$ vips arrayjoin "$(echo *.jpg)" x.tif --across 10 --vips-progress

close on minimise won't close until the whole pipeline finishes, so
we'll need to keep every input file open

close on last line will shut down inputs as we are done with them, so we
save a lot of file descriptors

this patch puts close-on-last-line back for jpg/tif/png
2019-07-28 11:34:40 +01:00
John Cupitt
55ae22608f nope, revert
it's not possible to get inisert to trigger minimise reliably, since
threads can be out of order in the middle of the pipeline

we need to add minimise on Y (as before) to get reliable behaviour for
this case
2019-07-27 17:35:34 +01:00
John Cupitt
7f08e8fd28 remove stray flag 2019-07-27 16:13:54 +01:00
John Cupitt
01a82646a1 experiment with minimise in insert
try minimising sub after we've passed it
2019-07-27 13:40:18 +01:00
John Cupitt
67f3cc13ec remove old close-early comment from openexr load
no longer relevant in the world of minimise
2019-07-25 11:34:50 +01:00
John Cupitt
53e0bc6698 pdfload / pdfiumload use minimise to close early
see https://github.com/libvips/libvips/issues/1370#issuecomment-514949292
2019-07-25 11:31:21 +01:00
John Cupitt
9373d63d6e better early close for gif header read 2019-07-24 18:17:54 +01:00
John Cupitt
265cb8dffd close heif early for header read err
we were only closing early if there was an error during pixel read
2019-07-24 18:00:37 +01:00