sergiotarxz/nuttx-apps
sergiotarxz/nuttx-apps
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix some trivial typos. Add a comment to a C file.

Browse Source
This commit is contained in:
Gregory Nutt 2018-05-28 08:01:18 -06:00
parent 63db94efbc
commit 06dae98ce2
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
system/zmodem/README.txt
View File

@ -34,7 +34,7 @@ Buffering Notes
Software Flow Control Software Flow Control
--------------------- ---------------------
The ZModem protocol has XON/XOFF flow control built into it. The protocol The ZModem protocol has XON/XOFF flow control built into it. The protocol
requires that XON or XOFF be placed at certain parts of messages. If permits XON or XOFF characters placed at certain parts of messages. If
software flow control is enabled on the receiving end it will consume the software flow control is enabled on the receiving end it will consume the
XONs and XOFFs. Otherwise they will be ignored in the data by the ZModem XONs and XOFFs. Otherwise they will be ignored in the data by the ZModem
logic. logic.
@ -45,7 +45,7 @@ Buffering Notes
The XON/XOFF controls built into ZModem could be used if you enabled The XON/XOFF controls built into ZModem could be used if you enabled
software flow control in the host. But that would only work in one software flow control in the host. But that would only work in one
direction: If would prevent the host from overrunning the the target Rx direction: If would prevent the host from overrunning the the target Rx
buffing. So you should be able to do host-to-target software flow buffering. So you should be able to do host-to-target software flow
control. But there would still be no target-to-host flow control. That control. But there would still be no target-to-host flow control. That
might not be an issue because the host is usually so much faster than might not be an issue because the host is usually so much faster than
that target. that target.
@ -53,7 +53,7 @@ Buffering Notes
RX Buffer Size RX Buffer Size
-------------- --------------
The ZModem protocol supports a message that informs the file sender of The ZModem protocol supports a message that informs the file sender of
the maximum size of dat that you can buffer (ZRINIT). However, my the maximum size of data that you can buffer (ZRINIT). However, my
experience is that the Linux sz ignores this setting and always sends file experience is that the Linux sz ignores this setting and always sends file
data at the maximum size (1024) no matter what size of buffer you report. data at the maximum size (1024) no matter what size of buffer you report.
That is unfortunate because that, combined with the possibilities of data That is unfortunate because that, combined with the possibilities of data

2
system/zmodem/zm_send.c
View File

@ -1052,6 +1052,8 @@ static int zms_sendpacket(FAR struct zm_state_s *pzm)
} }
else else
{ {
/* REVISIT: Why complemented? */
crc = ~crc; crc = ~crc;
for (i = 0; i < 4; i++, crc >>= 8) for (i = 0; i < 4; i++, crc >>= 8)
{ {