sergiotarxz/nuttx-apps
sergiotarxz/nuttx-apps
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

nshlib: Remove fdopen for the stdin, stdout and stderr

Browse Source 
not really need since these file stream should be opened automatically

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
This commit is contained in:
Xiang Xiao 2020-12-15 15:34:56 +08:00 committed by Masayuki Ishikawa
parent c335c13578
commit 28362eb6d1
2 changed files with 0 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
nshlib/nsh_console.c
View File

@ -481,29 +481,6 @@ FAR struct console_stdio_s *nsh_newconsole(void)
pstate->cn_vtbl.redirect = nsh_consoleredirect;
pstate->cn_vtbl.undirect = nsh_consoleundirect;
#if 0
/* (Re-) open the console input device */
#ifdef CONFIG_NSH_ALTCONDEV
pstate->cn_confd = open(CONFIG_NSH_ALTSTDIN, O_RDWR);
if (pstate->cn_confd < 0)
{
free(pstate);
return NULL;
}
/* Create a standard C stream on the console device */
pstate->cn_constream = fdopen(pstate->cn_confd, "r+");
if (!pstate->cn_constream)
{
close(pstate->cn_confd);
free(pstate);
return NULL;
}
#endif
#endif /* if 0 */
/* Initialize the error stream */
pstate->cn_errfd = ERRFD(pstate);

11
nshlib/nsh_usbconsole.c
View File

@ -87,17 +87,6 @@ static void nsh_configstdio(int fd)
dup2(fd, 0);
dup2(fd, 1);
dup2(fd, 2);
/* fdopen to get the stdin, stdout and stderr streams.
*
* fd = 0 is stdin (read-only)
* fd = 1 is stdout (write-only, append)
* fd = 2 is stderr (write-only, append)
*/
fdopen(0, "r");
fdopen(1, "a");
fdopen(2, "a");
}
/****************************************************************************