From 60ca4a1ef4dbc47da9d85703a9c277a63d8565d5 Mon Sep 17 00:00:00 2001 From: Sebastien Lorquet Date: Fri, 19 May 2017 17:13:27 +0200 Subject: [PATCH 1/4] Ensure netlib will not be broken when setip will not bring the network up anymore --- examples/nettest/nettest.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/examples/nettest/nettest.c b/examples/nettest/nettest.c index 12b33e02b..5f6c97b4e 100644 --- a/examples/nettest/nettest.c +++ b/examples/nettest/nettest.c @@ -159,6 +159,11 @@ static void netest_initialize(void) netlib_set_ipv6netmask("eth0", (FAR const struct in6_addr *)g_ipv6_netmask); + /* New versions of netlib_set_ipv6addr will not bring the network up, + * So ensure the network is really up at this point. */ + + netlib_ifup("eth0"); + #endif /* CONFIG_NET_ICMPv6_AUTOCONF */ #else /* CONFIG_EXAMPLES_NETTEST_IPv6 */ From caeb6b32fdd40cf0219de619db80716d04b04b1e Mon Sep 17 00:00:00 2001 From: Sebastien Lorquet Date: Fri, 19 May 2017 17:30:26 +0200 Subject: [PATCH 2/4] First batch of changes --- examples/bridge/bridge_main.c | 5 +++++ examples/ftpd/ftpd_main.c | 6 ++++++ examples/igmp/igmp.c | 5 +++++ examples/poll/net_listener.c | 5 +++++ examples/poll/net_reader.c | 5 +++++ examples/telnetd/telnetd.c | 5 +++++ examples/thttpd/thttpd_main.c | 5 +++++ examples/udpblaster/udpblaster_target.c | 6 ++++++ examples/webserver/webserver_main.c | 5 +++++ examples/wget/wget_main.c | 5 +++++ examples/xmlrpc/xmlrpc_main.c | 5 +++++ 11 files changed, 57 insertions(+) diff --git a/examples/bridge/bridge_main.c b/examples/bridge/bridge_main.c index ec3d17dc8..a07501c83 100644 --- a/examples/bridge/bridge_main.c +++ b/examples/bridge/bridge_main.c @@ -129,6 +129,11 @@ printf("NET1: Configuring %s\n", CONFIG_EXAMPLES_BRIDGE_NET1_IFNAME); addr.s_addr = HTONL(CONFIG_EXAMPLES_BRIDGE_NET1_NETMASK); netlib_set_ipv4netmask(CONFIG_EXAMPLES_BRIDGE_NET1_IFNAME, &addr); + /* New versions of netlib_set_ipvXaddr will not bring the network up, + * So ensure the network is really up at this point. */ + + netlib_ifup("eth0"); + #ifdef CONFIG_EXAMPLES_BRIDGE_NET1_DHCPC /* Get the MAC address of the NIC */ diff --git a/examples/ftpd/ftpd_main.c b/examples/ftpd/ftpd_main.c index 92498577b..7967b7b68 100644 --- a/examples/ftpd/ftpd_main.c +++ b/examples/ftpd/ftpd_main.c @@ -114,6 +114,12 @@ static void fptd_netinit(void) addr.s_addr = HTONL(CONFIG_EXAMPLES_FTPD_NETMASK); netlib_set_ipv4netmask("eth0", &addr); + + /* New versions of netlib_set_ipvXaddr will not bring the network up, + * So ensure the network is really up at this point. */ + + netlib_ifup("eth0"); + #endif /* CONFIG_EXAMPLES_FTPD_NONETINIT */ } diff --git a/examples/igmp/igmp.c b/examples/igmp/igmp.c index deb7b7c10..9bab4a275 100644 --- a/examples/igmp/igmp.c +++ b/examples/igmp/igmp.c @@ -123,6 +123,11 @@ int igmp_main(int argc, char *argv[]) addr.s_addr = HTONL(CONFIG_EXAMPLES_IGMP_NETMASK); netlib_set_ipv4netmask("eth0", &addr); + /* New versions of netlib_set_ipvXaddr will not bring the network up, + * So ensure the network is really up at this point. */ + + netlib_ifup("eth0"); + /* Not much of a test for now */ /* Join the group */ diff --git a/examples/poll/net_listener.c b/examples/poll/net_listener.c index f9dde4936..3c1f0dc0f 100644 --- a/examples/poll/net_listener.c +++ b/examples/poll/net_listener.c @@ -325,6 +325,11 @@ static void net_configure(void) addr.s_addr = HTONL(CONFIG_EXAMPLES_POLL_NETMASK); netlib_set_ipv4netmask("eth0", &addr); + + /* New versions of netlib_set_ipvXaddr will not bring the network up, + * So ensure the network is really up at this point. */ + + netlib_ifup("eth0"); } /**************************************************************************** diff --git a/examples/poll/net_reader.c b/examples/poll/net_reader.c index b21c340b8..0fd6c8e5b 100644 --- a/examples/poll/net_reader.c +++ b/examples/poll/net_reader.c @@ -118,6 +118,11 @@ static void net_configure(void) addr.s_addr = HTONL(CONFIG_EXAMPLES_POLL_NETMASK); netlib_set_ipv4netmask("eth0", &addr); + + /* New versions of netlib_set_ipvXaddr will not bring the network up, + * So ensure the network is really up at this point. */ + + netlib_ifup("eth0"); } /**************************************************************************** diff --git a/examples/telnetd/telnetd.c b/examples/telnetd/telnetd.c index efdd6a3aa..3808630d9 100644 --- a/examples/telnetd/telnetd.c +++ b/examples/telnetd/telnetd.c @@ -218,6 +218,11 @@ static void telnetd_netinit(void) addr.s_addr = HTONL(CONFIG_EXAMPLES_TELNETD_NETMASK); netlib_set_ipv4netmask("eth0", &addr); + + /* New versions of netlib_set_ipvXaddr will not bring the network up, + * So ensure the network is really up at this point. */ + + netlib_ifup("eth0"); } /**************************************************************************** diff --git a/examples/thttpd/thttpd_main.c b/examples/thttpd/thttpd_main.c index b252f7401..6246b82cd 100644 --- a/examples/thttpd/thttpd_main.c +++ b/examples/thttpd/thttpd_main.c @@ -254,6 +254,11 @@ int thttp_main(int argc, char *argv[]) addr.s_addr = HTONL(CONFIG_EXAMPLES_THTTPD_NETMASK); netlib_set_ipv4netmask(NET_DEVNAME, &addr); + /* New versions of netlib_set_ipvXaddr will not bring the network up, + * So ensure the network is really up at this point. */ + + netlib_ifup("eth0"); + #ifdef CONFIG_THTTPD_NXFLAT /* Initialize the NXFLAT binary loader */ diff --git a/examples/udpblaster/udpblaster_target.c b/examples/udpblaster/udpblaster_target.c index 7f0e286ba..5844d4a3f 100644 --- a/examples/udpblaster/udpblaster_target.c +++ b/examples/udpblaster/udpblaster_target.c @@ -173,6 +173,12 @@ static void netest_initialize(void) netlib_set_ipv4netmask("eth0", &addr); #endif /* CONFIG_EXAMPLES_UDPBLASTER_IPv6 */ + + /* New versions of netlib_set_ipvXaddr will not bring the network up, + * So ensure the network is really up at this point. */ + + netlib_ifup("eth0"); + } #endif /*CONFIG_EXAMPLES_UDPBLASTER_INIT */ diff --git a/examples/webserver/webserver_main.c b/examples/webserver/webserver_main.c index 38a6ea5a2..fd5c3410d 100644 --- a/examples/webserver/webserver_main.c +++ b/examples/webserver/webserver_main.c @@ -140,6 +140,11 @@ int webserver_main(int argc, char *argv[]) addr.s_addr = HTONL(CONFIG_EXAMPLES_WEBSERVER_NETMASK); netlib_set_ipv4netmask("eth0", &addr); + /* New versions of netlib_set_ipvXaddr will not bring the network up, + * So ensure the network is really up at this point. */ + + netlib_ifup("eth0"); + #ifdef CONFIG_EXAMPLES_WEBSERVER_DHCPC /* Get the MAC address of the NIC */ diff --git a/examples/wget/wget_main.c b/examples/wget/wget_main.c index 441d4e1bc..59cdf27b3 100644 --- a/examples/wget/wget_main.c +++ b/examples/wget/wget_main.c @@ -144,6 +144,11 @@ int wget_main(int argc, char *argv[]) addr.s_addr = HTONL(CONFIG_EXAMPLES_WGET_NETMASK); netlib_set_ipv4netmask("eth0", &addr); + /* New versions of netlib_set_ipvXaddr will not bring the network up, + * So ensure the network is really up at this point. */ + + netlib_ifup("eth0"); + /* Then start the server */ wget(CONFIG_EXAMPLES_WGET_URL, g_iobuffer, 512, callback, NULL); diff --git a/examples/xmlrpc/xmlrpc_main.c b/examples/xmlrpc/xmlrpc_main.c index 0e4ca851e..89003e738 100644 --- a/examples/xmlrpc/xmlrpc_main.c +++ b/examples/xmlrpc/xmlrpc_main.c @@ -308,6 +308,11 @@ static int xmlrpc_netinit(void) addr.s_addr = HTONL(CONFIG_EXAMPLES_XMLRPC_NETMASK); netlib_set_ipv4netmask("eth0", &addr); + /* New versions of netlib_set_ipvXaddr will not bring the network up, + * So ensure the network is really up at this point. */ + + netlib_ifup("eth0"); + #ifdef CONFIG_EXAMPLES_XMLRPC_DHCPC /* Get the MAC address of the NIC */ From aefddc3648c087f0e40cfa44200b13d937ca0abb Mon Sep 17 00:00:00 2001 From: Sebastien Lorquet Date: Fri, 19 May 2017 17:37:17 +0200 Subject: [PATCH 3/4] Second batch of changes (no problems) --- examples/dhcpd/target.c | 5 +++++ examples/discover/discover_main.c | 5 +++++ examples/sendmail/sendmail_main.c | 5 +++++ examples/tcpecho/tcpecho_main.c | 5 +++++ examples/udp/target.c | 5 +++++ nshlib/nsh_netinit.c | 5 +++++ 6 files changed, 30 insertions(+) diff --git a/examples/dhcpd/target.c b/examples/dhcpd/target.c index 601371e26..95997c6b8 100644 --- a/examples/dhcpd/target.c +++ b/examples/dhcpd/target.c @@ -127,6 +127,11 @@ int dhcpd_main(int argc, char *argv[]) addr.s_addr = HTONL(CONFIG_EXAMPLES_DHCPD_NETMASK); netlib_set_ipv4netmask("eth0", &addr); + /* New versions of netlib_set_ipvXaddr will not bring the network up, + * So ensure the network is really up at this point. */ + + netlib_ifup("eth0"); + /* Then start the server */ dhcpd_run(); diff --git a/examples/discover/discover_main.c b/examples/discover/discover_main.c index 4be25419e..cf0b72c90 100644 --- a/examples/discover/discover_main.c +++ b/examples/discover/discover_main.c @@ -134,6 +134,11 @@ int discover_main(int argc, char *argv[]) addr.s_addr = HTONL(CONFIG_EXAMPLES_DISCOVER_NETMASK); netlib_set_ipv4netmask("eth0", &addr); + /* New versions of netlib_set_ipvXaddr will not bring the network up, + * So ensure the network is really up at this point. */ + + netlib_ifup("eth0"); + #ifdef CONFIG_EXAMPLES_DISCOVER_DHCPC /* Get the MAC address of the NIC */ diff --git a/examples/sendmail/sendmail_main.c b/examples/sendmail/sendmail_main.c index 37ddbf387..018bc827b 100644 --- a/examples/sendmail/sendmail_main.c +++ b/examples/sendmail/sendmail_main.c @@ -150,6 +150,11 @@ int sendmail_main(int argc, char *argv[]) addr.s_addr = HTONL(CONFIG_EXAMPLES_SENDMAIL_NETMASK); netlib_set_ipv4netmask("eth0", &addr); + /* New versions of netlib_set_ipvXaddr will not bring the network up, + * So ensure the network is really up at this point. */ + + netlib_ifup("eth0"); + /* Then send the mail */ net_ipaddr(addr.s_addr, 127, 0, 0, 1); diff --git a/examples/tcpecho/tcpecho_main.c b/examples/tcpecho/tcpecho_main.c index 1172f87e1..87644abe5 100644 --- a/examples/tcpecho/tcpecho_main.c +++ b/examples/tcpecho/tcpecho_main.c @@ -143,6 +143,11 @@ static int tcpecho_netsetup() addr.s_addr = HTONL(CONFIG_EXAMPLES_TCPECHO_NETMASK); netlib_set_ipv4netmask("eth0", &addr); + /* New versions of netlib_set_ipvXaddr will not bring the network up, + * So ensure the network is really up at this point. */ + + netlib_ifup("eth0"); + #ifdef CONFIG_EXAMPLES_TCPECHO_DHCPC /* Get the MAC address of the NIC */ diff --git a/examples/udp/target.c b/examples/udp/target.c index 911f94f46..749d74e02 100644 --- a/examples/udp/target.c +++ b/examples/udp/target.c @@ -160,6 +160,11 @@ int udp_main(int argc, char *argv[]) #endif /* CONFIG_EXAMPLES_UDP_IPv6 */ + /* New versions of netlib_set_ipvXaddr will not bring the network up, + * So ensure the network is really up at this point. */ + + netlib_ifup("eth0"); + #ifdef CONFIG_EXAMPLES_UDP_SERVER recv_server(); #else diff --git a/nshlib/nsh_netinit.c b/nshlib/nsh_netinit.c index 3f537cf89..8b344f850 100644 --- a/nshlib/nsh_netinit.c +++ b/nshlib/nsh_netinit.c @@ -358,6 +358,11 @@ static void nsh_netinit_configure(void) netlib_set_ipv4dnsaddr(&addr); #endif + /* New versions of netlib_set_ipvXaddr will not bring the network up, + * So ensure the network is really up at this point. */ + + netlib_ifup("eth0"); + #ifdef CONFIG_WIRELESS_WAPI /* Associate the wlan with an access point. */ From 297844b1ce0249451c9d025ebf9d38ed3955b2a6 Mon Sep 17 00:00:00 2001 From: Sebastien Lorquet Date: Fri, 19 May 2017 17:50:26 +0200 Subject: [PATCH 4/4] Fix comments formatting --- examples/bridge/bridge_main.c | 3 ++- examples/dhcpd/target.c | 3 ++- examples/discover/discover_main.c | 3 ++- examples/ftpd/ftpd_main.c | 3 ++- examples/igmp/igmp.c | 3 ++- examples/nettest/nettest.c | 5 +++-- examples/poll/net_listener.c | 3 ++- examples/poll/net_reader.c | 3 ++- examples/sendmail/sendmail_main.c | 3 ++- examples/tcpecho/tcpecho_main.c | 3 ++- examples/telnetd/telnetd.c | 3 ++- examples/thttpd/thttpd_main.c | 3 ++- examples/udp/target.c | 3 ++- examples/udpblaster/udpblaster_target.c | 3 ++- examples/webserver/webserver_main.c | 3 ++- examples/wget/wget_main.c | 3 ++- examples/xmlrpc/xmlrpc_main.c | 3 ++- nshlib/nsh_netinit.c | 3 ++- 18 files changed, 37 insertions(+), 19 deletions(-) diff --git a/examples/bridge/bridge_main.c b/examples/bridge/bridge_main.c index a07501c83..c06e70eed 100644 --- a/examples/bridge/bridge_main.c +++ b/examples/bridge/bridge_main.c @@ -130,7 +130,8 @@ printf("NET1: Configuring %s\n", CONFIG_EXAMPLES_BRIDGE_NET1_IFNAME); netlib_set_ipv4netmask(CONFIG_EXAMPLES_BRIDGE_NET1_IFNAME, &addr); /* New versions of netlib_set_ipvXaddr will not bring the network up, - * So ensure the network is really up at this point. */ + * So ensure the network is really up at this point. + */ netlib_ifup("eth0"); diff --git a/examples/dhcpd/target.c b/examples/dhcpd/target.c index 95997c6b8..f834043c2 100644 --- a/examples/dhcpd/target.c +++ b/examples/dhcpd/target.c @@ -128,7 +128,8 @@ int dhcpd_main(int argc, char *argv[]) netlib_set_ipv4netmask("eth0", &addr); /* New versions of netlib_set_ipvXaddr will not bring the network up, - * So ensure the network is really up at this point. */ + * So ensure the network is really up at this point. + */ netlib_ifup("eth0"); diff --git a/examples/discover/discover_main.c b/examples/discover/discover_main.c index cf0b72c90..8f91cc304 100644 --- a/examples/discover/discover_main.c +++ b/examples/discover/discover_main.c @@ -135,7 +135,8 @@ int discover_main(int argc, char *argv[]) netlib_set_ipv4netmask("eth0", &addr); /* New versions of netlib_set_ipvXaddr will not bring the network up, - * So ensure the network is really up at this point. */ + * So ensure the network is really up at this point. + */ netlib_ifup("eth0"); diff --git a/examples/ftpd/ftpd_main.c b/examples/ftpd/ftpd_main.c index 7967b7b68..a60e36c88 100644 --- a/examples/ftpd/ftpd_main.c +++ b/examples/ftpd/ftpd_main.c @@ -116,7 +116,8 @@ static void fptd_netinit(void) netlib_set_ipv4netmask("eth0", &addr); /* New versions of netlib_set_ipvXaddr will not bring the network up, - * So ensure the network is really up at this point. */ + * So ensure the network is really up at this point. + */ netlib_ifup("eth0"); diff --git a/examples/igmp/igmp.c b/examples/igmp/igmp.c index 9bab4a275..9829b291f 100644 --- a/examples/igmp/igmp.c +++ b/examples/igmp/igmp.c @@ -124,7 +124,8 @@ int igmp_main(int argc, char *argv[]) netlib_set_ipv4netmask("eth0", &addr); /* New versions of netlib_set_ipvXaddr will not bring the network up, - * So ensure the network is really up at this point. */ + * So ensure the network is really up at this point. + */ netlib_ifup("eth0"); diff --git a/examples/nettest/nettest.c b/examples/nettest/nettest.c index 5f6c97b4e..ca5437b80 100644 --- a/examples/nettest/nettest.c +++ b/examples/nettest/nettest.c @@ -159,8 +159,9 @@ static void netest_initialize(void) netlib_set_ipv6netmask("eth0", (FAR const struct in6_addr *)g_ipv6_netmask); - /* New versions of netlib_set_ipv6addr will not bring the network up, - * So ensure the network is really up at this point. */ + /* New versions of netlib_set_ipvXaddr will not bring the network up, + * So ensure the network is really up at this point. + */ netlib_ifup("eth0"); diff --git a/examples/poll/net_listener.c b/examples/poll/net_listener.c index 3c1f0dc0f..dd29dc452 100644 --- a/examples/poll/net_listener.c +++ b/examples/poll/net_listener.c @@ -327,7 +327,8 @@ static void net_configure(void) netlib_set_ipv4netmask("eth0", &addr); /* New versions of netlib_set_ipvXaddr will not bring the network up, - * So ensure the network is really up at this point. */ + * So ensure the network is really up at this point. + */ netlib_ifup("eth0"); } diff --git a/examples/poll/net_reader.c b/examples/poll/net_reader.c index 0fd6c8e5b..cbb70e6e4 100644 --- a/examples/poll/net_reader.c +++ b/examples/poll/net_reader.c @@ -120,7 +120,8 @@ static void net_configure(void) netlib_set_ipv4netmask("eth0", &addr); /* New versions of netlib_set_ipvXaddr will not bring the network up, - * So ensure the network is really up at this point. */ + * So ensure the network is really up at this point. + */ netlib_ifup("eth0"); } diff --git a/examples/sendmail/sendmail_main.c b/examples/sendmail/sendmail_main.c index 018bc827b..7e57231a9 100644 --- a/examples/sendmail/sendmail_main.c +++ b/examples/sendmail/sendmail_main.c @@ -151,7 +151,8 @@ int sendmail_main(int argc, char *argv[]) netlib_set_ipv4netmask("eth0", &addr); /* New versions of netlib_set_ipvXaddr will not bring the network up, - * So ensure the network is really up at this point. */ + * So ensure the network is really up at this point. + */ netlib_ifup("eth0"); diff --git a/examples/tcpecho/tcpecho_main.c b/examples/tcpecho/tcpecho_main.c index 87644abe5..9daf2ac65 100644 --- a/examples/tcpecho/tcpecho_main.c +++ b/examples/tcpecho/tcpecho_main.c @@ -144,7 +144,8 @@ static int tcpecho_netsetup() netlib_set_ipv4netmask("eth0", &addr); /* New versions of netlib_set_ipvXaddr will not bring the network up, - * So ensure the network is really up at this point. */ + * So ensure the network is really up at this point. + */ netlib_ifup("eth0"); diff --git a/examples/telnetd/telnetd.c b/examples/telnetd/telnetd.c index 3808630d9..5bb5a4c56 100644 --- a/examples/telnetd/telnetd.c +++ b/examples/telnetd/telnetd.c @@ -220,7 +220,8 @@ static void telnetd_netinit(void) netlib_set_ipv4netmask("eth0", &addr); /* New versions of netlib_set_ipvXaddr will not bring the network up, - * So ensure the network is really up at this point. */ + * So ensure the network is really up at this point. + */ netlib_ifup("eth0"); } diff --git a/examples/thttpd/thttpd_main.c b/examples/thttpd/thttpd_main.c index 6246b82cd..3a180e379 100644 --- a/examples/thttpd/thttpd_main.c +++ b/examples/thttpd/thttpd_main.c @@ -255,7 +255,8 @@ int thttp_main(int argc, char *argv[]) netlib_set_ipv4netmask(NET_DEVNAME, &addr); /* New versions of netlib_set_ipvXaddr will not bring the network up, - * So ensure the network is really up at this point. */ + * So ensure the network is really up at this point. + */ netlib_ifup("eth0"); diff --git a/examples/udp/target.c b/examples/udp/target.c index 749d74e02..0074cb999 100644 --- a/examples/udp/target.c +++ b/examples/udp/target.c @@ -161,7 +161,8 @@ int udp_main(int argc, char *argv[]) #endif /* CONFIG_EXAMPLES_UDP_IPv6 */ /* New versions of netlib_set_ipvXaddr will not bring the network up, - * So ensure the network is really up at this point. */ + * So ensure the network is really up at this point. + */ netlib_ifup("eth0"); diff --git a/examples/udpblaster/udpblaster_target.c b/examples/udpblaster/udpblaster_target.c index 5844d4a3f..21a3078c2 100644 --- a/examples/udpblaster/udpblaster_target.c +++ b/examples/udpblaster/udpblaster_target.c @@ -175,7 +175,8 @@ static void netest_initialize(void) #endif /* CONFIG_EXAMPLES_UDPBLASTER_IPv6 */ /* New versions of netlib_set_ipvXaddr will not bring the network up, - * So ensure the network is really up at this point. */ + * So ensure the network is really up at this point. + */ netlib_ifup("eth0"); diff --git a/examples/webserver/webserver_main.c b/examples/webserver/webserver_main.c index fd5c3410d..2278b83c5 100644 --- a/examples/webserver/webserver_main.c +++ b/examples/webserver/webserver_main.c @@ -141,7 +141,8 @@ int webserver_main(int argc, char *argv[]) netlib_set_ipv4netmask("eth0", &addr); /* New versions of netlib_set_ipvXaddr will not bring the network up, - * So ensure the network is really up at this point. */ + * So ensure the network is really up at this point. + */ netlib_ifup("eth0"); diff --git a/examples/wget/wget_main.c b/examples/wget/wget_main.c index 59cdf27b3..96c21a0d5 100644 --- a/examples/wget/wget_main.c +++ b/examples/wget/wget_main.c @@ -145,7 +145,8 @@ int wget_main(int argc, char *argv[]) netlib_set_ipv4netmask("eth0", &addr); /* New versions of netlib_set_ipvXaddr will not bring the network up, - * So ensure the network is really up at this point. */ + * So ensure the network is really up at this point. + */ netlib_ifup("eth0"); diff --git a/examples/xmlrpc/xmlrpc_main.c b/examples/xmlrpc/xmlrpc_main.c index 89003e738..db431163c 100644 --- a/examples/xmlrpc/xmlrpc_main.c +++ b/examples/xmlrpc/xmlrpc_main.c @@ -309,7 +309,8 @@ static int xmlrpc_netinit(void) netlib_set_ipv4netmask("eth0", &addr); /* New versions of netlib_set_ipvXaddr will not bring the network up, - * So ensure the network is really up at this point. */ + * So ensure the network is really up at this point. + */ netlib_ifup("eth0"); diff --git a/nshlib/nsh_netinit.c b/nshlib/nsh_netinit.c index 8b344f850..8e98881b0 100644 --- a/nshlib/nsh_netinit.c +++ b/nshlib/nsh_netinit.c @@ -359,7 +359,8 @@ static void nsh_netinit_configure(void) #endif /* New versions of netlib_set_ipvXaddr will not bring the network up, - * So ensure the network is really up at this point. */ + * So ensure the network is really up at this point. + */ netlib_ifup("eth0");