sergiotarxz/nuttx-apps
sergiotarxz/nuttx-apps
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

apps/netutils/netinit/netinit.c: Improve cleanup, removing 1 of 2 warnings. Unhook PHY notification signal handler when cleaning up, if an error occurs after the signal handler is put into place.

Browse Source
This commit is contained in:
Nathan Hartman 2019-07-26 10:58:14 -06:00 committed by Gregory Nutt
parent 28f57f1007
commit 4fd1058200
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
netutils/netinit/netinit.c
View File

@ -555,6 +555,7 @@ static int netinit_monitor(void)
struct timespec reltime; struct timespec reltime;
struct ifreq ifr; struct ifreq ifr;
struct sigaction act; struct sigaction act;
struct sigaction oact;
bool devup; bool devup;
int ret; int ret;
int sd; int sd;
@ -584,7 +585,7 @@ static int netinit_monitor(void)
act.sa_sigaction = netinit_signal; act.sa_sigaction = netinit_signal;
act.sa_flags = SA_SIGINFO; act.sa_flags = SA_SIGINFO;
ret = sigaction(CONFIG_NETINIT_SIGNO, &act, NULL); ret = sigaction(CONFIG_NETINIT_SIGNO, &act, &oact);
if (ret < 0) if (ret < 0)
{ {
ret = -errno; ret = -errno;
@ -758,7 +759,7 @@ static int netinit_monitor(void)
errout_with_notification: errout_with_notification:
# warning Missing logic # warning Missing logic
errout_with_sigaction: errout_with_sigaction:
# warning Missing logic (void)sigaction(CONFIG_NETINIT_SIGNO, &oact, NULL);
errout_with_socket: errout_with_socket:
close(sd); close(sd);
errout: errout: