sergiotarxz/nuttx-apps
sergiotarxz/nuttx-apps
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix a memory leak in last NSH change: Forgot to close a temporary file

Browse Source
This commit is contained in:
Gregory Nutt 2014-01-12 14:16:05 -06:00
parent b034b169fb
commit 5cc656d71d
2 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ChangeLog.txt
View File

@ -774,4 +774,6 @@
* apps/nshlib/nsh_parse.c: Can now handle arguments that are * apps/nshlib/nsh_parse.c: Can now handle arguments that are
concatenations of constant strings, command return data, application concatenations of constant strings, command return data, application
return data, and environment variables (2014-1-11). return data, and environment variables (2014-1-11).
* apps/nshlib/nsh_parse.c: Fix a memory leak ... forgot to close
a temporary file (2013-1-12).

16
nshlib/nsh_parse.c
View File

@ -166,7 +166,7 @@ static int nsh_nice(FAR struct nsh_vtbl_s *vtbl, FAR char **ppcmd,
#endif #endif
#ifdef CONFIG_NSH_CMDPARMS #ifdef CONFIG_NSH_CMDPARMS
static int nsh_parse_funcparm(FAR struct nsh_vtbl_s *vtbl, FAR char *cmdline, static int nsh_parse_cmdparm(FAR struct nsh_vtbl_s *vtbl, FAR char *cmdline,
FAR const char *redirfile); FAR const char *redirfile);
#endif #endif
static int nsh_parse_command(FAR struct nsh_vtbl_s *vtbl, FAR char *cmdline); static int nsh_parse_command(FAR struct nsh_vtbl_s *vtbl, FAR char *cmdline);
@ -184,7 +184,9 @@ static const char g_arg_separator[] = "`$";
#endif #endif
static const char g_redirect1[] = ">"; static const char g_redirect1[] = ">";
static const char g_redirect2[] = ">>"; static const char g_redirect2[] = ">>";
#ifndef CONFIG_DISABLE_ENVIRON
static const char g_exitstatus[] = "?"; static const char g_exitstatus[] = "?";
#endif
static const char g_success[] = "0"; static const char g_success[] = "0";
static const char g_failure[] = "1"; static const char g_failure[] = "1";
static const char g_nullstring[] = ""; static const char g_nullstring[] = "";
@ -775,6 +777,10 @@ static FAR char *nsh_filecat(FAR struct nsh_vtbl_s *vtbl, FAR char *s1,
/* Make sure that the new string is null terminated */ /* Make sure that the new string is null terminated */
argument[index] = '\0'; argument[index] = '\0';
/* Close the temporary file and return the concatenated value */
close (fd);
return argument; return argument;
errout_with_fd: errout_with_fd:
@ -820,7 +826,7 @@ static FAR char *nsh_cmdparm(FAR struct nsh_vtbl_s *vtbl, FAR char *cmdline,
* options. * options.
*/ */
ret = nsh_parse_funcparm(vtbl, cmdline, tmpfile); ret = nsh_parse_cmdparm(vtbl, cmdline, tmpfile);
if (ret != OK) if (ret != OK)
{ {
/* Report the failure */ /* Report the failure */
@ -1539,7 +1545,7 @@ static int nsh_nice(FAR struct nsh_vtbl_s *vtbl, FAR char **ppcmd,
#endif #endif
/**************************************************************************** /****************************************************************************
* Name: nsh_parse_funcparm * Name: nsh_parse_cmdparm
* *
* Description: * Description:
* This function parses and executes a simple NSH command. Output is * This function parses and executes a simple NSH command. Output is
@ -1553,8 +1559,8 @@ static int nsh_nice(FAR struct nsh_vtbl_s *vtbl, FAR char **ppcmd,
****************************************************************************/ ****************************************************************************/
#ifdef CONFIG_NSH_CMDPARMS #ifdef CONFIG_NSH_CMDPARMS
static int nsh_parse_funcparm(FAR struct nsh_vtbl_s *vtbl, FAR char *cmdline, static int nsh_parse_cmdparm(FAR struct nsh_vtbl_s *vtbl, FAR char *cmdline,
FAR const char *redirfile) FAR const char *redirfile)
{ {
NSH_MEMLIST_TYPE memlist; NSH_MEMLIST_TYPE memlist;
FAR char *argv[MAX_ARGV_ENTRIES]; FAR char *argv[MAX_ARGV_ENTRIES];