Add some REVISIT comments

This commit is contained in:
Gregory Nutt 2016-02-20 14:57:37 -06:00
parent ec11a454f9
commit 65a1d53079
2 changed files with 10 additions and 2 deletions

View File

@ -33,7 +33,7 @@ config EXAMPLES_LEDS_DEVPATH
default "/dev/userleds"
config EXAMPLES_LEDS_LEDSET
hex "Set of LEDs to use"
hex "Subset of LEDs to use"
default 0x0f
endif
endif # EXAMPLES_LEDS

View File

@ -127,6 +127,10 @@ static int led_daemon(int argc, char *argv[])
}
while (newset == ledset);
/* REVISIT: There are flaws in this logic. It would not work
* correctly if there were spaces in the supported mask.
*/
if (newset == 0)
{
incrementing = false;
@ -135,6 +139,10 @@ static int led_daemon(int argc, char *argv[])
}
else
{
/* REVISIT: There are flaws in this logic. It would not work
* correctly if there were spaces in the supported mask.
*/
if (ledset == 0)
{
incrementing = true;