sergiotarxz/nuttx-apps
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

system/fastboot: Fix fd leak of fastboot_filedump_upload()

Browse Source 
Signed-off-by: wangjianyu3 <wangjianyu3@xiaomi.com>
This commit is contained in:
wangjianyu3 2024-07-23 10:04:27 +08:00 committed by Xiang Xiao
parent c3488c5b47
commit 78c11c31e8
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
system/fastboot/fastboot.c
View File

@ -673,6 +673,7 @@ static int fastboot_filedump_upload(FAR struct fastboot_ctx_s *context)
{ {
fb_err("Invalid argument, offset: %" PRIdOFF "\n", fb_err("Invalid argument, offset: %" PRIdOFF "\n",
context->upload_param.u.file.offset); context->upload_param.u.file.offset);
close(fd);
return -errno; return -errno;
} }
@ -690,12 +691,14 @@ static int fastboot_filedump_upload(FAR struct fastboot_ctx_s *context)
nread) < 0) nread) < 0)
{ {
fb_err("Upload failed (%zu bytes left)\n", size); fb_err("Upload failed (%zu bytes left)\n", size);
close(fd);
return -errno; return -errno;
} }
size -= nread; size -= nread;
} }
close(fd);
return 0; return 0;
} }