sergiotarxz/nuttx-apps
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

ppp: Fix wrong lcp_state handling on peer reconnection

Browse Source 
If a PPP peer disconnects and then tries to reconnect it will send an 'LCP configure request' packet. The code that handles that scenario seems to be clearing the wrong lcp_state flag (LCP_RX_UP instead of LCP_TX_UP) and thus the nuttx ppp client will keep sending IPCP packets which are rightfully dropped by the new peer since it is still in the LCP negotiation phase.
This commit is contained in:
Leandro Zungri 2024-09-13 09:48:15 -07:00 committed by Xiang Xiao
parent f96461c385
commit 800b93de9f
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
netutils/pppd/lcp.c
View File

@ -135,7 +135,11 @@ void lcp_rx(struct ppp_context_s *ctx, uint8_t * buffer, uint16_t count)
/* In case of new peer connection */
ipcp_init(ctx);
ctx->lcp_state &= ~LCP_RX_UP;
/* Clear LCP state to keep it in negotiation phase. LCP_TX_UP will be re-set
* once a CONF_ACK is received. */
ctx->lcp_state &= ~LCP_TX_UP;
DEBUG1(("received [LCP Config Request id %u\n", id));
if (scan_packet