sergiotarxz/nuttx-apps
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

nshlib:enable O_CLOEXEC expliciti to avoid potential fd leak

Browse Source 
leaking here means fork/vfork will duplicate fd without O_CLOEXEC flag
to the child process.

Signed-off-by: wanggang26 <wanggang26@xiaomi.com>
This commit is contained in:
wanggang26 2023-10-30 18:10:52 +08:00 committed by Xiang Xiao
parent 3144c14947
commit 864371cc10
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
nshlib/nsh_fsutils.c
View File

@ -82,7 +82,7 @@ static int getpid_callback(FAR struct nsh_vtbl_s *vtbl,
snprintf(buffer, sizeof(buffer), "%s/%s/cmdline", dirpath, entryp->d_name);
fd = open(buffer, O_RDONLY);
fd = open(buffer, O_RDONLY | O_CLOEXEC);
if (fd < 0)
{
return 0;
@ -137,7 +137,7 @@ int nsh_catfile(FAR struct nsh_vtbl_s *vtbl, FAR const char *cmd,
/* Open the file for reading */
fd = open(filepath, O_RDONLY);
fd = open(filepath, O_RDONLY | O_CLOEXEC);
if (fd < 0)
{
#if defined(CONFIG_NSH_PROC_MOUNTPOINT)
@ -282,7 +282,7 @@ int nsh_readfile(FAR struct nsh_vtbl_s *vtbl, FAR const char *cmd,
/* Open the file */
fd = open(filepath, O_RDONLY);
fd = open(filepath, O_RDONLY | O_CLOEXEC);
if (fd < 0)
{
nsh_error(vtbl, g_fmtcmdfailed, cmd, "open", NSH_ERRNO);
@ -381,7 +381,7 @@ int nsh_writefile(FAR struct nsh_vtbl_s *vtbl, FAR const char *cmd,
/* Open the file for reading */
fd = open(filepath, O_WRONLY);
fd = open(filepath, O_WRONLY | O_CLOEXEC);
if (fd < 0)
{
#if defined(CONFIG_NSH_PROC_MOUNTPOINT)