sergiotarxz/nuttx-apps
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

apps/nshlib: nsh_getdirpath(), use snprint instead of sprintf to avoid possibility of buffer overrun. Noted by Chung Hwan Kim.

Browse Source
This commit is contained in:
Gregory Nutt 2016-10-11 17:35:31 -06:00
parent 909a4ec2ce
commit 9b951b4dd8
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
nshlib/nsh_fscmds.c
View File

@ -114,11 +114,11 @@ static char *nsh_getdirpath(FAR struct nsh_vtbl_s *vtbl,
if (strcmp(path, "/") == 0) if (strcmp(path, "/") == 0)
{ {
sprintf(vtbl->iobuffer, "/%s", file); snprintf(vtbl->iobuffer, IOBUFFERSIZE, "/%s", file);
} }
else else
{ {
sprintf(vtbl->iobuffer, "%s/%s", path, file); snprintf(vtbl->iobuffer, IOBUFFERSIZE, "%s/%s", path, file);
} }
vtbl->iobuffer[PATH_MAX] = '\0'; vtbl->iobuffer[PATH_MAX] = '\0';