sergiotarxz/nuttx-apps
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

nsh: Don't echo password during login

Browse Source 
Signed-off-by: Huang Qi <huangqi3@xiaomi.com>
This commit is contained in:
Huang Qi 2023-03-03 14:19:24 +08:00 committed by Xiang Xiao
parent 2e49d78400
commit 9bb730fb6b
1 changed files with 34 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
nshlib/nsh_login.c
View File

@ -27,6 +27,7 @@
#include <string.h>
#include <ctype.h>
#include <unistd.h>
#include <termios.h>
#include "fsutils/passwd.h"
#ifdef CONFIG_NSH_CLE
@ -150,6 +151,9 @@ int nsh_login(FAR struct console_stdio_s *pstate)
#endif
int ret;
int i;
#ifdef CONFIG_SERIAL_TERMIOS
struct termios cfg;
#endif
#ifdef CONFIG_NSH_PLATFORM_SKIP_LOGIN
if (platform_skip_login() == OK)
@ -193,9 +197,37 @@ int nsh_login(FAR struct console_stdio_s *pstate)
write(OUTFD(pstate), g_passwordprompt, strlen(g_passwordprompt));
/* Disable ECHO if its a tty device */
#ifdef CONFIG_SERIAL_TERMIOS
if (isatty(INFD(pstate)))
{
if (tcgetattr(INFD(pstate), &cfg) == 0)
{
cfg.c_iflag &= ~ECHO;
tcsetattr(INFD(pstate), TCSANOW, &cfg);
}
}
#endif
password[0] = '\0';
if (readline_fd(pstate->cn_line, CONFIG_NSH_LINELEN,
INFD(pstate), -1) > 0)
ret = readline_fd(pstate->cn_line, CONFIG_NSH_LINELEN,
INFD(pstate), -1);
/* Enable echo again after password */
#ifdef CONFIG_SERIAL_TERMIOS
if (isatty(INFD(pstate)))
{
if (tcgetattr(INFD(pstate), &cfg) == 0)
{
cfg.c_iflag |= ECHO;
tcsetattr(INFD(pstate), TCSANOW, &cfg);
}
}
#endif
if (ret > 0)
{
/* Parse out the password */