From a1cbc92b4f52a2d5792340313dc210795f21d67e Mon Sep 17 00:00:00 2001 From: Gregory Nutt Date: Wed, 27 Jan 2016 10:38:14 -0600 Subject: [PATCH] Be courageous: system/ramtron completely removed. It is an inappropriate application --- ChangeLog.txt | 2 +- system/Kconfig | 1 - system/Make.defs | 4 - system/Makefile | 2 +- system/ramtron/.gitignore | 11 --- system/ramtron/Kconfig | 18 ----- system/ramtron/Makefile | 149 -------------------------------------- system/ramtron/ramtron.c | 108 --------------------------- 8 files changed, 2 insertions(+), 293 deletions(-) delete mode 100644 system/ramtron/.gitignore delete mode 100644 system/ramtron/Kconfig delete mode 100644 system/ramtron/Makefile delete mode 100644 system/ramtron/ramtron.c diff --git a/ChangeLog.txt b/ChangeLog.txt index 21f8818bb..1d3761257 100644 --- a/ChangeLog.txt +++ b/ChangeLog.txt @@ -1523,7 +1523,7 @@ * apps/nshlib: Extend logins. Added: Optional platform-specific function to perform password verification and optionsl delay after each failed login attempt (2016-01-22). - * system/ramtron: Marked EXPERIMENTAL. It inappropriately uses + * system/ramtron: Removed completely. It inappropriately used an internal OS interface (up_spiinitialize), that has been obsoleted. That's what happens when you violate interface boundaries between the application and the OS (2016-01-27). diff --git a/system/Kconfig b/system/Kconfig index b31cfbc9f..c37496af4 100644 --- a/system/Kconfig +++ b/system/Kconfig @@ -19,7 +19,6 @@ source "$APPSDIR/system/ramtest/Kconfig" source "$APPSDIR/system/readline/Kconfig" source "$APPSDIR/system/prun/Kconfig" source "$APPSDIR/system/mdio/Kconfig" -source "$APPSDIR/system/ramtron/Kconfig" source "$APPSDIR/system/sdcard/Kconfig" source "$APPSDIR/system/sudoku/Kconfig" source "$APPSDIR/system/lm75/Kconfig" diff --git a/system/Make.defs b/system/Make.defs index 4f7e0326c..679a53995 100644 --- a/system/Make.defs +++ b/system/Make.defs @@ -94,10 +94,6 @@ ifeq ($(CONFIG_SYSTEM_READLINE),y) CONFIGURED_APPS += system/readline endif -ifeq ($(CONFIG_SYSTEM_RAMTRON),y) -CONFIGURED_APPS += system/ramtron -endif - ifeq ($(CONFIG_SYSTEM_SDCARD),y) CONFIGURED_APPS += system/sdcard endif diff --git a/system/Makefile b/system/Makefile index 02b9d9166..50cf24808 100644 --- a/system/Makefile +++ b/system/Makefile @@ -38,7 +38,7 @@ # Sub-directories containing system tasks/libraries SUBDIRS = cdcacm cle composite cu flash_eraseall free i2c hex2bin install -SUBDIRS += hexed lm75 mdio netdb nxplayer ramtest ramtron readline sdcard +SUBDIRS += hexed lm75 mdio netdb nxplayer ramtest readline sdcard SUBDIRS += stackmonitor sudoku symtab usbmonitor usbmsc vi zmodem zoneinfo # Create the list of installed runtime modules (INSTALLED_DIRS) diff --git a/system/ramtron/.gitignore b/system/ramtron/.gitignore deleted file mode 100644 index 83bd7b811..000000000 --- a/system/ramtron/.gitignore +++ /dev/null @@ -1,11 +0,0 @@ -/Make.dep -/.depend -/.built -/*.asm -/*.rel -/*.lst -/*.sym -/*.adb -/*.lib -/*.src -/*.obj diff --git a/system/ramtron/Kconfig b/system/ramtron/Kconfig deleted file mode 100644 index e2ce339f0..000000000 --- a/system/ramtron/Kconfig +++ /dev/null @@ -1,18 +0,0 @@ -# -# For a description of the syntax of this configuration file, -# see the file kconfig-language.txt in the NuttX tools repository. -# - -config SYSTEM_RAMTRON - bool "RAMTRON" - default n - depends on EXPERIMENTAL - ---help--- - Enable support for the NSH RAMTRON command. - - This configuration is broken because it depends on obsoleted - internal OS interfaces. That's what you get for violating interface definitions! - -if SYSTEM_RAMTRON -endif - diff --git a/system/ramtron/Makefile b/system/ramtron/Makefile deleted file mode 100644 index baa191e71..000000000 --- a/system/ramtron/Makefile +++ /dev/null @@ -1,149 +0,0 @@ -############################################################################ -# apps/system/ramtron/Makefile -# -# Copyright (C) 2011 Uros Platise. All rights reserved. -# Copyright (C) 2012 Gregory Nutt. All rights reserved. -# Author: Uros Platise -# Gregory Nutt -# -# Redistribution and use in source and binary forms, with or without -# modification, are permitted provided that the following conditions -# are met: -# -# 1. Redistributions of source code must retain the above copyright -# notice, this list of conditions and the following disclaimer. -# 2. Redistributions in binary form must reproduce the above copyright -# notice, this list of conditions and the following disclaimer in -# the documentation and/or other materials provided with the -# distribution. -# 3. Neither the name NuttX nor the names of its contributors may be -# used to endorse or promote products derived from this software -# without specific prior written permission. -# -# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS -# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT -# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS -# FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE -# COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, -# INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, -# BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS -# OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED -# AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT -# LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN -# ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE -# POSSIBILITY OF SUCH DAMAGE. -# -############################################################################ - -# TODO, this makefile should run make under the app dirs, instead of -# sourcing the Make.defs! - --include $(TOPDIR)/.config --include $(TOPDIR)/Make.defs -include $(APPDIR)/Make.defs - -ifeq ($(WINTOOL),y) -INCDIROPT = -w -endif - -# Hello Application -# TODO: appname can be automatically extracted from the directory name - -APPNAME = ramtron -PRIORITY = SCHED_PRIORITY_DEFAULT -STACKSIZE = 1024 - -ASRCS = -CSRCS = -MAINSRC = ramtron.c - -AOBJS = $(ASRCS:.S=$(OBJEXT)) -COBJS = $(CSRCS:.c=$(OBJEXT)) -MAINOBJ = $(MAINSRC:.c=$(OBJEXT)) - -SRCS = $(ASRCS) $(CSRCS) $(MAINSRC) -OBJS = $(AOBJS) $(COBJS) - -ifneq ($(CONFIG_BUILD_KERNEL),y) - OBJS += $(MAINOBJ) -endif - -ifeq ($(CONFIG_WINDOWS_NATIVE),y) - BIN = ..\..\libapps$(LIBEXT) -else -ifeq ($(WINTOOL),y) - BIN = ..\\..\\libapps$(LIBEXT) -else - BIN = ../../libapps$(LIBEXT) -endif -endif - -ifeq ($(WINTOOL),y) - INSTALL_DIR = "${shell cygpath -w $(BIN_DIR)}" -else - INSTALL_DIR = $(BIN_DIR) -endif - -CONFIG_XYZ_PROGNAME ?= ramtron$(EXEEXT) -PROGNAME = $(CONFIG_XYZ_PROGNAME) - -ROOTDEPPATH = --dep-path . - -# Common build - -VPATH = - -all: .built -.PHONY: context depend clean distclean - -$(AOBJS): %$(OBJEXT): %.S - $(call ASSEMBLE, $<, $@) - -$(COBJS) $(MAINOBJ): %$(OBJEXT): %.c - $(call COMPILE, $<, $@) - -.built: $(OBJS) - $(call ARCHIVE, $(BIN), $(OBJS)) - $(Q) touch .built - -ifeq ($(CONFIG_BUILD_KERNEL),y) -$(BIN_DIR)$(DELIM)$(PROGNAME): $(OBJS) $(MAINOBJ) - @echo "LD: $(PROGNAME)" - $(Q) $(LD) $(LDELFFLAGS) $(LDLIBPATH) -o $(INSTALL_DIR)$(DELIM)$(PROGNAME) $(ARCHCRT0OBJ) $(MAINOBJ) $(LDLIBS) - $(Q) $(NM) -u $(INSTALL_DIR)$(DELIM)$(PROGNAME) - -install: $(BIN_DIR)$(DELIM)$(PROGNAME) - -else -install: - -endif - -# Register application - -ifeq ($(CONFIG_NSH_BUILTIN_APPS),y) -$(BUILTIN_REGISTRY)$(DELIM)$(APPNAME)_main.bdat: $(DEPCONFIG) Makefile - $(call REGISTER,$(APPNAME),$(PRIORITY),$(STACKSIZE),$(APPNAME)_main) - -context: $(BUILTIN_REGISTRY)$(DELIM)$(APPNAME)_main.bdat -else -context: -endif - -# Create dependencies - -.depend: Makefile $(SRCS) - $(Q) $(MKDEP) $(ROOTDEPPATH) "$(CC)" -- $(CFLAGS) -- $(SRCS) >Make.dep - $(Q) touch $@ - -depend: .depend - -clean: - $(call DELFILE, .built) - $(call CLEAN) - -distclean: clean - $(call DELFILE, Make.dep) - $(call DELFILE, .depend) - --include Make.dep diff --git a/system/ramtron/ramtron.c b/system/ramtron/ramtron.c deleted file mode 100644 index a047fa87a..000000000 --- a/system/ramtron/ramtron.c +++ /dev/null @@ -1,108 +0,0 @@ -/**************************************************************************** - * apps/system/ramtron/ramtron.c - * - * Copyright (C) 2011 Uros Platise. All rights reserved. - * Copyright (C) 2009 Gregory Nutt. All rights reserved. - * - * Authors: Uros Platise - * Gregory Nutt - * - * Redistribution and use in source and binary forms, with or without - * modification, are permitted provided that the following conditions - * are met: - * - * 1. Redistributions of source code must retain the above copyright - * notice, this list of conditions and the following disclaimer. - * 2. Redistributions in binary form must reproduce the above copyright - * notice, this list of conditions and the following disclaimer in - * the documentation and/or other materials provided with the - * distribution. - * 3. Neither the name NuttX nor the names of its contributors may be - * used to endorse or promote products derived from this software - * without specific prior written permission. - * - * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS - * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT - * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS - * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE - * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, - * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, - * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS - * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED - * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT - * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN - * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE - * POSSIBILITY OF SUCH DAMAGE. - * - ****************************************************************************/ - -#include - -#include -#include -#include -#include -#include - -#include -#include - -FAR struct mtd_dev_s *ramtron_initialize(FAR struct spi_dev_s *dev); - -int ramtron_start(int spino) -{ - FAR struct spi_dev_s *spi; - FAR struct mtd_dev_s *mtd; - int retval; - - /* Get the SPI port */ - - spi = up_spiinitialize(spino); - if (!spi) - { - printf("RAMTRON: Failed to initialize SPI%d\n", spino); - return -ENODEV; - } - - printf("RAMTRON: Initialized SPI%d\n", spino); - - mtd = (struct mtd_dev_s *)ramtron_initialize(spi); - if (!mtd) - { - printf("RAMTRON: Device not found\n"); - return -ENODEV; - } - - printf("RAMTRON: FM25V10 of size 128 kB\n"); - //printf("RAMTRON: %s of size %d B\n", ramtron_getpart(mtd), ramtron_getsize(mtd) ); - - retval = ftl_initialize(0, mtd); - printf("RAMTRON: FTL Initialized (returns with %d)\n", retval); - - return OK; -} - - -#ifdef CONFIG_BUILD_KERNEL -int main(int argc, FAR char *argv[]) -#else -int ramtron_main(int argc, char *argv[]) -#endif -{ - int spino; - - if (argc == 3) - { - spino = atoi(argv[2]); - - if (!strcmp(argv[1], "start")) - { - return ramtron_start(spino); - } - } - - /* todo: write protect */ - - printf("%s: \n", argv[0]); - return -1; -}