sergiotarxz/nuttx-apps
sergiotarxz/nuttx-apps
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Bringing PPPD yet closer to the NuttX coding style

Browse Source
This commit is contained in:
Gregory Nutt 2015-03-11 18:47:04 -06:00
parent f87fd5118c
commit b7768bea79
6 changed files with 198 additions and 142 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

60
netutils/pppd/ahdlc.c
View File

@ -57,9 +57,7 @@
# undef PACKET_TX_DEBUG # undef PACKET_TX_DEBUG
#endif #endif
/*--------------------------------------------------------------------------- /* ahdlc flags bit defins, for ahdlc_flags variable */
* ahdlc flags bit defins, for ahdlc_flags variable
---------------------------------------------------------------------------*/
/* Escaped mode bit */ /* Escaped mode bit */
@ -77,8 +75,9 @@
* Private Functions * Private Functions
****************************************************************************/ ****************************************************************************/
/*---------------------------------------------------------------------------*/ /****************************************************************************
/* Simple and fast CRC16 routine for embedded processors. * Simple and fast CRC16 routine for embedded processors.
*
* Just slightly slower than the table lookup method but consumes * Just slightly slower than the table lookup method but consumes
* almost no space. Much faster and smaller than the loop and * almost no space. Much faster and smaller than the loop and
* shift method that is widely used in the embedded space. * shift method that is widely used in the embedded space.
@ -87,8 +86,8 @@
* data = (crcvalue ^ inputchar) & 0xff; * data = (crcvalue ^ inputchar) & 0xff;
* data = (data ^ (data << 4)) & 0xff; * data = (data ^ (data << 4)) & 0xff;
* crc = (crc >> 8) ^ ((data << 8) ^ (data <<3) ^ (data >> 4)) * crc = (crc >> 8) ^ ((data << 8) ^ (data <<3) ^ (data >> 4))
*/ *
/*---------------------------------------------------------------------------*/ ****************************************************************************/
static u16_t crcadd(u16_t crcvalue, u8_t c) static u16_t crcadd(u16_t crcvalue, u8_t c)
{ {
@ -101,11 +100,15 @@ static u16_t crcadd(u16_t crcvalue, u8_t c)
return ((crcvalue >> 8) ^ b); return ((crcvalue >> 8) ^ b);
} }
/*---------------------------------------------------------------------------*/ /****************************************************************************
/* ahdlc_init(buffer, buffersize) - this initializes the ahdlc engine to * Public Functions
****************************************************************************/
/****************************************************************************
* ahdlc_init(buffer, buffersize) - this initializes the ahdlc engine to
* allow for rx frames. * allow for rx frames.
*/ *
/*---------------------------------------------------------------------------*/ ****************************************************************************/
void ahdlc_init(struct ppp_context_s *ctx) void ahdlc_init(struct ppp_context_s *ctx)
{ {
@ -118,11 +121,11 @@ void ahdlc_init(struct ppp_context_s *ctx)
#endif #endif
} }
/*---------------------------------------------------------------------------*/ /****************************************************************************
/* ahdlc_rx_ready() - resets the ahdlc engine to the beginning of frame * ahdlc_rx_ready() - resets the ahdlc engine to the beginning of frame
* state. * state.
*/ *
/*---------------------------------------------------------------------------*/ ****************************************************************************/
void ahdlc_rx_ready(struct ppp_context_s *ctx) void ahdlc_rx_ready(struct ppp_context_s *ctx)
{ {
@ -131,15 +134,15 @@ void ahdlc_rx_ready(struct ppp_context_s *ctx)
ctx->ahdlc_flags |= AHDLC_RX_READY; ctx->ahdlc_flags |= AHDLC_RX_READY;
} }
/*---------------------------------------------------------------------------*/ /****************************************************************************
/* ahdlc receive function - This routine processes incoming bytes and tries * ahdlc receive function - This routine processes incoming bytes and tries
* to build a PPP frame. * to build a PPP frame.
* *
* Two possible reasons that ahdlc_rx will not process characters: * Two possible reasons that ahdlc_rx will not process characters:
* o Buffer is locked - in this case ahdlc_rx returns 1, char * o Buffer is locked - in this case ahdlc_rx returns 1, char
* sending routing should retry. * sending routing should retry.
*/ *
/*---------------------------------------------------------------------------*/ ****************************************************************************/
u8_t ahdlc_rx(struct ppp_context_s *ctx, u8_t c) u8_t ahdlc_rx(struct ppp_context_s *ctx, u8_t c)
{ {
@ -299,14 +302,14 @@ u8_t ahdlc_rx(struct ppp_context_s *ctx, u8_t c)
return 0; return 0;
} }
/*---------------------------------------------------------------------------*/ /****************************************************************************
/* ahdlc_tx_char(char) - write a character to the serial device, * ahdlc_tx_char(char) - write a character to the serial device,
* escape if necessary. * escape if necessary.
* *
* Relies on local global vars : ahdlc_tx_crc, ahdlc_flags. * Relies on local global vars : ahdlc_tx_crc, ahdlc_flags.
* Modifies local global vars : ahdlc_tx_crc. * Modifies local global vars : ahdlc_tx_crc.
*/ *
/*---------------------------------------------------------------------------*/ ****************************************************************************/
void ahdlc_tx_char(struct ppp_context_s *ctx, u16_t protocol, u8_t c) void ahdlc_tx_char(struct ppp_context_s *ctx, u16_t protocol, u8_t c)
{ {
@ -332,15 +335,16 @@ void ahdlc_tx_char(struct ppp_context_s *ctx, u16_t protocol, u8_t c)
ppp_arch_putchar(ctx, c); ppp_arch_putchar(ctx, c);
} }
/*---------------------------------------------------------------------------*/ /****************************************************************************
/* ahdlc_tx(protocol,buffer,len) - Transmit a PPP frame. * ahdlc_tx(protocol,buffer,len) - Transmit a PPP frame.
*
* Buffer contains protocol data, ahdlc_tx addes address, control and * Buffer contains protocol data, ahdlc_tx addes address, control and
* protocol data. * protocol data.
* *
* Relies on local global vars : ahdlc_tx_crc, ahdlc_flags. * Relies on local global vars : ahdlc_tx_crc, ahdlc_flags.
* Modifies local global vars : ahdlc_tx_crc. * Modifies local global vars : ahdlc_tx_crc.
*/ *
/*---------------------------------------------------------------------------*/ ****************************************************************************/
u8_t ahdlc_tx(struct ppp_context_s *ctx, u16_t protocol, u8_t *header, u8_t ahdlc_tx(struct ppp_context_s *ctx, u16_t protocol, u8_t *header,
u8_t *buffer, u16_t headerlen, u16_t datalen) u8_t *buffer, u16_t headerlen, u16_t datalen)
@ -443,5 +447,3 @@ u8_t ahdlc_tx(struct ppp_context_s *ctx, u16_t protocol, u8_t *header,
O O
return 0; return 0;
} }
/*---------------------------------------------------------------------------*/

20
netutils/pppd/chat.c
View File

@ -54,6 +54,10 @@
* Private Functions * Private Functions
****************************************************************************/ ****************************************************************************/
/****************************************************************************
* Name: chat_read_byte
****************************************************************************/
static int chat_read_byte(int fd, char* c, int timeout) static int chat_read_byte(int fd, char* c, int timeout)
{ {
int ret; int ret;
@ -80,12 +84,20 @@ static int chat_read_byte(int fd, char* c, int timeout)
return 0; return 0;
} }
/****************************************************************************
* Name: chat_flush
****************************************************************************/
static void chat_flush(int fd) static void chat_flush(int fd)
{ {
char tmp; char tmp;
while (chat_read_byte(fd, &tmp, 0) == 0); while (chat_read_byte(fd, &tmp, 0) == 0);
} }
/****************************************************************************
* Name: chat_check_response
****************************************************************************/
static int chat_check_response(int fd, const char* response, int timeout) static int chat_check_response(int fd, const char* response, int timeout)
{ {
char c; char c;
@ -119,6 +131,14 @@ static int chat_check_response(int fd, const char* response, int timeout)
return 0; return 0;
} }
/****************************************************************************
* Public Functions
****************************************************************************/
/****************************************************************************
* Name: ppp_chat
****************************************************************************/
int ppp_chat(int fd, struct chat_script_s *script, int echo) int ppp_chat(int fd, struct chat_script_s *script, int echo)
{ {
int ret; int ret;

27
netutils/pppd/ipcp.c
View File

@ -76,7 +76,13 @@ static const u8_t ipcplist[] =
* Private Functions * Private Functions
****************************************************************************/ ****************************************************************************/
/*---------------------------------------------------------------------------*/ /****************************************************************************
* Public Functions
****************************************************************************/
/****************************************************************************
* Name: printip
****************************************************************************/
#if 0 #if 0
void printip(uip_ipaddr_t ip2) void printip(uip_ipaddr_t ip2)
@ -88,7 +94,9 @@ void printip(uip_ipaddr_t ip2)
# define printip(x) # define printip(x)
#endif #endif
/*---------------------------------------------------------------------------*/ /****************************************************************************
* Name: ipcp_init
****************************************************************************/
void ipcp_init(struct ppp_context_s *ctx) void ipcp_init(struct ppp_context_s *ctx)
{ {
@ -110,8 +118,13 @@ void ipcp_init(struct ppp_context_s *ctx)
#endif #endif
} }
/*---------------------------------------------------------------------------*/ /****************************************************************************
/* IPCP RX protocol Handler */ * Name: ipcp_rx
*
* Description:
* IPCP RX protocol Handler
*
****************************************************************************/
void ipcp_rx(struct ppp_context_s *ctx, u8_t *buffer, u16_t count) void ipcp_rx(struct ppp_context_s *ctx, u8_t *buffer, u16_t count)
{ {
@ -412,7 +425,9 @@ void ipcp_rx(struct ppp_context_s *ctx, u8_t *buffer, u16_t count)
} }
} }
/*---------------------------------------------------------------------------*/ /****************************************************************************
* Name: ipcp_task
****************************************************************************/
void ipcp_task(struct ppp_context_s *ctx, u8_t *buffer) void ipcp_task(struct ppp_context_s *ctx, u8_t *buffer)
{ {
@ -507,5 +522,3 @@ void ipcp_task(struct ppp_context_s *ctx, u8_t *buffer)
} }
} }
} }
/*---------------------------------------------------------------------------*/

33
netutils/pppd/lcp.c
View File

@ -84,9 +84,10 @@ static const u8_t lcplist[] =
* Private Functions * Private Functions
****************************************************************************/ ****************************************************************************/
/*---------------------------------------------------------------------------*/ /****************************************************************************
/* lcp_init() - Initialize the LCP engine to startup values */ * lcp_init() - Initialize the LCP engine to startup values
/*---------------------------------------------------------------------------*/ *
****************************************************************************/
void lcp_init(struct ppp_context_s *ctx) void lcp_init(struct ppp_context_s *ctx)
{ {
@ -94,13 +95,13 @@ void lcp_init(struct ppp_context_s *ctx)
ctx->lcp_retry = 0; ctx->lcp_retry = 0;
} }
/*---------------------------------------------------------------------------*/ /****************************************************************************
/* lcp_rx() - Receive an LCP packet and process it. * lcp_rx() - Receive an LCP packet and process it.
* This routine receives a LCP packet in buffer of length count. * This routine receives a LCP packet in buffer of length count.
* Process it here, support for CONF_REQ, CONF_ACK, CONF_NACK, CONF_REJ or * Process it here, support for CONF_REQ, CONF_ACK, CONF_NACK, CONF_REJ or
* TERM_REQ. * TERM_REQ.
*/ *
/*---------------------------------------------------------------------------*/ ****************************************************************************/
void lcp_rx(struct ppp_context_s *ctx, u8_t *buffer, u16_t count) void lcp_rx(struct ppp_context_s *ctx, u8_t *buffer, u16_t count)
{ {
@ -403,7 +404,9 @@ void lcp_rx(struct ppp_context_s *ctx, u8_t *buffer, u16_t count)
} }
} }
/*---------------------------------------------------------------------------*/ /****************************************************************************
* Name: lcp_disconnect
****************************************************************************/
void lcp_disconnect(struct ppp_context_s *ctx, u8_t id) void lcp_disconnect(struct ppp_context_s *ctx, u8_t id)
{ {
@ -418,7 +421,9 @@ void lcp_disconnect(struct ppp_context_s *ctx, u8_t id)
ahdlc_tx(ctx, LCP, 0, buffer, 0, bptr - buffer); ahdlc_tx(ctx, LCP, 0, buffer, 0, bptr - buffer);
} }
/*---------------------------------------------------------------------------*/ /****************************************************************************
* Name: lcp_echo_request
****************************************************************************/
void lcp_echo_request(struct ppp_context_s *ctx, u8_t *buffer) void lcp_echo_request(struct ppp_context_s *ctx, u8_t *buffer)
{ {
@ -463,14 +468,14 @@ void lcp_echo_request(struct ppp_context_s *ctx, u8_t *buffer)
} }
} }
/*---------------------------------------------------------------------------*/ /****************************************************************************
/* lcp_task(buffer) - This routine see if a lcp request needs to be sent * lcp_task(buffer) - This routine see if a lcp request needs to be sent
* out. It uses the passed buffer to form the packet. This formed LCP * out. It uses the passed buffer to form the packet. This formed LCP
* request is what we negotiate for sending options on the link. * request is what we negotiate for sending options on the link.
* *
* Currently we negotiate : Magic Number Only, but this will change. * Currently we negotiate : Magic Number Only, but this will change.
*/ *
/*---------------------------------------------------------------------------*/ ****************************************************************************/
void lcp_task(struct ppp_context_s *ctx, u8_t *buffer) void lcp_task(struct ppp_context_s *ctx, u8_t *buffer)
{ {
@ -591,5 +596,3 @@ void lcp_task(struct ppp_context_s *ctx, u8_t *buffer)
} }
} }
} }
/*---------------------------------------------------------------------------*/

26
netutils/pppd/pap.c
View File

@ -62,7 +62,13 @@
* Private Functions * Private Functions
****************************************************************************/ ****************************************************************************/
/*---------------------------------------------------------------------------*/ /****************************************************************************
* Public Functions
****************************************************************************/
/****************************************************************************
* Name: pap_init
****************************************************************************/
void pap_init(struct ppp_context_s *ctx) void pap_init(struct ppp_context_s *ctx)
{ {
@ -71,9 +77,10 @@ void pap_init(struct ppp_context_s *ctx)
ctx->pap_prev_seconds = 0; ctx->pap_prev_seconds = 0;
} }
/*---------------------------------------------------------------------------*/ /****************************************************************************
/* pap_rx() - PAP RX protocol Handler */ * pap_rx() - PAP RX protocol Handler
/*---------------------------------------------------------------------------*/ *
****************************************************************************/
void pap_rx(struct ppp_context_s *ctx, u8_t *buffer, u16_t count) void pap_rx(struct ppp_context_s *ctx, u8_t *buffer, u16_t count)
{ {
@ -109,11 +116,12 @@ void pap_rx(struct ppp_context_s *ctx, u8_t *buffer, u16_t count)
break; break;
} }
} }
/*---------------------------------------------------------------------------*/
/* pap_task() - This task needs to be called every so often during the PAP /****************************************************************************
* pap_task() - This task needs to be called every so often during the PAP
* negotiation phase. This task sends PAP REQ packets. * negotiation phase. This task sends PAP REQ packets.
*/ *
/*---------------------------------------------------------------------------*/ ****************************************************************************/
void pap_task(struct ppp_context_s *ctx, u8_t *buffer) void pap_task(struct ppp_context_s *ctx, u8_t *buffer)
{ {
@ -185,5 +193,3 @@ void pap_task(struct ppp_context_s *ctx, u8_t *buffer)
} }
} }
} }
/*---------------------------------------------------------------------------*/

62
netutils/pppd/ppp.c
View File

@ -67,8 +67,10 @@
* Private Functions * Private Functions
****************************************************************************/ ****************************************************************************/
/*---------------------------------------------------------------------------*/ /****************************************************************************
/* Unknown Protocol Handler, sends reject */ * Unknown Protocol Handler, sends reject
*
****************************************************************************/
static void ppp_reject_protocol(struct ppp_context_s *ctx, u16_t protocol, static void ppp_reject_protocol(struct ppp_context_s *ctx, u16_t protocol,
u8_t *buffer, u16_t count) u8_t *buffer, u16_t count)
@ -106,7 +108,13 @@ static void ppp_reject_protocol(struct ppp_context_s *ctx, u16_t protocol,
ahdlc_tx(ctx, LCP, buffer, 0, (u16_t)(count + 6), 0); ahdlc_tx(ctx, LCP, buffer, 0, (u16_t)(count + 6), 0);
} }
/*---------------------------------------------------------------------------*/ /****************************************************************************
* Public Functions
****************************************************************************/
/****************************************************************************
* Name: dump_ppp_packet
****************************************************************************/
#if PACKET_RX_DEBUG #if PACKET_RX_DEBUG
void dump_ppp_packet(u8_t *buffer, u16_t len) void dump_ppp_packet(u8_t *buffer, u16_t len)
@ -128,11 +136,11 @@ void dump_ppp_packet(u8_t *buffer, u16_t len)
} }
#endif #endif
/*---------------------------------------------------------------------------*/ /****************************************************************************
/* Initialize and start PPP engine. This just sets things up to * Initialize and start PPP engine. This just sets things up to
* starting values. This can stay a private method. * starting values. This can stay a private method.
*/ *
/*---------------------------------------------------------------------------*/ ****************************************************************************/
void ppp_init(struct ppp_context_s *ctx) void ppp_init(struct ppp_context_s *ctx)
{ {
@ -151,18 +159,17 @@ void ppp_init(struct ppp_context_s *ctx)
ahdlc_rx_ready(ctx); ahdlc_rx_ready(ctx);
} }
/*---------------------------------------------------------------------------*/ /****************************************************************************
/* raise_ppp() - This routine will try to bring up a PPP connection, * raise_ppp() - This routine will try to bring up a PPP connection,
* It is blocking. In the future we probably want to pass a * It is blocking. In the future we probably want to pass a
* structure with all the options on bringing up a PPP link, like * structure with all the options on bringing up a PPP link, like
* server/client, DSN server, username password for PAP... +++ for * server/client, DSN server, username password for PAP... +++ for
* now just use config and bit defines * now just use config and bit defines
*/ *
/*---------------------------------------------------------------------------*/ ****************************************************************************/
#if 0 #if 0
u16_t u16_t ppp_raise(u8_t config, u8_t *username, u8_t *password)
ppp_raise(u8_t config, u8_t *username, u8_t *password)
{ {
u16_t status = 0; u16_t status = 0;
@ -223,7 +230,9 @@ ppp_raise(u8_t config, u8_t *username, u8_t *password)
} }
#endif #endif
/*---------------------------------------------------------------------------*/ /****************************************************************************
* Name: ppp_connect
****************************************************************************/
void ppp_connect(struct ppp_context_s *ctx) void ppp_connect(struct ppp_context_s *ctx)
{ {
@ -239,7 +248,9 @@ void ppp_connect(struct ppp_context_s *ctx)
ctx->ppp_flags = PPP_RX_READY; ctx->ppp_flags = PPP_RX_READY;
} }
/*---------------------------------------------------------------------------*/ /****************************************************************************
* Name: ppp_send
****************************************************************************/
void ppp_send(struct ppp_context_s *ctx) void ppp_send(struct ppp_context_s *ctx)
{ {
@ -251,7 +262,9 @@ void ppp_send(struct ppp_context_s *ctx)
} }
} }
/*---------------------------------------------------------------------------*/ /****************************************************************************
* Name: ppp_poll
****************************************************************************/
void ppp_poll(struct ppp_context_s *ctx) void ppp_poll(struct ppp_context_s *ctx)
{ {
@ -305,11 +318,11 @@ void ppp_poll(struct ppp_context_s *ctx)
} }
} }
/*---------------------------------------------------------------------------*/ /****************************************************************************
/* ppp_upcall() - this is where valid PPP frames from the ahdlc layer are * ppp_upcall() - this is where valid PPP frames from the ahdlc layer are
* sent to be processed and demuxed. * sent to be processed and demuxed.
*/ *
/*---------------------------------------------------------------------------*/ ****************************************************************************/
void ppp_upcall(struct ppp_context_s *ctx, u16_t protocol, u8_t *buffer, u16_t len) void ppp_upcall(struct ppp_context_s *ctx, u16_t protocol, u8_t *buffer, u16_t len)
{ {
@ -364,13 +377,14 @@ void ppp_upcall(struct ppp_context_s *ctx, u16_t protocol, u8_t *buffer, u16_t l
} }
} }
/*---------------------------------------------------------------------------*/ /****************************************************************************
/* scan_packet(list,buffer,len) * scan_packet(list,buffer,len)
* *
* list = list of supported ID's * list = list of supported ID's
* *buffer pointer to the first code in the packet * *buffer pointer to the first code in the packet
* length of the codespace * length of the codespace
*/ *
****************************************************************************/
u16_t scan_packet(struct ppp_context_s *ctx, u16_t protocol, const u8_t *list, u16_t scan_packet(struct ppp_context_s *ctx, u16_t protocol, const u8_t *list,
u8_t *buffer, u8_t *options, u16_t len) u8_t *buffer, u8_t *options, u16_t len)
@ -450,5 +464,3 @@ u16_t scan_packet(struct ppp_context_s *ctx, u16_t protocol, const u8_t *list,
return bad; return bad;
} }
/*---------------------------------------------------------------------------*/