sergiotarxz/nuttx-apps
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

apps/netutils/telnetd: Fix undefined reference to setsockopt.

Browse Source 
Recent change from Xiao Xiang enabled the SO_REUSEADDR socket option unconditionally.  This, of course, causes link time failures if socket options are not enabled:

apps/netutils/telnetd/telnetd_daemon.c:182: undefined reference to 'setsockopt'.

Observed during build testing with configuration rddrone-uavcan144:nsh
This commit is contained in:
Gregory Nutt 2020-02-08 10:16:13 -06:00 committed by Xiang Xiao
parent f14aead53e
commit d2522e2821
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
netutils/telnetd/telnetd_daemon.c
View File

@ -176,6 +176,7 @@ static int telnetd_daemon(int argc, FAR char *argv[])
goto errout_with_daemon;
}
#ifdef CONFIG_NET_SOCKOPTS
/* Set socket to reuse address */
optval = 1;
@ -185,6 +186,7 @@ static int telnetd_daemon(int argc, FAR char *argv[])
nerr("ERROR: setsockopt SO_REUSEADDR failure: %d\n", errno);
goto errout_with_socket;
}
#endif
/* Bind the socket to a local address */
@ -261,9 +263,9 @@ static int telnetd_daemon(int argc, FAR char *argv[])
}
}
#ifdef CONFIG_NET_SOLINGER
/* Configure to "linger" until all data is sent when the socket is closed */
#ifdef CONFIG_NET_SOLINGER
ling.l_onoff = 1;
ling.l_linger = 30; /* timeout is seconds */
if (setsockopt(acceptsd, SOL_SOCKET, SO_LINGER, &ling, sizeof(struct linger)) < 0)