sergiotarxz/nuttx-apps
sergiotarxz/nuttx-apps
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

system/termcurses: Fix the compiler warning

Browse Source 
tcurses_vt100.c: In function 'tcurses_vt100_move':
Error: tcurses_vt100.c:121:48: error: '%d' directive writing between 1 and 11 bytes into a region of size between 2 and 12 [-Werror=format-overflow=]
  121 | static const char *g_movecurs       = "\033[%d;%dH";  /* Move cursor to x,y */
      |                                                ^~
tcurses_vt100.c:121:39: note: directive argument in the range [-2147483647, 2147483647]
  121 | static const char *g_movecurs       = "\033[%d;%dH";  /* Move cursor to x,y */
      |                                       ^~~~~~~~~~~~~
tcurses_vt100.c:795:9: note: 'sprintf' output between 7 and 27 bytes into a destination of size 16
  795 |         sprintf(str, g_movecurs, row + 1, col + 1);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
This commit is contained in:
Xiang Xiao 2022-03-06 20:01:14 +08:00 committed by Xiang Xiao
parent 2385718f1c
commit df48f0bb73
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
system/termcurses/tcurses_vt100.c
View File

@ -782,7 +782,7 @@ static int tcurses_vt100_move(FAR struct termcurses_s *dev, int type,
FAR struct tcurses_vt100_s *priv;
int ret = -ENOSYS;
int fd;
char str[16];
char str[32];
priv = (FAR struct tcurses_vt100_s *)dev;
fd = priv->out_fd;
@ -792,7 +792,7 @@ static int tcurses_vt100_move(FAR struct termcurses_s *dev, int type,
switch (type)
{
case TCURS_MOVE_YX:
sprintf(str, g_movecurs, row + 1, col + 1);
snprintf(str, sizeof(str), g_movecurs, row + 1, col + 1);
ret = write(fd, str, strlen(str));
break;