sergiotarxz/nuttx-apps
sergiotarxz/nuttx-apps
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

OS test: improve synchronization for starting the round robin test

Browse Source
This commit is contained in:
Gregory Nutt 2015-07-24 13:04:40 -06:00
parent 388217c1a0
commit e5ebfe35f6
2 changed files with 31 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ChangeLog.txt
View File

@ -1359,4 +1359,7 @@
don't have the wherewithal for that change today (2015-04-14)`.
* apps/nshlib and apps/examaples/thttpd: Change decoding to handle the
increased size of the scheduling policy field in the TCB (2015-07-23).
* apps/examples/ostest: Improve syncrhonization in round robin tests.
On very fast processors, there are race conditions that make the test
failure. Need better interlocking to assure that the threads actually
do start at the same time (2015-07-24).

29
examples/ostest/roundrobin.c
View File

@ -1,7 +1,7 @@
/********************************************************************************
* examples/ostest/roundrobin.c
*
* Copyright (C) 2007, 2008, 2012 Gregory Nutt. All rights reserved.
* Copyright (C) 2007, 2008, 2012, 2015 Gregory Nutt. All rights reserved.
* Author: Gregory Nutt <gnutt@nuttx.org>
*
* Redistribution and use in source and binary forms, with or without
@ -38,14 +38,18 @@
********************************************************************************/
#include <nuttx/config.h>
#include <stdio.h>
#include <stdbool.h>
#include <semaphore.h>
#include <sched.h>
#include "ostest.h"
#if CONFIG_RR_INTERVAL > 0
/********************************************************************************
* Definitions
* Pre-processor Definitions
********************************************************************************/
/* This numbers should be tuned for different processor speeds via .config file.
@ -68,6 +72,12 @@
# warning "Invalid value of CONFIG_EXAMPLES_OSTEST_RR_RUNS, using default value = 10"
#endif
/********************************************************************************
* Private Data
********************************************************************************/
static sem_t g_rrsem;
/********************************************************************************
* Private Functions
********************************************************************************/
@ -122,6 +132,8 @@ static FAR void *get_primes_thread(FAR void *parameter)
int last;
int i;
while (sem_wait(&g_rrsem) < 0);
printf("get_primes_thread id=%d started, looking for primes < %d, doing %d run(s)\n",
id, CONFIG_EXAMPLES_OSTEST_RR_RANGE, CONFIG_EXAMPLES_OSTEST_RR_RUNS);
@ -154,6 +166,8 @@ void rr_test(void)
pthread_addr_t result;
int status;
/* Setup common thread attrributes */
status = pthread_attr_init(&attr);
if (status != OK)
{
@ -181,6 +195,13 @@ void rr_test(void)
printf("rr_test: Set thread policy to SCHED_RR\n");
}
/* This semaphore will prevent anything from running */
sched_lock();
sem_init(&g_rrsem, 0, 0);
/* Start the threads */
printf("rr_test: Starting first get_primes_thread\n");
status = pthread_create(&get_primes1_thread, &attr, get_primes_thread, (FAR void *)1);
@ -203,6 +224,10 @@ void rr_test(void)
printf(" If RR scheduling is working, they should start and complete at\n");
printf(" about the same time\n");
sem_post(&g_rrsem);
sem_post(&g_rrsem);
sched_unlock();
pthread_join(get_primes2_thread, &result);
pthread_join(get_primes1_thread, &result);
printf("rr_test: Done\n");