sergiotarxz/nuttx-apps
sergiotarxz/nuttx-apps
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

system: enable O_CLOEXEC when openning audio device

Browse Source 
N/A

to avoid multiple open operations of audio_open

Change-Id: Id283def4811c71f3c0bd38dc1a480afce303c4c3
Signed-off-by: danguanghua <danguanghua@xiaomi.com>
This commit is contained in:
danguanghua 2020-12-17 20:14:08 +08:00 committed by Xiang Xiao
parent 384d423415
commit f210010466
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
system/nxplayer/nxplayer.c
View File

@ -310,7 +310,7 @@ static int nxplayer_opendevice(FAR struct nxplayer_s *pplayer, int format,
/* Device supports the format. Open the device file. */ /* Device supports the format. Open the device file. */
pplayer->dev_fd = open(pplayer->prefdevice, O_RDWR); pplayer->dev_fd = open(pplayer->prefdevice, O_RDWR | O_CLOEXEC);
if (pplayer->dev_fd == -1) if (pplayer->dev_fd == -1)
{ {
int errcode = errno; int errcode = errno;
@ -380,7 +380,7 @@ static int nxplayer_opendevice(FAR struct nxplayer_s *pplayer, int format,
snprintf(path, sizeof(path), "/dev/audio/%s", pdevice->d_name); snprintf(path, sizeof(path), "/dev/audio/%s", pdevice->d_name);
#endif /* CONFIG_AUDIO_CUSTOM_DEV_PATH */ #endif /* CONFIG_AUDIO_CUSTOM_DEV_PATH */
if ((pplayer->dev_fd = open(path, O_RDWR)) != -1) if ((pplayer->dev_fd = open(path, O_RDWR | O_CLOEXEC)) != -1)
{ {
/* We have the device file open. Now issue an AUDIO ioctls to /* We have the device file open. Now issue an AUDIO ioctls to
* get the capabilities * get the capabilities
@ -2367,7 +2367,7 @@ int nxplayer_systemreset(FAR struct nxplayer_s *pplayer)
#else #else
snprintf(path, sizeof(path), "/dev/audio/%s", pdevice->d_name); snprintf(path, sizeof(path), "/dev/audio/%s", pdevice->d_name);
#endif #endif
if ((pplayer->dev_fd = open(path, O_RDWR)) != -1) if ((pplayer->dev_fd = open(path, O_RDWR | O_CLOEXEC)) != -1)
{ {
/* We have the device file open. Now issue an /* We have the device file open. Now issue an
* AUDIO ioctls to perform a HW reset * AUDIO ioctls to perform a HW reset

2
system/nxrecorder/nxrecorder.c
View File

@ -88,7 +88,7 @@ static int nxrecorder_opendevice(FAR struct nxrecorder_s *precorder)
/* Device supports the format. Open the device file. */ /* Device supports the format. Open the device file. */
precorder->dev_fd = open(precorder->device, O_RDWR); precorder->dev_fd = open(precorder->device, O_RDWR | O_CLOEXEC);
if (precorder->dev_fd == -1) if (precorder->dev_fd == -1)
{ {
int errcode = errno; int errcode = errno;