apps/nshlib: Fix buffer overrun when redirected to a file.
SAVE_SIZE must be the same as sizeof(struct serialsave_s)
Signed-off-by: Masayuki Ishikawa <Masayuki.Ishikawa@jp.sony.com>
Approved-by: GregoryN <gnutt@nuttx.org>
===============================================
1. Deletion of last line in file using 'dd' caused infinite loop searching for
'nextline'. Fixed.
2. Insertion of line above 1st line using 'O' caused line to be inserted on
2nd line. Fixed.
3. Paste buffer from 'dd' was being free'd after the 'p'aste operation,
preventing multiple paste opportunity. Fixed.
4. The cursor was not being bound to the line end and was allowed to 'hover'
over the '\n' EOL character. This caused wierd (relative to standard vi)
insertion locations and cursor movement with 'a'ppend and 'i'nsert. Fixed.
5. The 'vi_shrinkpos' position didn't take the end of file pointer into
account when calculating 'curpos', 'prevpos' variables causing wierdness
when deleting things near the end of the file. Fixed.
6. The 'yy'ank command was improperly deleting the text from the document
instead of simply yanking to the paste buffer. Fixed.
7. The 'dd'elete line funciton was not copying the deleted line to the paste
buffer as part of the delete operation. Fixed.
8. The bottom line of the screen was sometimes being used for document text
and other times for command / find entry. Fixed by reserving the bottom
the bottom line for status / command only.
9. When scrolling up / down through a file, the cursor position was not
preserved and moved further and further to the left column based on the
line lengths of the lines visited. Fixed.
10. The display was being COMPLETELY redrawn with each keystroke, causing the
responsiveness to be imbearable. Fixed. Added logic to dynamicall
indicated which portions of the screen need to be updated (full display,
current line to end of screen, current line only, none).
11. The individual display line updates were being performed a character at
a time by calling the vi_putch() function, causing slow performance,
especially in telnet or USBCDC sessions where there is a lot of overhead
per packet. Fixed by calling vi_write() instead with a block of
characters with breaks as needed for TAB exansion.
12. The forward delete 'x' operation allowed deletion through '\n' characters
causing lines to be joined. This is different from standard vi where
'x' at the end of a line performs a delete backward operation. Fixed.
13. When in 'ex' or find sub-modes (':' or '/' bottom line modes), hitting
backspace with empty text did not return the operation to command mode
like it does in standard vi. Fixed.
14. Performing a 'find' opertation would only search from the current cursor
position to the end of the file and did not wrap like in standard vi.
Fixed.
15. Loading a file that was larger than the initial text allocation would
force a call to 'vi_extendtext', marking the file as modified when in
fact it hadn't even been loaded yet. Fixed.
16. Combined vi_insert_mode and vi_replace_mode into a single function to
save code space since they are nearly identical routines.
17. In command mode, backspace was deleting characters which is different
from standard vi. Backspace in command mode normally simply moves the
cursor left / to the previous line. Fixed.
18. Added code to handle boundry conditions when the file is new and
commands are applied to an empty file.
19. Fixed vi_shrinktext so it doesn't allocate a zero-length buffer when
the last character in the file is deleted.
20. The 'x' command was not copying to the paste buffer. Fixed.
21. Fixed parsecolon routine to properly deal with ":wq" command sequence.
New feature additions
=====================
1. Vi startup feature to prepend the current working directory to the
supplied filename if it does not start with '/' absolute path specifier.
This allows editing files in the current directory without needing to
fully qualify the filename.
2. Standard '~' empty screen line characters for proper identification
of empty '\n' only lines at the end of the file.
3. Moving into insert or append mode now prints '--INSERT--' in the status
line and clears it upon exit.
4. Integration with termcurses to detect special keystrokes and to
handle terminal type differences. Haven't yet converted all vt100 print
codes to termcurses equivalents.
5. Support for up, down, left, right arrows, page-up, page-down keys
in command mode.
6. Added 'b' command to move cursor 'b'ack to previous word. Honors the
command repeat value for multiple word moves.
7. Added 'w' command to move cursor to next 'w'ord. Honors the command
repeat value for multiple word moves.
8. Added 'f' and 't' commands to find characters on the current line.
Honors the command repeat value.
9. Added the find 'n'ext command to repeat the previous find operation.
10. Added the 'H', 'M', and 'L' commands to move the cursor to top,
middle and bottom of the display.
11. Extended yank/paste to manage a paste buffer with character mode in
addition to line mode. Character mode allows cut / paste of
individual characters or groups of characters vs. full lines.
12. Added support in the 'd'elete and 'y'ank commands for character mode
deletions such as 'dw', 'dfa', '2yw', etc.
13. Added support in paste routine for multiple paste using command value
argument.
14. Added support for the 'D' and 'C' delete and change to end of line
commands.
15. Added support for 's'ubstitute key ('x' followed by insert mode).
16. Modified yank / paste allocation scheme to avoid repeated alloc
and free of paste buffer. Uses a minimum allocation size scheme and
only does free / realloc when paste does not fit. If the paste is
smaller than the current allocation and the current allocation is
larger than the threshold, then the buffer is freed and a smaller
buffer allocated. Otherwise the existing buffer is used.
17. Support for 'P'aste before current cursor position.
18. Support for '?' reverse search mode.
19. Support for 'J'oin next line with current line command.
20. Printing of current row,col in status line of display.
21. Command repeat '.' support for commands that modifiy text.
22. Support in replace / insert mode for arrow keys, PGUP / PGDN, HOME,
and END. Using these will cause the command repeat buffer to
reset such that only the last text addition after a cursor movement
is saved.
23. Added 'X' delete previous command.
24. Added "gg" go to top of document command sequence.
25. Added "ZZ" save and quit command (equivalent to :wq).
26. Implemented '^' goto first non-whitespace on current line, along
with '+' and '-' goto first non-whitespace on next / previous line.
27. Added CR / LF goto first non-whitespace on next line in command mode.
wireless/ieee802154/i8sak: Fixes issues related to re-running daemon. Releases lock when releasing daemon. Re-sets daemon_shutdown so that a subsequent daemon launch does not immediately return.
Approved-by: GregoryN <gnutt@nuttx.org>
Test case:
NuttShell (NSH)
nsh> mkrd -s 1024 40
nsh> mkfatfs /dev/ram0
nsh> mount -t vfat /dev/ram0 /tmp
nsh> echo "echo 1 > /dev/null" > /tmp/test.sh
nsh> cat /tmp/test.sh
echo 1 > /dev/null
nsh> sh /tmp/test.sh
...
The nsh prompt doesn't get printed. You can type a couple of commands, but then the system will crash because of bad pointers.
1. A memory corruption issue that occurs from a paste operation that would overflow the fixed buffer size for keyboard processing.
2. A stall in getch() processing when there are cached keycodes in the termcurses emulation (tcurses_vt100.c).
