Commit Graph

4592 Commits

Author SHA1 Message Date
Xiang Xiao
eb8678cfeb Remove CONFIG_DEV_LOWCONSOLE from source code
Follow the nuttx side change
2020-02-18 13:13:29 -06:00
Xiang Xiao
569618220a Change CONFIG_CXX_NEWLONG to CONFIG_ARCH_SIZET_LONG
Follow up nuttx side change
2020-02-18 07:37:54 -06:00
Ouss4
e55e310622 testing/fstest/fstest_main.c: Eliminate a warning found during the build
test.
2020-02-15 17:06:51 -06:00
Gregory Nutt
218d8c9fe2 examples/elf/tests/mutex/mutex.c: Fix typo in a previous PR. 2020-02-15 19:08:03 +01:00
Gregory Nutt
1056cce2b5 apps/examples/elf: Correct mount point configuration error.
If an external file system is used but is not mounted by the the ELF example, then a compilation error will occur.  This configuration problem has existed for a long time but was unmasked by a recent PR.  In the failure mode, CONFIG_EXAMPLES_ELF_FSTYPE would not be defined because it depends on CONFIG_EXAMPLES_ELF_FSMOUNT which is not defined.  The resulting mountpoint, MOUNTPT, would therefore be left in an invalid state.  Previous changes to conditional logic now allowed setenv() to run and to attempt to set the PATH variable to MOUNTPT, causing a compile time failure like this:

    CC:  elf_main.c
    elf_main.c: In function 'elf_main':
    elf_main.c:113:32: error: expected ')' before 'CONFIG_EXAMPLES_ELF_FSTYPE'
     #  define MOUNTPT      "/mnt/" CONFIG_EXAMPLES_ELF_FSTYPE
                                ^~~~~~~~~~~~~~~~~~~~~~~~~~
    elf_main.c:364:18: note: in expansion of macro 'MOUNTPT'
       setenv("PATH", MOUNTPT, 1);
                       ^~~~~~~
    elf_main.c:364:3: error: too few arguments to function 'setenv'
       setenv("PATH", MOUNTPT, 1);
       ^~~~~~
    In file included from elf_main.c:47:
    D:\Spuda\Documents\projects\nuttx\master\nuttx-fork\include/stdlib.h:158:11: note: declared here
     int       setenv(FAR const char *name, FAR const char *value, int overwrite);
               ^~~~~~

This problem was found during manual build testing using configuration lx_cpu:nsh.
2020-02-15 18:06:43 +01:00
Gregory Nutt
1d8b738a2b apps/examples/elf: Resolve issue issue 63 2020-02-15 23:55:33 +08:00
YAMAMOTO Takashi
e5dd0b1eb9 mksymtab.sh: Avoid using find -executable
As it seems GNU-find only.  macOS doesn't have it.

-perm is in POSIX and should be more widely available.
2020-02-14 09:13:55 -06:00
Xiang Xiao
d81b7af407 ntpclient: Use sem protect global variable instead sched_lock/unlock 2020-02-14 09:08:31 -06:00
Xiang Xiao
02a800c930 ntpclient: Initialize g_ntpc_daemon at the definition
Change-Id: I4dad2e246aca7d30092cf8a4bc8136e90668f134
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2020-02-14 09:01:57 -06:00
Xiang Xiao
782953ff05 ntpclient: the 2nd arg of MKLVM should be version number
Change-Id: I742c3a5082f48fcc8e291100ff81c60093bc7538
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2020-02-14 09:01:57 -06:00
YAMAMOTO Takashi
66e7590dd0 examples/elf: Don't bother to honor CONFIG_PATH_INITIAL
As we know where the binaries are, there's little point
to use CONFIG_PATH_INITIAL.
2020-02-14 18:38:07 +08:00
YAMAMOTO Takashi
afa51c2e00 Fix documentation typos 2020-02-14 16:08:07 +08:00
Masayuki Ishikawa
de4d52d465 wireless: gs2200m: Add support for setsockopt_request()
NOTE: Just check parameters and do nothing special

Signed-off-by: Masayuki Ishikawa <Masayuki.Ishikawa@jp.sony.com>
2020-02-14 15:01:28 +08:00
YAMAMOTO Takashi
c5673957cc Remove unused BUILTIN_PROXY_STACKSIZE config
It has been unused since the following change:
"All argv types should be char * const * not const char **"
2020-02-13 15:00:56 +08:00
Gregory Nutt
44b8c9c5aa apps/examples/tcpblaster: Fix compile errors in loopback mode. 2020-02-10 21:05:49 +01:00
Masayuki Ishikawa
539d0854dd examples: elf: Fix warnings when compiled for RISC-V 64bit 2020-02-10 14:16:00 +08:00
Xiang Xiao
779197c63e Ensure all source code end with one and only one newline
by this command:
git ls-files -z | while IFS= read -rd '' f; do tail -c1 < "$f" | read -r _ || echo >> "$f"; done
2020-02-09 08:14:49 -06:00
Xiang Xiao
4a13a0893f testing/smp: Replace up_cpu_index with sched_getcpu 2020-02-09 08:11:39 -06:00
Gregory Nutt
d2e1c8a4f3 apps/wireless/gs2200m/gs2200m_main.c: Eliminate a warning
Eliminate warning:

    gs2200m_main.c:  In function 'gs2200m_loop':
    gs2200m_main.c:1416:1:  warning: label 'errout' defined but not used [-Wunused-label]
2020-02-09 00:32:25 +01:00
Gregory Nutt
c8dbd59e9a netutils/telnetd/telnetd_daemon.c: Avoid a warning if CONFIG_NET_SOCKOPTS=n 2020-02-09 00:33:39 +08:00
Gregory Nutt
d2522e2821 apps/netutils/telnetd: Fix undefined reference to setsockopt.
Recent change from Xiao Xiang enabled the SO_REUSEADDR socket option unconditionally.  This, of course, causes link time failures if socket options are not enabled:

apps/netutils/telnetd/telnetd_daemon.c:182: undefined reference to 'setsockopt'.

Observed during build testing with configuration rddrone-uavcan144:nsh
2020-02-09 00:33:39 +08:00
Xiang Xiao
f14aead53e Shouldn't use local readline in telnet
Shouldn't use local readline in telnet since the host has more powerful intelligent
2020-02-08 07:58:04 -06:00
Miguel Herranz
960a92c652 Make SO_REUSEADDR not mandatory in netlib
This functionality is not available in NuttX so far.
2020-02-06 23:43:37 +01:00
Miguel Herranz
a5dff52a71 Change unimplemented requests behaviour in gs2200m
The ASSERT is too strong, as it cannot be disabled, so changing to
DEBUGASSERT, as calling these functions should not be a problem as
long as the application logic handle the error correctly.

The error code is changed to ENOSYS, as it seems to better reflect
the fact that the call itself would be valid, but the functionality
is not implemented (see [1] or `man errno`).

[1] https://www.gnu.org/software/libc/manual/html_node/Error-Codes.html
2020-02-06 23:43:37 +01:00
YAMAMOTO Takashi
2f4b309b1b gs2200m: Retry indefinately on GS2200M_IOC_ASSOC failure
Author: Alan Carvalho de Assis <engenharia03@siam.ind.br>

    Run nxstyle again gs2200m_main.c file and fix issues

Author: YAMAMOTO Takashi <yamamoto@midokura.com>

    gs2200m: Retry indefinately on GS2200M_IOC_ASSOC failure

    The ioctl doesn't return why it failed.
    It might or might not be a transient failure.

    In my environment, gs2200m often returns the following for AT+WA.
    It usually works after a few retries.

    [   12.110000] _parse_pkt_in_s1: +++++ 0:(msize=19, msg=WLAN CONNECT ERROR|)
    [   12.110000] _parse_pkt_in_s1: +++++ 1:(msize=6, msg=ERROR|)
2020-02-05 18:45:43 -03:00
liuhaitao
e738fbedba graphics/littlevgl/Makefile: update lvgl.h dependency to fix parallel build break
Parallel build imxrt1060-evk:lvgl with the below error:
make[3]: *** No rule to make target 'lvgl/lvgl.h', needed by '/home/jenkins/jenkins-slave/
workspace/NuttX-Nightly-Build/apps/include/graphics/lvgl.h'.

Signed-off-by: liuhaitao <liuhaitao@xiaomi.com>
2020-02-05 05:50:56 -08:00
Masayuki Ishikawa
bb3cd0a496 apps: elf: Fix stack corruption in task test
Signed-off-by: Masayuki Ishikawa <Masayuki.Ishikawa@jp.sony.com>
2020-02-04 20:56:52 -08:00
Xiang Xiao
bf3e6e2367 Improvements for telnet server
Author: Xiang Xiao <xiaoxiang@xiaomi.com>

    Check POLLHUP and POLLERR in telnet poll loop

      to handle the remote end close correctly

    Send "NVT"(network virtual terminal) as the default if getenv("TERM") return NULL

      telnet should trigger the error handling if inet_pton return zero
      since zero mean the string has format error

    Don't return 1 in _environ_telnet to avoid trigger the compression
    and remove the redundant TELNET_TELOPT_COMPRESS2 check

    Change telnet_error_u to telnet_error_e required by the coding standard

    Ensure telnet object get freed before the abnormal exit
2020-02-04 19:09:22 -03:00
YAMAMOTO Takashi
43a36996ca nettest: Avoid conflicts with host definitions 2020-02-04 09:36:50 -06:00
YAMAMOTO Takashi
bcc0f5c0a9 nettest: Avoid common symbols 2020-02-04 09:36:08 -06:00
Xiang Xiao
e0adf5ee0b Remove all CONFIG_NET_HAVE_REUSEADDR guard 2020-02-03 15:13:19 -06:00
Xiang Xiao
1d6fcfac13 Build system: Reference tools/define.sh through DEFINE macro 2020-02-03 15:09:33 -06:00
Gregory Nutt
724a34bd3b Run all files modified by pr45 through nxstyle. 2020-02-03 07:38:57 -06:00
Xiang Xiao
37135e5dfe telnetd should listen both IPv4 and IPv6 for the dual stack
Change-Id: Ic1c2878f2eda721ccdf667b0a634289c643f5220
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2020-02-03 07:17:22 -06:00
Xiang Xiao
c44f271195 Fix ret undefined error in nsh_telnetlogin when CONFIG_NSH_LOGIN_PLATFORM enable
Change-Id: Ib1fa8ba6879a5b330201f1144a2e5827cc4b1d0a
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2020-02-03 07:17:22 -06:00
Xiang Xiao
72bbc27b0f Free daemon struct in all telnetd_daemon error path
Change-Id: I7f014dc5f327a6ae6adf9cdbea8089ffab2efe37
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2020-02-03 07:17:22 -06:00
Xiang Xiao
d6e450e39a Skip to close acceptsd since it is already closed in SIOCTELNET handler
Change-Id: I669224fd5cd44162bb67c8316b56348f7f298883
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2020-02-03 07:17:22 -06:00
Xiang Xiao
579327a972 Remove CONFIG_NET_HAVE_REUSEADDR check from telnetd_daemon
since this option doesn't exist at all

Change-Id: I9ee8e61d0a8af1c9eb690b2f2945a7f7f7b5f834
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2020-02-03 07:17:22 -06:00
Xiang Xiao
28891ef27e Remove the global variable in telnetd_daemon
Change-Id: I264d10c0f141109ada6ac90afb2ba3e8cfad4404
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2020-02-03 07:17:22 -06:00
Xiang Xiao
1154735ca6 Refine the preprocess conditional guard style 2020-01-31 11:04:10 -06:00
Xiang Xiao
e0dcfa0c55 Remove extra whitespace from files (#43)
* Remove multiple newlines at the end of file
* Remove the white space from the end of line
2020-01-31 08:29:24 -06:00
Xiang Xiao
3dbf8d5652
testing/cxxtest/Make.defs: Append cxxtest to CONFIGURED_APPS (#42) 2020-01-31 14:35:32 +01:00
patacongo
8c9663b6c1
apps/examples/userfs/userfs_main.c: Fix warning (#41)
Fixes warning:

    CC:  userfs_main.c
    userfs_main.c:182:3: warning: initialization from incompatible pointer type [-Wincompatible-pointer-types]
       ufstest_truncate,
       ^
    userfs_main.c:182:3: note: (near initialization for ‘g_ufstest_ops.truncate’)

Co-authored-by: Gregory Nutt <gnutt@nuttx.org>
2020-01-30 18:58:03 +01:00
patacongo
7a8790f1b4
apps/testing/mm: Make stacksize configurable (#40)
Make stacksize as well as program name and priority configurable.  The defaults are the same as the previous hardcoded values.

The default stacksize of 2048 bytes is more than enough for most target applications.  However, when running on the simulator, much large stack sizes are needed.
2020-01-30 17:43:04 +01:00
patacongo
ba6377078b
apps/testing/mm: Move from apps/examples/mm (#39) 2020-01-30 17:07:00 +01:00
Gregory Nutt
4e509c8659 Revert "examples: hello: Show CPU index when running in SMP mode"
Cannot call up_cpu_index() or any other nonstandard OS application interface.  This not only breaks the portable POSIX OS interface but also would break any PROTECTED or KERNEL mode SMP implementation.

If you want to do something like this in user space, the appropriate thing to do would be to extend prctl().  That is non-posix, but is at least Linux-like and will work in all build modes.

This reverts commit 715517b1a0.
2020-01-30 05:41:13 -06:00
Masayuki Ishikawa
715517b1a0 examples: hello: Show CPU index when running in SMP mode
Signed-off-by: Masayuki Ishikawa <Masayuki.Ishikawa@jp.sony.com>
2020-01-30 09:23:12 +01:00
Alin Jerpelea
59b763add4 netutils/netlib: Fix buffer overflow 2020-01-29 00:29:30 -08:00
YAMAMOTO Takashi
b6890df58d Fix a build on macOS
On some platforms like macOS, we can't create an empty archive.
2020-01-29 09:03:01 +01:00
Masayuki Ishikawa
e4af73ec56 wireless: gs2200m: Fix sendto_request() in gs2200m_main.c
Signed-off-by: Masayuki Ishikawa <<Masayuki.Ishikawa@jp.sony.com>
2020-01-28 10:35:50 +01:00