sergiotarxz/nuttx-apps
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
6,797 Commits 1 Branch 0 Tags 24 MiB
3e68694bdf
Commit Graph

56 Commits

Author SHA1 Message Date
Petro Karashchenko
aed0e2873e apps: fix style issues in code 
Add missing FAR and CODE to pointers
Remove FAR for non-pointer variables
Remove extra spaces and align the parameters
Add do {} while(0) wrapper in macro
Use nitems to calculate number of elements in arrays

Signed-off-by: Petro Karashchenko <petro.karashchenko@gmail.com>
 2023-06-11 18:47:50 +08:00
Xiang Xiao
7c37421266 Replace all sprintf with snprintf 
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
 2023-05-08 21:35:16 +03:00
Fotis Panagiotopoulos
c50ff7ff61 Fixes in asprintf usage. 2023-04-23 17:16:34 +08:00
lilei19
41f60bd669 change strcpy to strlcpy 
Change-Id: I8b9429a3c225a82842fce136bdb14b8b135066d3
Signed-off-by: lilei19 <lilei19@xiaomi.com>
 2023-02-22 23:09:55 +08:00
Xiang Xiao
d1e46c2d3e compiler.h: Add _ between format|printf|syslog|scanf|strftime and like 
align with other macro naming style

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
 2022-12-21 01:05:12 +02:00
Xiang Xiao
d52a8298ce Fix Error: ftpd.c:1773:9: error: variable 'pos' set but not used [-Werror,-Wunused-but-set-variable] 
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
 2022-10-27 22:41:58 +02:00
Fotis Panagiotopoulos
ab7cb90f88 ftpd: Fixed compiler warnings. 2022-10-06 23:54:31 +08:00
Fotis Panagiotopoulos
387eba2efd ftpd: server port made configurable. 2022-09-04 11:03:28 -04:00
Fotis Panagiotopoulos
e3a9be0d05 Minor changes in ftpd. 2022-09-03 21:49:15 +08:00
Xiang Xiao
c252ec1481 Add printflike to all printf like functions 
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
 2022-07-18 14:09:10 +03:00
Xiang Xiao
a12707177b Remove "| O_BINARY" or " |= O_BINARY" since O_BINARY is 0 now 
follow nuttx kernel side change

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
 2022-06-07 20:22:38 +03:00
Petro Karashchenko
319203d5d8 apps: unify FAR attribute usage across apps 
Signed-off-by: Petro Karashchenko <petro.karashchenko@gmail.com>
 2022-04-05 00:55:22 +08:00
Petro Karashchenko
aaa950faee netutils/ftpd: Do not terminate connection if CWD fails 
Signed-off-by: Petro Karashchenko <petro.karashchenko@gmail.com>
 2022-04-04 17:32:51 +08:00
Petro Karashchenko
c1dfaf42ff netutils/ftpd: add option to login to FTPD using FSUTILS_PASSWD 
Signed-off-by: Petro Karashchenko <petro.karashchenko@gmail.com>
 2022-03-28 23:30:45 +08:00
Huang Qi
5451214d0b ftpd: Remove usage of deprecated macro __NUTTX__ 
Signed-off-by: Huang Qi <huangqi3@xiaomi.com>
 2022-02-14 13:57:10 +08:00
Xiang Xiao
e9104dbbef Include assert.h in necessary place 
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
 2021-06-01 06:36:44 +09:00
Juha Niskanen
eceaeb926a netutils/ftpd, examples/ftpd: code cleanup and nxstyle 
Signed-off-by: Juha Niskanen <juha.niskanen@haltian.com>
 2021-01-13 20:22:55 -06:00
Juha Niskanen
31f52a1971 netutils/ftpd: fix compilation on dual-stack systems 
Signed-off-by: Juha Niskanen <juha.niskanen@haltian.com>
 2021-01-13 20:22:55 -06:00
Juha Niskanen
5c8d6934a5 netutils/ftpd: fix hardfault when initial socket, bind or listen fails 
Signed-off-by: Juha Niskanen <juha.niskanen@haltian.com>
 2021-01-13 20:22:55 -06:00
YAMAMOTO Takashi
3e015320e3 netutils/ftpd/ftpd.c: Fix syslog formats 2020-11-27 02:43:30 -06:00
YAMAMOTO Takashi
28296d539d netutils/ftpd/ftpd.c: Fix a printf format warning 2020-11-13 05:51:23 -08:00
Masayuki Ishikawa
34305351c4 netutils: ftpd: Fix style violations in ftpd.c 
Signed-off-by: Masayuki Ishikawa <Masayuki.Ishikawa@jp.sony.com>
 2020-05-22 16:53:37 +08:00
Masayuki Ishikawa
e6196d2c9c netutils: ftpd: Fix EPSV mode in ftpd.c (IPv4 only) 
Signed-off-by: Masayuki Ishikawa <Masayuki.Ishikawa@jp.sony.com>
 2020-05-22 16:53:37 +08:00
Xiang Xiao
41d88f06e7 Run codespell -w with the latest dictonary again 2020-02-23 07:10:14 -06:00
Xiang Xiao
e0adf5ee0b Remove all CONFIG_NET_HAVE_REUSEADDR guard 2020-02-03 15:13:19 -06:00
Xiang Xiao
e0dcfa0c55 Remove extra whitespace from files (#43) 
* Remove multiple newlines at the end of file
* Remove the white space from the end of line
 2020-01-31 08:29:24 -06:00
Gregory Nutt
561fc02ae5 netutils/ftpd/ftpd.c: Fix an error introduced in PR10. In error clean-up, it was trying to free memory on an error where we failed allocated memory. Not good. 2020-01-12 11:55:16 +00:00
Gregory Nutt
e67850971d apps/netutils/ftpd/ftpd.c: Fixes several problems: 
1. This fixes the issue reported in Bitbucket apps/ Issue 15.  That is, if fopen() fails, the NULL stream handle would be used in subsequent logic.  The handling of the failure was incomplete.
2. Some of the error handling was fixed.  In the event of an error, it was return return an error value ONLY if we failure to report the error and even then the wrong error would be reported.  This change now preserves and returns the correct error number that is the root cause of the failure.
3. Ran the file through tools/nxstyle and cleaned up many formatting problems.
 2020-01-11 22:22:46 -03:00
Xiang Xiao
857158451b Unify the void cast usage 
1.Remove void cast for function because many place ignore the returned value witout cast
2.Replace void cast for variable with UNUSED macro

Change-Id: Ie644129a563244a6397036789c4c3ea83c4e9b09
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
 2020-01-02 23:21:01 +08:00
Gregory Nutt
a89f0e3a07 Add missing function names in function headers. 2018-08-13 15:52:59 -06:00
Anthony Merlino
f489bcd6f9 Merged in antmerlino/apps/ftp-ipv6 (pull request #122) 
FTP: Adds support for IPv6 and fixes various transfer issues

* netutils/ftpd: Fix support for IPv6 FTP server

* netutils/ftpc:Adds support for IPv6 sockets

* ftpc: Must convert port received by EPSV reply to network order

* ftpc: Data socket address for passive connection should be same as server address

* ftpc: Must skip human readable string in EPSV response before scanning for port

* ftpc: Don't send PASS command if USER command was sufficient. ie no password required

* ftpc: Generically handle permanent negative completion in shard ftpc_cmd logic

* ftpc: Minor addresssing fix

* ftpc: Tweak logic for overriding network debugging output

* FTP: Adds option for setting stack size of various threads in FTPD and FTPC

* netutils/ftpd: Fixes build error setting IPv4 address. sin_addr => sin_addr.s_addr

* netutils/ftpd: Protects against partial write returns by looping in that case

Approved-by: Gregory Nutt <gnutt@nuttx.org>
 2017-11-06 23:41:30 +00:00
Gregory Nutt
81645fe18f strcasecmp, strncasecmp, bzero, bcmp, and bcopy should be defined in strings.h, not string.h. bzero, bcmp, and bcopy are legacy functions; the contemporary counterparts should be used instead. 2017-02-16 15:58:15 -06:00
Pierre-Noel Bouteville
4765d7baf8 fix bug un ftpd file or socket may be not closed 2016-12-04 08:39:40 -06:00
Pascal Speck
4bf63f12c3 Fixed bug that didn't free ftpd ressources on exit 2016-11-21 17:08:55 +01:00
Sebastien Lorquet
2cbad44f1d This is the Pokemon patch to change all includes fronm <apps/bla/bla.h> to "bla/bla.h" 2016-07-11 10:11:18 -06:00
Gregory Nutt
a50383db3d apps/graphics and netutils: Change some *err() message to *info() messages if what was a *dbg() message does not indicate and error condition. 2016-06-14 17:53:47 -06:00
Gregory Nutt
586b0aa7e0 Change names of *dbg() * *err() 2016-06-11 15:51:27 -06:00
Gregory Nutt
344c92e2a4 Replace all occurrences of vdbg with vinfo 2016-06-11 11:55:38 -06:00
Gregory Nutt
aacfce081e Fix several cosmetic, C coding style issues 2015-10-03 11:03:42 -06:00
Gregory Nutt
6b1d61c759 More references to avsprintf that need to be changed vasprintf 2015-09-07 17:09:11 -06:00
Gregory Nutt
55bfbed33f Fixes for more issues found by cppcheck 2014-11-25 15:26:30 -06:00
Gregory Nutt
767f1b2993 Fix netutils configuration issues: CONFIG_NETUTILS_HTTPD_SENDFILE was missing from Kconfig; CONFIG_NET_HAVE_SOLINGER should be CONFIG_NET_SOLINGER; Type of CONFIG_NET_HTTPD_MAXPATH was wrong in Kconfig file. From Max 2014-07-11 12:30:23 -06:00
Gregory Nutt
b9cf7acb1a More trailing whilespace removal 2014-04-13 16:24:28 -06:00
patacongo
bffae74f54 Remove executable property from source and make files 
git-svn-id: svn://svn.code.sf.net/p/nuttx/code/trunk@5146 42af7a65-404d-4744-a932-0658087f49c3
 2012-09-13 18:46:10 +00:00
patacongo
750f8fa70c Correct a buffer size error in the STM32 ethernet driver 
git-svn-id: svn://svn.code.sf.net/p/nuttx/code/trunk@4403 42af7a65-404d-4744-a932-0658087f49c3
 2012-02-18 22:09:09 +00:00
patacongo
ba73620d39 Correct and error in recv() and recvfrom() return value 
git-svn-id: svn://svn.code.sf.net/p/nuttx/code/trunk@4402 42af7a65-404d-4744-a932-0658087f49c3
 2012-02-18 18:13:30 +00:00
patacongo
5c75c3edeb Document recvfrom() bug 
git-svn-id: svn://svn.code.sf.net/p/nuttx/code/trunk@4399 42af7a65-404d-4744-a932-0658087f49c3
 2012-02-16 02:33:01 +00:00
patacongo
715c9987ee Fixes all known FTP server bugs 
git-svn-id: svn://svn.code.sf.net/p/nuttx/code/trunk@4398 42af7a65-404d-4744-a932-0658087f49c3
 2012-02-15 23:37:37 +00:00
patacongo
3a3ea574c4 Minor FTPD updates 
git-svn-id: svn://svn.code.sf.net/p/nuttx/code/trunk@4397 42af7a65-404d-4744-a932-0658087f49c3
 2012-02-15 22:41:17 +00:00
patacongo
96abf2590b Fix an FTPD bug 
git-svn-id: svn://svn.code.sf.net/p/nuttx/code/trunk@4378 42af7a65-404d-4744-a932-0658087f49c3
 2012-02-09 23:10:15 +00:00