1.Remove void cast for function because many place ignore the returned value witout cast
2.Replace void cast for variable with UNUSED macro
Change-Id: Ie644129a563244a6397036789c4c3ea83c4e9b09
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
apps/graphics/twm4nx: Revise logic to detect clicks on the background image. The original implementation had some side effects.
apps/graphics/twm4nx: Remove some remaining, unused stuff from TWM that was never used. Menus need to close after the 'terminal' selection is made. Otherwise, the menu can become buried under a newly open menu and not easily recovered.
apps/graphics/twm4ndx: Add a 'critical' bit to the eventID. While resizing, all events will be ignore except those marked critical.
apps/graphics/twm4nx: CBackground now brings up the main menu if the background image is click. This makes the behavior the same across all of the background except when an icon is clicked.
Squashed commit of the following:
apps/graphics/twm4nx: The calibration seems to be functional. Needs more testing.
apps/graphics/twm4nx: Extend event handling to support receiving raw, uncalibaated touchscreen inputs. This is needed for touchscreen calibration.
apps/graphics/twm4nx: Extend event handling to support shutting down of externally controlled windows. This is need to end the calibration sequence.
apps/graphics/twm4nx: CCalibration now compiles okay, but is missing event handling logic for touchscreen input and for window termination.
apps/graphics/twm4nx: Move application-related files into different directories to separate them from the core Twm4Nx files.
apps/graphics/twm4nx: A little more progress on calibration display.
app/graphics/twm4ndx: Add files that will support a calibration display. This initial commit is simply the calibration display from NxWM and is not hooked into the configuration or build systems.
apps/graphics/twm4ndx: Compile out cursor support if we are using a mouse
apps/graphics/twm4nx: Clean up some build issues.
apps/graphics/nxglyphs: Remove some warnings due to coupling with NXWM.
apps/graphics/twmndx: Separate out the main() entry point for ctwm4nx.cxx. There is functionality there that does not involve CTwm4Nx and so it is better if the main function were totally separate.
Squashed commit of the following:
apps/graphics/twm4nx: Revamp the event system to support notification of external applications when the window is being closed.
apps/graphics/twm4nx: A little NxTerm progress
apps/graphics/twm4nx: Clean up some logic associated with use of multiple Icon Managers.
apps/graphics/twm4nx: Add CNxterm to the build. It is a long way from compiling.
apps/graphics/twm4nx: This resolves the problems noted in the previous commit comments. Window events are now communicated properly to the appliation-specific event handler. Menus now seem to be receiving events and working well.
apps/graphics/twm4nx: Revamp application event handler. Better design but still crashes when a main menu entry is clicked.
apps/graphics/twm4nx: First cut at application window event distribution. Has some issues. Not ready for prime time.
apps/graphics/twm4nx: Add more controls for the events that will be generated on basic window redraw, mouse/keyboard input, and keyboard input.
apps/graphpics/twm4nx: Add a 'Desktop' item to the main menu that will iconify all windows and menus and just show the open desktop.
apps/graphics/twm4nx: Remove some unnecessary twiddling with widget settings.
apps/graphics/twm4nx: Correct an error in how menu windows are created.
apps/graphics/twm4nx: Use button array vs list box for menus.
apps/graphics/twm4nx: The Icon Manager now adds a Main Menu entry that will de-iconify the Icon Manager or raise to the top of the hieararchy if not iconfified. This is useful when there are many open windows.
apps/graphics/twm4nx: In resize operation, don't let window get narrower than the minimum toolbar width.
apps/graphics/twm4nx: Add logic so that the main menu is place at (or near) the position where the background was clicked.
apps/graphics/twm4nx: Better integrate menus and iconifiction: Bringup up a menu is like de-iconifcation, except there is no icon to be erases; taking down a menu is like iconification except that there is no icon to present.
apps/graphics/nxwidgets: Add methods to all windows to query if a window is visible or hidden.
apps/graphics/twm4nx: Use NxWidgets methods which work in all contexts instead of trying to come up with a way to know if a window is displayed through complex flags.
apps/graphics/twm4nx: Replace most usage of NUL-terminated C strings with NXWidgets::CNxString.
apps/graphics/twm4nx: Add initial support for the main menu. The main menu will come up when a left click is performed on the background. The main menu is used for starting applications. The adds the CMainMenu class that implements the main menu and an IApplication interface class the provides th template for how any external C++ application can add itself to the Main Menu.
Still missing is the logic that responds to the meny item selection and sends the event to the Main Menu as well as the logic in the Main Menu that handles the event and either brings up a sub-menu or starts and application.
Things are still basically functional after these changes, but my gut feeling is these changes added some instabilities that will need to be smoothed out.
graphics/twm4nx/src/ciconmgr.cxx: Correct initial window size and position in the upper righthand corner; Need to fill draw the button array immediately on window creation.
graphics/twm4nx/src/cwindow.cxx: Need to fill the toolbar initially with the widget background color.
apps/graphics/twm4nx: Fix various bugs found in bringup: Re-order object instantiation to account for inter-object dependencies. Correct mq_receive() buffer size. Fix a backward comparison.
apps/graphics/twm4nx: Twm4Nx debug can now be separately enabled so that it does not get overwhelmed by other graphics debug output.
apps/graphics/NxWidgets: Fix a possible deadlock condition when waiting for window geometry data that will never come. Fixed by re-requesting geometry data if we don't already have it.
apps/graphics/twm4nx: Add some debug output.
apps/graphics/twm4nx: Rethink how background events are handled.
apps/grephics/twm4nx: Expermimental organization to capture background events.
apps/graphics/twm4nx: Remove Icon Windows; replace with IconWidgets that are draw on the background.
apps/graphics/twm4nx: Add CIconWidget event generation.
apps/graphics/twm4nx: Add event handling logic to CIconWidget.
version 1.0.10 to NuttX NX windows server. No, a port is not the right
word. It is a re-design of TWM from the inside out to work with the NuttX
NX server. The name Twm4Nx reflects this legacy. But Twm4Nx is more a
homage to TWM than a port of TWM.
The original TWM was based on X11 which provides a rich set of features.
TWM provided titlebars, shaped windows, several forms of icon management,
user-defined macro functions, click-to-type and pointer-driven keyboard
focus, graphic contexts, and user-specified key and pointer button bindings,
etc.
Twm4Nx, on the other hand is based on the NuttX NX server which provides
comparatively minimal support. Additional drawing support comes from
the NuttX NxWidgets library (which necessitated the change to C++).
Twm4Nx is greatly stripped down and targeted on small embedded systems
with minimal resources. For example, no assumption is made about the
availability of a file system; no .twmrc file is used. Bitmaps are not
used (other than for fonts).
The TWM license is, I believe compatible with the BSD license used by NuttX.
The origin TWM license required notice of copyrights within each file and
a full copy of the original license which you can find in the COPYING file.
within this directory.
STATUS:
This port was brutal. Much TWM logic was removed because it depending on X11 features (or just because I could not understand how to use it). The logic is partial. A lot more needs to be done to have a complete system (hence, it is marked EXPERIMENTAL). The kinds of things that need to done are:
1. Update some logic that is only fragmentary for how like resizing, and menus.
2. Integrate NxWidgets into the windows: The resize menu needs a CLabel, the menus are CListBox'es, but not completely integrated, the Icon Manager needs to be a button array.
3. Resit Icons. They are windows now, but need to be compound widgets lying on the background.
4. Widget events are only partially integrated. A lot more needs to be done. A partial change to thoe event system that hints at the redesign is in place but it is far from complete.
