Commit Graph

64 Commits

Author SHA1 Message Date
Xiang Xiao
65a02ba9f9 system/nxplayer: Fix the compiler warning
nxplayer.c: In function 'nxplayer_playinternal':
Error: nxplayer.c:209:36: error: '%s' directive output may be truncated writing up to 99 bytes into a region of size 59 [-Werror=format-truncation=]
  209 |   snprintf(buf, sizeof(buf), "GET /%s HTTP/1.0\r\n\r\n", relurl);
      |                                    ^~                    ~~~~~~
nxplayer.c:209:3: note: 'snprintf' output between 19 and 118 bytes into a destination of size 64
  209 |   snprintf(buf, sizeof(buf), "GET /%s HTTP/1.0\r\n\r\n", relurl);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Error: nxplayer.c:1809:42: error: 'snprintf' output may be truncated before the last format character [-Werror=format-truncation=]
 1809 |       snprintf(path, sizeof(path), "%s/%s", pplayer->mediadir, pfilename);
      |                                          ^
nxplayer.c:1809:7: note: 'snprintf' output 2 or more bytes (assuming 129) into a destination of size 128
 1809 |       snprintf(path, sizeof(path), "%s/%s", pplayer->mediadir, pfilename);
      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Error: nxplayer.c:359:53: error: '%s' directive output may be truncated writing up to 128 bytes into a region of size 53 [-Werror=format-truncation=]
  359 |           snprintf(path,  sizeof(path), "/dev/audio/%s", pdevice->d_name);
      |                                                     ^~
nxplayer.c:359:11: note: 'snprintf' output between 12 and 140 bytes into a destination of size 64
  359 |           snprintf(path,  sizeof(path), "/dev/audio/%s", pdevice->d_name);
      |           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2022-03-07 00:58:19 +08:00
Petro Karashchenko
5ac15130db apps: remove space befone newline in logs
Signed-off-by: Petro Karashchenko <petro.karashchenko@gmail.com>
2021-12-27 20:52:08 -06:00
Alin Jerpelea
84e0ca1310 system: update licenses to Apache
Gregory Nutt is has submitted the SGA

Ken Pettit has submitted the ICLA

David S. Alessio has submitted the ICLA

as a result we can migrate the licenses to Apache.

Signed-off-by: Alin Jerpelea <alin.jerpelea@sony.com>
2021-06-11 02:42:05 -05:00
Xiang Xiao
213e60232f Include assert.h in necessary place
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2021-05-31 08:51:22 +02:00
Xiang Xiao
52d853e642 system/nxplayer: Fix error: 'outstanding' undeclared
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2021-03-29 01:46:29 -07:00
ligd
0e4c29be03 system/nx: update mqueue_open return value
Change-Id: Ic8d7763fa2da01312cb0e02b4aaf73893cad471a
Signed-off-by: ligd <liguiding1@xiaomi.com>
2021-01-03 21:15:00 -06:00
danguanghua
f210010466 system: enable O_CLOEXEC when openning audio device
N/A

to avoid multiple open operations of audio_open

Change-Id: Id283def4811c71f3c0bd38dc1a480afce303c4c3
Signed-off-by: danguanghua <danguanghua@xiaomi.com>
2020-12-19 07:56:18 -06:00
Xiang Xiao
16c6e1f0b8 system: nxplayer and nxrecorder shouldn't hardcode message length to 16
the audio driver may config a very large buffer count,
so let's adjust the message queue length dynamically.

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2020-12-14 16:30:11 +01:00
YAMAMOTO Takashi
ed768d1159 system/nxplayer/nxplayer.c: Fix a syslog format 2020-11-27 02:43:30 -06:00
YAMAMOTO Takashi
db07ae43ee system/nxplayer/nxplayer.c: Don't assume debug macro expansion 2020-11-27 02:43:30 -06:00
licheng
a375f64f81 nxplayer&nxrecoder: add channel map support
Change-Id: I5e5534e7330d816533a6894cf3cd8c4e19984c6f
Signed-off-by: ligd <liguiding1@xiaomi.com>
2020-09-27 00:35:49 -07:00
Masayuki Ishikawa
03c3b2ed0f system: nxplayer: Fix a compile error if CONFIG_DEBUG_AUDIO_ERROR=y
Summary:
- This commit fixes a compile error

Impact:
- Affects nxplayer with CONFIG_DEBUG_AUDIO_ERROR=y

Testing:
- Tested with spresense:rndis

Signed-off-by: Masayuki Ishikawa <Masayuki.Ishikawa@jp.sony.com>
2020-09-15 21:15:58 -07:00
Masayuki Ishikawa
2ba9fd55af system: nxplayer: Refactor nxplayer.c
NOTE: Remove redundant code regarding audio buffer configuration

Signed-off-by: Masayuki Ishikawa <Masayuki.Ishikawa@jp.sony.com>
2020-06-05 15:21:02 +08:00
Masayuki Ishikawa
8d1f2d52da system: nxplayer: Introduce max host and file name for http url
Signed-off-by: Masayuki Ishikawa <Masayuki.Ishikawa@jp.sony.com>
2020-05-21 18:48:02 +08:00
Alin Jerpelea
2749e6467b system: nxplayer & nxrecorder: nxstyle fixes
nxstyle fixes for nxplayer & nxrecorder apps

Signed-off-by: Alin Jerpelea <alin.jerpelea@sony.com>
2020-04-21 16:41:51 -06:00
Xiang Xiao
41d88f06e7 Run codespell -w with the latest dictonary again 2020-02-23 07:10:14 -06:00
Xiang Xiao
d660492289 Run codespell -w against all files
and fix the wrong correction
2020-02-22 14:41:36 -06:00
Xiang Xiao
1154735ca6 Refine the preprocess conditional guard style 2020-01-31 11:04:10 -06:00
Xiang Xiao
e0dcfa0c55 Remove extra whitespace from files (#43)
* Remove multiple newlines at the end of file
* Remove the white space from the end of line
2020-01-31 08:29:24 -06:00
Xiang Xiao
857158451b Unify the void cast usage
1.Remove void cast for function because many place ignore the returned value witout cast
2.Replace void cast for variable with UNUSED macro

Change-Id: Ie644129a563244a6397036789c4c3ea83c4e9b09
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2020-01-02 23:21:01 +08:00
qiaohaijiao
c084cd820c apps/system/nxplayer and nxrecorder: apps/nxplayer&nxrecorder: Add nuttx shell support. Use system() function to support shell command in nxplayer and nxrecorder applications. 2019-11-20 07:41:05 -06:00
Gregory Nutt
04a05b3e7b apps/system/nxplayer: Fix compile problems when audio debug is enabled. 2019-04-23 11:07:20 -06:00
Gregory Nutt
8f16bb8ebc system/nxplayer and nxrecorder: Fix some coding standard violatins that are just to in-yer-face to ignore: No CamelCase variable names. This was not an extensive check for use of CamelCase. Just some I stumbled across. 2019-02-15 19:25:01 -06:00
Michał Łyszczek
53d8cd78c0 nuttx/sched/mqueue: Change 'int prio' to 'unsigned int prio'. According to open group specification, priority field in mq_* functions should have unsigned type: http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/mqueue.h.html 2019-02-15 19:22:48 -06:00
ZhongAn
97acb41b90 system/nxplayer/nxplayer.c: Fix build error when only enable CONFIG_AUDIO_EXCLUDE_VOLUME is enabled. 2019-01-27 07:31:40 -06:00
ZhongAn
09a3bc44b4 system/nxplayer/nxplayer.c: Add playraw command 2018-08-27 08:04:48 -06:00
Xiang Xiao
7eacf7daa2 Squashed commit of the following:
apps/system/nxplayer:  Release buffer before session and release semaphore in nxplayer_setvolume

  system/nxplayer/nxplayer.c:  Remove & for apb->samp reference. It is already a pointer.
2018-08-27 07:52:04 -06:00
Xiang Xiao
5304ec5eec Replace all ASSERT calls to DEBUGASSERT 2018-08-24 06:19:35 -06:00
Masayuki Ishikawa
d9cb9175ac Merged in masayuki2009/nuttx.apps/refactor_nxplayer (pull request #149)
nxplayer: Refactor nxplayer.c

Apply netlib_parsehttpurl() and remove unnecessary usleep().

Signed-off-by: Masayuki Ishikawa <Masayuki.Ishikawa@jp.sony.com>

Approved-by: GregoryN <gnutt@nuttx.org>
2018-07-31 12:16:31 +00:00
Masayuki Ishikawa
021839224f nxplayer: Add support for http streaming in nxplayer
Signed-off-by: Masayuki Ishikawa <Masayuki.Ishikawa@jp.sony.com>
2017-12-19 15:08:29 +09:00
Masayuki Ishikawa
77ac05c383 nxplayer: Fix warnings by nxstyle
Signed-off-by: Masayuki Ishikawa <Masayuki.Ishikawa@jp.sony.com>
2017-12-19 15:08:26 +09:00
Gregory Nutt
a7f9c09a80 nxplayer: Needs to include strings.h for strcasecp() 2017-02-27 09:25:35 -06:00
Sebastien Lorquet
2cbad44f1d This is the Pokemon patch to change all includes fronm <apps/bla/bla.h> to "bla/bla.h" 2016-07-11 10:11:18 -06:00
Gregory Nutt
cd741c82cf apps/include: Move all header files associated with modules in apps/system to apps/include/system 2016-07-01 06:48:22 -06:00
Gregory Nutt
a7b1aae68c Fix some warnings 2016-06-13 12:06:44 -06:00
Gregory Nutt
586b0aa7e0 Change names of *dbg() * *err() 2016-06-11 15:51:27 -06:00
Gregory Nutt
468bdcf8e6 Rename CONFIG_DEBUG to CONFIG_DEBUG_FEATURES 2016-06-11 14:13:39 -06:00
Gregory Nutt
344c92e2a4 Replace all occurrences of vdbg with vinfo 2016-06-11 11:55:38 -06:00
Gregory Nutt
0629c5466e Standardize the width of all comment boxes in C file 2015-10-02 17:33:30 -06:00
Gregory Nutt
d01dc4fb4c Fix some warnings in audio code causing by fixing the prototypes of mq_send() and mq_receive() 2015-02-09 12:50:04 -06:00
Gregory Nutt
ecc8c70f77 Fixes for more cppcheck complaints. 2014-11-25 15:41:34 -06:00
Gregory Nutt
0975ad77aa Break reading and enqueueing of audio buffers into two steps so that errors in enqueueing can be distinguished for errors in reading. Errors in enqueueing signal a downstream decoder error. Add logic to gracefully recover from downstream decoder errors. 2014-08-05 10:04:24 -06:00
Gregory Nutt
f3bf74836c NxPlayer: Fix an error I introduced: Need to pass through final buffer even if is it zero length because it contains the end of audio stream flag 2014-08-01 07:00:02 -06:00
Gregory Nutt
2b7c476c59 Audio: Change how the end of the audio stream is detected by the leaf audio component. This used by be done by looking for the first partial buffer. That does not work with the in-place sub-sampling performed by the PCM decoder: That always reduces the size of the buffer so that all buffers only partially filled by the time they get to the leaf. Now, a flag is set in the audio buffer flags set to indicate the final buffer in the stream. 2014-07-31 16:36:09 -06:00
Gregory Nutt
cd546421d1 NxPlayer: Fix some error handling, update comments, more debug output 2014-07-31 14:59:51 -06:00
Gregory Nutt
d2b292a033 NxPlayer needs to set curbyte field to zero before enqueuing a buffer. Otherwise, it looks like beginning of the buffer has already been consumed 2014-07-27 19:49:01 -06:00
Gregory Nutt
096e8247ad First cut implementation of fast forward and rewind controls 2014-07-27 12:26:03 -06:00
Gregory Nutt
d7274845a4 Move subsampling rate definitions from nxplayer.h to audio.h 2014-07-27 11:05:25 -06:00
Gregory Nutt
12ab18cddc Trivial things from the last commit left in the editor 2014-07-24 15:10:12 -06:00
Gregory Nutt
a33d316cd3 Changes to integrate with Ken's NxWM::CMediaPlayer 2014-07-24 15:06:54 -06:00