Huang Qi
140647cf8c
Minor code style fixes
...
Fix issue in these files:
examples/flowc/flowc_mktestdata.c
examples/nxhello/nxhello_listener.c
examples/system/system_main.c
fsutils/passwd/passwd_append.c
graphics/ft80x/ft80x_gpio.c
graphics/pdcurs34/pdcurses/pdc_keyname.c
graphics/pdcurs34/pdcurses/pdc_touch.c
modbus/functions/mbfuncdiag.c
Fixed by AI and checked by manual
Signed-off-by: Huang Qi <huangqi3@xiaomi.com>
2024-09-15 02:27:41 +08:00
chao an
4d79a5cbaf
add initial cmake build system
...
Co-authored-by: Daniel Agar <daniel@agar.ca>
Signed-off-by: chao an <anchao@xiaomi.com>
2023-07-08 13:52:02 +08:00
Xiang Xiao
73701cd7cd
Replace all strncpy with strlcpy
...
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2023-05-08 21:35:16 +03:00
Junbo Zheng
78b7318a04
fsutils/passwd: fix warning: leak of ‘iobuffer’ [CWE-401] [-Wanalyzer-malloc-leak]
...
In function ‘passwd_find’:
passwd_find.c:82:14: warning: leak of ‘iobuffer’ [CWE-401] [-Wanalyzer-malloc-leak]
82 | return -errcode;
| ^~~~~~~~
‘passwd_find’: events 1-5
|
| 65 | iobuffer = (FAR char *)malloc(CONFIG_FSUTILS_PASSWD_IOBUFFER_SIZE);
| | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| | |
| | (1) allocated here
| 66 | if (iobuffer == NULL)
| | ~
| | |
| | (2) assuming ‘iobuffer’ is non-NULL
| | (3) following ‘false’ branch (when ‘iobuffer’ is non-NULL)...
|......
| 73 | stream = fopen(CONFIG_FSUTILS_PASSWD_PATH, "r");
| | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| | |
| | (4) ...to here
| 74 | if (stream == NULL)
| | ~
| | |
| | (5) following ‘true’ branch (when ‘stream’ is NULL)...
|
‘passwd_find’: event 6
|
| 80 | int errcode = errno;
| | ^~~~~
| | |
| | (6) ...to here
|
‘passwd_find’: event 7
|
| 82 | return -errcode;
| | ^~~~~~~~
| | |
| | (7) ‘iobuffer’ leaks here; was allocated at (1)
|
Signed-off-by: Junbo Zheng <zhengjunbo1@xiaomi.com>
2023-02-18 17:24:54 +08:00
Xiang Xiao
4941182cc6
Make.defs: Change "ifeq ($(XXX),y)" to "ifneq ($(XXX),)
...
to support the tristate option correctly and unify the usage
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2022-10-16 14:59:08 +02:00
Petro Karashchenko
d868387148
fsutils/passwd: fix out of bounds array access during password encryption
...
Signed-off-by: Petro Karashchenko <petro.karashchenko@gmail.com>
2022-03-28 22:11:01 +08:00
Petro Karashchenko
cfadf7b9dc
fsutils/passwd: fix compilation
...
Signed-off-by: Petro Karashchenko <petro.karashchenko@gmail.com>
2022-03-25 11:07:10 +02:00
Alin Jerpelea
f99a4f557d
fsutils: update licenses to Apache
...
Gregory Nutt is has submitted the SGA
Ken Pettit has submitted the ICLA
as a result we can migrate the licenses to Apache.
Signed-off-by: Alin Jerpelea <alin.jerpelea@sony.com>
2021-06-08 08:43:15 -05:00
Alin Jerpelea
ec339bc49a
Makefiles: Gregory Nutt: update licenses to Apache
...
Gregory Nutt is the copyright holder for those files and he has submitted the
SGA as a result we can migrate the licenses to Apache.
Signed-off-by: Alin Jerpelea <alin.jerpelea@sony.com>
2021-06-07 21:35:33 -05:00
Xiang Xiao
1ee948e0c8
Include assert.h for DEBUGASSERT caller
...
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2021-05-24 12:34:37 +09:00
Xiang Xiao
deaa6c5b7b
build: Replace $(TOPDIR)/Make.defs with $(APPDIR)/Make.defs
...
and move NUTTXLIB defintion to the common place
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2020-07-09 15:17:37 -03:00
Xiang Xiao
69f013e74e
build: Remve the unnecessary .gitignore
...
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2020-05-23 15:56:35 +01:00
Xiang Xiao
ead498a788
build: Remove the workaround for the inexistence of .config/Make.defs
...
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2020-05-21 17:43:42 +01:00
Xiang Xiao
1511403fdf
Revert "Don't generate .depend anymore"
...
This reverts commit cc5ad09caa
.
2020-03-22 23:09:40 -05:00
Xiang Xiao
cc5ad09caa
Don't generate .depend anymore
2020-03-22 18:15:21 +00:00
Gregory Nutt
da31673ddf
Run nxstyle against all modified .c and .h files
2020-03-22 08:23:28 -05:00
Gregory Nutt
1a9444a68b
Remove support for CONFIG_FS_WRITABLE and CONFIG_FS_READABLE
2020-03-22 08:23:28 -05:00
Xiang Xiao
41d88f06e7
Run codespell -w with the latest dictonary again
2020-02-23 07:10:14 -06:00
Xiang Xiao
1154735ca6
Refine the preprocess conditional guard style
2020-01-31 11:04:10 -06:00
Xiang Xiao
573f07f3e4
fix passwd.h:103:30: warning: passwd_verify with no effect [-Wunused-value]
...
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2020-01-09 07:44:21 -06:00
Xiang Xiao
857158451b
Unify the void cast usage
...
1.Remove void cast for function because many place ignore the returned value witout cast
2.Replace void cast for variable with UNUSED macro
Change-Id: Ie644129a563244a6397036789c4c3ea83c4e9b09
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2020-01-02 23:21:01 +08:00
Xiang Xiao
7808eb62d2
apps/: In all Make.def files, append to CONFIGURED_APPS patch with the absolute path.
2019-10-17 11:33:59 -06:00
Gregory Nutt
3a23523147
Makefiles: This reverts part of commit cf0365ea9
. It restores 'conditional' inclusion of TOPDIR/Make.defs. Otherwise all make targets fail if the board has not been configured. That is okay most of the time, but not for things like clean and distclean which should not depend on being configured.
2019-10-15 09:25:48 +08:00
Xiang Xiao
598420a477
fsutils/passwd/passwd_lock.c: Use named semaphore by checking CONFIG_FS_NAMED_SEMAPHORES instead of CONFIG_KERNEL_BUILD.
2019-10-04 08:49:11 -06:00
Xiang Xiao
cf0365ea92
Clean up Makefile under apps folder no functional changes.
2019-10-04 08:35:46 -06:00
Xiang Xiao
63c3772888
CONFIG_BUILD_LOADABLE: Check the kernel function callable by BUILD_KERNEL instead of BUILD_LOADABLE since BUILD_LOADABLE could be turned on even with BUILD_FLAT.
2019-10-03 14:10:32 -06:00
Gregory Nutt
735644766f
apps/fsutils/passwd: Handle the improved the format of the /etc/passwd format. It is now a little similar to other systems.
2019-08-03 10:37:27 -06:00
anchao
b5cfd93444
apps/: Modification to build system: Unified application compilation rules
2018-09-03 09:29:56 -06:00
anchao
220653f21c
Squashed commit of the following:
...
Author: anchao <anchao@pinecone.net>
apps/, most main() function: Correct CONFIG_BUILD_LOADABLE usage
Loadable apps/: Correct loadable symbol table generate
apps/system/ubloxmodem: Fix build break
apps/examples/ostest: start restart/waitpid/user test from main loop
apps/nshlib: Expand reboot and poweroff commands to include a second, optional mode argument
Author: Gregory Nutt <gnutt@nuttx.org>
An attempt to fix build issues. Does not work.
apps/examples/ostest: Fix some inappropriate renaming of static functions introduced with recent patches.
apps/builtin/exec_builtin.c: Fix a error introduced by recent comments. Found in build testing.
Author: anchao <anchao@pinecone.net>
apps/builtin/exec_builtin.c: Try posix_spawn if builtin apps do not have have an entry point.
apps/Application.mk: introduce MODULE config to simplify tristate(m)
apps/nsh: Change the nuttx shell module type to tristate
apps: Add loadable application support
script/mksymtab: Generate symbol table name by default
apps/builtin: Allow loadable applications can register with apps/builtin.
2018-08-23 11:06:15 -06:00
Gregory Nutt
2f982e9c77
Revert "Squashed commit of the following:"
...
This reverts commit 25b92edd9f
.
2018-08-22 12:06:32 -06:00
anchao
25b92edd9f
Squashed commit of the following:
...
apps/builtin/exec_builtin.c: Try posix_spawn if builtin apps do not have have an entry point.
apps/Application.mk: introduce MODULE config to simplify tristate(m)
apps/nsh: Change the nuttx shell module type to tristate
apps: Add loadable application support
script/mksymtab: Generate symbol table name by default
apps/builtin: Allow loadable applications can register with apps/builtin.
2018-08-22 09:30:38 -06:00
Dmitriy Linikov
2f2fb92ae3
Merged in hardlulz/modem-3.0-nuttx-apps/fix-sem-EINTR (pull request #133 )
...
Added ECANCELED condition to DEBUGASSERT-s checking sem_wait result
Approved-by: Gregory Nutt <gnutt@nuttx.org>
2018-02-20 18:37:32 +00:00
Gregory Nutt
928443e385
examples/ostest: sem_open() now returns SEM_FAILED in the event of a failure.
2017-09-08 10:15:46 -06:00
Gregory Nutt
7a8561728c
The last change added .PRECIOUS: $(BIN) to everyway Makefile in hopes the libapps.a will not be deleted on Control-C (unproven so far). However, $(BIN) may contain back slashes in some build platforms and that causes problems for make: It can't handle the backslashes in the .PRECIOUS dependency list. $(BIN) replaced with ../../libapp.a, where the number of ../ depends on the depth of the Makefile in the apps/ source tree.
2017-08-13 11:03:17 -06:00
Gregory Nutt
a66da34f18
All Makefiles: Add .PRECIOUS: apps/libapps.a to every Makefile. Hopefully this will end awkward problems when you Control-C out of a build and libapps.a is deleted.
2017-08-13 09:35:14 -06:00
Sebastien Lorquet
2cbad44f1d
This is the Pokemon patch to change all includes fronm <apps/bla/bla.h> to "bla/bla.h"
2016-07-11 10:11:18 -06:00
Sebastien Lorquet
bfff5e7179
Add empty preconfig rules to 'leaf' makefiles
2016-06-02 16:24:30 +02:00
Gregory Nutt
1decdb2afc
Password file is not in base64, not hex
2016-01-21 16:26:44 -06:00
Gregory Nutt
29d65eb866
apps/fsutils/passwd: Fix a few more errors found in integration
2016-01-20 14:41:27 -06:00
Gregory Nutt
681bfa2605
NSH: Add logic for the case where the passwd file is read-only. ROMFS image needs to be marked as const, or it will end up in RAM.
2016-01-20 13:05:25 -06:00
Gregory Nutt
5aa177e03b
apps/fsutils/passwd: Fix numerous errors found during testing
2016-01-20 09:36:07 -06:00
Gregory Nutt
8630130299
Remove dangle whitespace at the end of the line and some files with carriage returns in them
2016-01-19 19:22:45 -06:00
Gregory Nutt
c98e51a31d
apps/fsutils/passwd: Add a password fila management library
2016-01-19 19:19:04 -06:00