Commit Graph

583 Commits

Author SHA1 Message Date
Gregory Nutt
3e73991857 nxstyle fixes for PR 170 2020-04-11 20:32:53 +01:00
Gregory Nutt
05f2253a33 Remove CONFIG_CAN_PASS_STRUCT
This is the companion to PR #766.  It removes the CONFIG_CAN_PASS_STRUCT option as recommended by Issue #620

NuttX PR #766 depends on PR being in place but not vice versa.  This PR should be merge-able without #766 and then PR #766 should also pass its checks.
2020-04-11 20:32:53 +01:00
YAMAMOTO Takashi
3ba85167fe system/ramtest: Change the default of stack size to DEFAULT_TASK_STACKSIZE
Given what this program does, it's probably ok to allocate a few more
kilo bytes of the stack.
2020-03-27 02:43:11 -05:00
YAMAMOTO Takashi
eb083265f4 system/flash_eraseall: Bump stack size to DEFAULT_TASK_STACKSIZE 2020-03-27 02:43:11 -05:00
YAMAMOTO Takashi
2ecdf4c554 Change the default of a few stack size configs to DEFAULT_TASK_STACKSIZE
These had the larger default for the sim.
It's no longer necessary as DEFAULT_TASK_STACKSIZE
can have different default for each arch.

See also:
    commit b1d44a81b4
2020-03-27 02:43:11 -05:00
YAMAMOTO Takashi
e7156be066 Change the defaults of stack size configs to DEFAULT_TASK_STACKSIZE
This commit changes only ones with the default 2048 and
leaves the others.
E.g. this leaves SYSTEM_RAMTEST_STACKSIZE, whose default is 1024.
I guess those need to be inspected one-by-one.
2020-03-27 02:43:11 -05:00
YAMAMOTO Takashi
c304624fab Replace "STACKSIZE = 2048" with CONFIG_DEFAULT_TASK_SIZE
For now, I left the following instances because it isn't
clear to me why they are using the different values.
Maybe they need one-by-one inspection.

    examples/igmp/Makefile:STACKSIZE = 1024
    examples/powerled/Makefile:STACKSIZE = 1024
    examples/powermonitor/Makefile:STACKSIZE = 768
    examples/relays/Makefile:STACKSIZE = 512
    examples/smps/Makefile:STACKSIZE = 1024
    graphics/screenshot/Makefile:STACKSIZE = 4096
    system/flash_eraseall/Makefile:STACKSIZE = 1024
    testing/cxxtest/Makefile:STACKSIZE = 4096
    testing/smart_test/Makefile:STACKSIZE = 4096
2020-03-27 02:43:11 -05:00
Xiang Xiao
1511403fdf Revert "Don't generate .depend anymore"
This reverts commit cc5ad09caa.
2020-03-22 23:09:40 -05:00
Xiang Xiao
cc5ad09caa
Don't generate .depend anymore 2020-03-22 18:15:21 +00:00
Ouss4
7694f21292 system/cu/cu_main.c: Fix nxstyle complaints. 2020-03-13 16:36:03 -06:00
Oleg Evseev
df5d4cd033 system/cu/cu_main.c: Add option -f to loop forever. 2020-03-13 16:36:03 -06:00
Oleg Evseev
f221d33525 system/cu/cu_main.c: Fix wrongly swapped parity options. 2020-03-13 16:36:03 -06:00
Gregory Nutt
c742373efc apps/system/cle: Fix error when compiling with C89 compiler. 2020-03-13 20:14:14 +01:00
Xiang Xiao
41d88f06e7 Run codespell -w with the latest dictonary again 2020-02-23 07:10:14 -06:00
Xiang Xiao
d660492289 Run codespell -w against all files
and fix the wrong correction
2020-02-22 14:41:36 -06:00
chao.an
f28eca9dbc Make.defs: Use complete include path 2020-02-19 12:56:10 -06:00
Xiang Xiao
f14aead53e Shouldn't use local readline in telnet
Shouldn't use local readline in telnet since the host has more powerful intelligent
2020-02-08 07:58:04 -06:00
Xiang Xiao
bf3e6e2367 Improvements for telnet server
Author: Xiang Xiao <xiaoxiang@xiaomi.com>

    Check POLLHUP and POLLERR in telnet poll loop

      to handle the remote end close correctly

    Send "NVT"(network virtual terminal) as the default if getenv("TERM") return NULL

      telnet should trigger the error handling if inet_pton return zero
      since zero mean the string has format error

    Don't return 1 in _environ_telnet to avoid trigger the compression
    and remove the redundant TELNET_TELOPT_COMPRESS2 check

    Change telnet_error_u to telnet_error_e required by the coding standard

    Ensure telnet object get freed before the abnormal exit
2020-02-04 19:09:22 -03:00
Gregory Nutt
724a34bd3b Run all files modified by pr45 through nxstyle. 2020-02-03 07:38:57 -06:00
Xiang Xiao
37135e5dfe telnetd should listen both IPv4 and IPv6 for the dual stack
Change-Id: Ic1c2878f2eda721ccdf667b0a634289c643f5220
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2020-02-03 07:17:22 -06:00
Xiang Xiao
1154735ca6 Refine the preprocess conditional guard style 2020-01-31 11:04:10 -06:00
Xiang Xiao
e0dcfa0c55 Remove extra whitespace from files (#43)
* Remove multiple newlines at the end of file
* Remove the white space from the end of line
2020-01-31 08:29:24 -06:00
Satoshi Togawa
012031bc8e fix typo 2020-01-24 22:12:06 +09:00
Xiang Xiao
53efd71d6d Fix format warn (#13)
* fix warning: format '%u' expects argument of type 'unsigned int *', but argument 3 has type 'uint16_t *

Change-Id: I3eccf8e2cd917f19b7a9edab233b327297d74bb7
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>

* fix warning: format '%ld' expects argument of type 'long int', but argument 2 has type 'int'

Change-Id: Ic59a1e9e49256637fa73459c46b8cded036cf971
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2020-01-14 03:21:13 +01:00
Adam Feuer
7fd1b9065b delete all characters from char to EOL
- more like GNU readline or emacs - can delete entire line with
  ctrl-A ctrl-K
2020-01-08 15:40:04 -06:00
Alin Jerpelea
967e7e2912 system: readline: Improve security 2020-01-08 20:43:39 +08:00
Alin Jerpelea
01e2b11785 system: zmodem: Improve zmodem send performance
Introduce new configuration of CONFIG_SYSTEM_ZMODEM_SNDFILEBUF, which
allocates cache buffer for reading file to be sent. This option can
improve the performance of zmodem sending file by multiple bytes read
of file, especially when the single read of file is very slow.
2020-01-08 20:43:39 +08:00
Alin Jerpelea
221a45879d system: zmodem: Fix compile error in zmodem host tool 2020-01-08 20:43:39 +08:00
Alin Jerpelea
437dba336e system: zmodem: Fix debug assert condition 2020-01-08 20:43:39 +08:00
Alin Jerpelea
5c936ce0e4 Various fixes (#6)
Author: Gregory Nutt <gnutt@nuttx.org>

    Run all .c and .h affected by this PR through nxstyle.

Author: Alin Jerpelea <alin.jerpelea@sony.com>

    * system/usbmsc: Fix accessing uninitialized pointer
    * fsutils/inifile: Fix a memory leak in inifile error case
    * fsutils/mksmartfs: Fix uninitialized return code
    * system/zmodem: Fix a compile error in zmodem debug enabled
    * nshlib/nsh_fscmds.c: Add syntax check to cp command

    If the destication of NutShell cp command is the same with the source,
    it may cause the file corruption. Add the syntax check of argument to
    avoid this problem.
2020-01-07 09:01:23 -06:00
Xiang Xiao
857158451b Unify the void cast usage
1.Remove void cast for function because many place ignore the returned value witout cast
2.Replace void cast for variable with UNUSED macro

Change-Id: Ie644129a563244a6397036789c4c3ea83c4e9b09
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2020-01-02 23:21:01 +08:00
Gregory Nutt
3da8091d30 Include nuttx/symtab.h instead of nuttx/binfmt/symtab.h since symtab.h under binfmt folder is for internal use. 2019-12-10 08:39:22 -06:00
Xiang Xiao
7479cd6819 apps/system/nsh/nsh_main.c: Remove HAVE_DUMMY_SYMTAB logic since BINFS can run without it. 2019-12-10 08:37:58 -06:00
Gregory Nutt
9667060914 Remove apps/system/sudoku. 2019-11-25 16:14:47 -06:00
kyChu
23d2785b19 system/spi/Kconfig: Simultaneous with Dave Marples patch, kyChu submitted a nearly equivalent change with PR 206. In have enhanced Dave Marples change with some good things form kyChu's PR. 2019-11-25 07:49:31 -06:00
Dave Marples
12224806dc system/spi/Kconfig: This patch fixes a missing definition in the spitool when SPI is enabled with command/data switching. 2019-11-25 07:41:14 -06:00
Gregory Nutt
3ebf71095e Remove all support for the ancient Pascal compiler and pcode interpreter. 2019-11-21 07:04:34 -06:00
qiaohaijiao
c084cd820c apps/system/nxplayer and nxrecorder: apps/nxplayer&nxrecorder: Add nuttx shell support. Use system() function to support shell command in nxplayer and nxrecorder applications. 2019-11-20 07:41:05 -06:00
Xiang Xiao
0276088d5a apps/system/usrsock_rpmsg/usrsock_rpmsg_server.c: Fix usrsock_rpmsg_server.c:554:7: warning: 'i' may be used uninitialized in this function [-Wmaybe-uninitialized]. 2019-11-11 09:06:18 -06:00
chao.an
6bdc814836 apps/system/usrsock_rpmsg/Make.defs: Correct configured application name. 2019-11-09 10:03:24 -06:00
Jianli Dong
caecdd6079 apps/system/usrsock_rpmsg: Add rpmsg based usrsock implementation. 2019-11-08 09:32:45 -06:00
Juha Niskanen
eaeb6cc105 nshlib/Kconfig: Add missing NSH_DISABLE_DMESG, typos. 2019-11-08 07:52:22 -06:00
David Alessio
91276ba94e apps/system/cu/cu_main.c: (1) Fix early exit. getc(stdin) can return 0 the first time around. (2) Set optind to zero. getopt() was being left in a bad state, causing parsing errors on second use. (3) Fix priority of cu_listen(). (4) Add suppor for -h. 2019-11-05 07:07:02 -06:00
Dave Marples
dbd4e67241 apps/system/cle/cle.c: This commit modifies the cle to use the streams file interface more consistently and has removed the observed race conditions. It was previously a mix of streams and fileio. It also simplifies the VT100 cursor position handling. 2019-11-04 11:35:18 -06:00
David S. Alessio
e050dce32d apps/system/spi: Add options to spec devtype, id for chip select. 2019-10-18 07:43:38 -06:00
Xiang Xiao
403b4a0178 In all Make.defs files, append CONFIGURED_APPS with the consistent ifeq/ifneq. 2019-10-17 11:42:49 -06:00
Xiang Xiao
7808eb62d2 apps/: In all Make.def files, append to CONFIGURED_APPS patch with the absolute path. 2019-10-17 11:33:59 -06:00
Xiang Xiao
fa0aded666 apps/system/cle/cle.c: Fix warning, re-order to follow coding standard. 2019-10-17 11:20:20 -06:00
David Alessio
0d8ed9c0de Merged in david_alessio/apps/bugfix/spitool-exch-parse-txdata (pull request #202)
Bugfix/spitool exch parse txdata

* friendlier I2C "knock-knock" uses only read request

    While many I2C slave devices have multiple indexed registers, some have
    only one register and it's not indexed.  For example, the I2C bus switch
    TCA9548A has only a Control Register, attempting to index to "Reg[0]"
    alters its contents to 0x00 disabling all subordinate buses.  This patch
    fixes that problem by simply trying to read something/anything from the
    slave.  This also helps coax out slaves with register files that start
    from a higher index, i.e. the AT24CS0x, FLASH chips with a UUID that
    appears as a 2nd I2C slave at (address+8), report their serial number at
    Reg[80]-Reg[8F] and will NAK a read of Reg[0].

* modify get/set to prevent write of reg index if not specifed

* correctly parse exch txdata args, if any

* should always call the board's deselect

Approved-by: Gregory Nutt <gnutt@nuttx.org>
2019-10-17 14:05:44 +00:00
Gregory Nutt
3a23523147 Makefiles: This reverts part of commit cf0365ea9. It restores 'conditional' inclusion of TOPDIR/Make.defs. Otherwise all make targets fail if the board has not been configured. That is okay most of the time, but not for things like clean and distclean which should not depend on being configured. 2019-10-15 09:25:48 +08:00