The existing implementation of the termcurses_deinitterm calls
termcurses_setcolors with some hard-coded values, leading to different
terminal emulators' behavior. Instead, a reset call needs to be made to
the implementation to roll back changes.
A new operation (terminate) has been added to the termcurses_ops interface
to achieve this functionality.
The vt100's terminate implementation ensures that default foreground and
background colors are applied portably across different terminals emulators.
The `sed` command only with `-i` option has not been supported
on macOS platform, and so it causes build error on macOS.
Fix Makefile so that it passes on all platforms without using
`-i` option.
nxlooper.c: In function 'nxlooper_opendevice':
Error: nxlooper.c:126:15: error: unused variable 'x' [-Werror=unused-variable]
126 | uint8_t x;
| ^
Error: nxlooper.c:125:15: error: unused variable 'supported' [-Werror=unused-variable]
125 | uint8_t supported = true;
| ^~~~~~~~~
In file included from nxlooper.c:40:
nxlooper.c: In function 'nxlooper_loopthread':
Error: nxlooper.c:482:15: error: format '%d' expects argument of type 'int', but argument 3 has type 'ssize_t' {aka 'long int'} [-Werror=format=]
482 | audinfo("message received size %d id%d\n", size, msg.msg_id);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~
| |
| ssize_t {aka long int}
nxlooper.c:482:39: note: format string is defined here
482 | audinfo("message received size %d id%d\n", size, msg.msg_id);
| ~^
| |
| int
| %ld
cc1: all warnings being treated as errors
make[3]: *** [/github/workspace/sources/apps/Application.mk:133: nxlooper.c.github.workspace.sources.apps.system.nxlooper.o] Error 1
nxlooper_main.c: In function 'nxlooper_cmd_loopback':
Error: nxlooper_main.c:209:9: error: implicit declaration of function 'nxlooper_loopraw'; did you mean 'nxlooper_stop'? [-Werror=implicit-function-declaration]
209 | ret = nxlooper_loopraw(plooper, channels, bpsamp,
| ^~~~~~~~~~~~~~~~
| nxlooper_stop
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
N/A
Fixing "last command" misbehavior when one command in history is a
substring of another.
Signed-off-by: Peter Bee <bijunda1@xiaomi.com>
Change-Id: I1ea205e3f2461b6c2377147cb9fc878ba5b19b4f
Gregory Nutt is has submitted the SGA
Ken Pettit has submitted the ICLA
David S. Alessio has submitted the ICLA
as a result we can migrate the licenses to Apache.
Signed-off-by: Alin Jerpelea <alin.jerpelea@sony.com>
Gregory Nutt is has submitted the SGA
Ken Pettit has submitted the ICLA
as a result we can migrate the licenses to Apache.
Signed-off-by: Alin Jerpelea <alin.jerpelea@sony.com>
Gregory Nutt is has submitted the SGA
Uros Platise has submitted the ICLA
as a result we can migrate the licenses to Apache.
Signed-off-by: Alin Jerpelea <alin.jerpelea@sony.com>
Gregory Nutt is the copyright holder for those files and he has submitted the
SGA as a result we can migrate the licenses to Apache.
Signed-off-by: Alin Jerpelea <alin.jerpelea@sony.com>
This release breaks API and ABI by making use of library way
easier and more safe. No app in a nuttx tree uses psmq, so
nothing in-tree will be broken by this change.
Updated license files to Apache 2.0.
Tested on nucleo-f091
Signed-off-by: Michał Łyszczek <michal.lyszczek@bofc.pl>
Changes from v0.4.0
- add thread safety code
- add option to print function info (name) in logs
- abi/api stabilization
- bug fixes + increased reliability
Signed-off-by: Michał Łyszczek <michal.lyszczek@bofc.pl>
---
v1 -> v2 [suggested by Brennan Ashton]
- fix path to embedlog_main.c in header comment
- change license from bsd3 to apache2.0
Fix wrong dup2 return value check after:
fs: file_dup2 shouldn't hold the file list lock
1e5bfa623aa93b918566e8dc0e2f9c1a1037f45e
Fix issue in adb shell introduced in:
nsh: Pass the correct command lines to nsh_consolemain
6aca60133c
and remove 0001-feat-Switch-to-FreeBSD-getopt-library.patch
since it is already included in the new official release
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
N/A
which record and play raw data using audio subsystem
to verify audio record and playback function
Signed-off-by: danguanghua <danguanghua@xiaomi.com>
Change-Id: I2c768b8e8234a31f9622cb9955f785329cf402a5
Signed-off-by: danguanghua <danguanghua@xiaomi.com>
wget is missing from some system (like macOS and Windows native),
it's better to use curl to simplify build environment.
Signed-off-by: Huang Qi <huangqi3@xiaomi.com>
N/A
to avoid multiple open operations of audio_open
Change-Id: Id283def4811c71f3c0bd38dc1a480afce303c4c3
Signed-off-by: danguanghua <danguanghua@xiaomi.com>
the audio driver may config a very large buffer count,
so let's adjust the message queue length dynamically.
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
cfsetspeed() now stores baud rate to c_cflag member of
struct termios, so it must not be overridden later on.
Signed-off-by: Juha Niskanen <juha.niskanen@haltian.com>
option -c will disable \n -> \r\n conversion both for serial device and console if it is a tty
refactor: use only one function to set termios parameters, use termious related code and options only if CONFIG_SERIAL_TERMIOS is defined
since it is moved to the central place in nuttx side instead
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
Change-Id: I544d6110f1ca6460f7c82f970870aa9b1e7ab3dd
Adapt to the change in the main repo.
mallinfo is meant to be API compatible with Linux,
where it's provided by malloc.h.
(I think the API actually originated with System V. I don't
remember how it was there though. Anyway, I guess the
compatibility with Linux is more important than System V
these days.)
This is the companion to PR #766. It removes the CONFIG_CAN_PASS_STRUCT option as recommended by Issue #620
NuttX PR #766 depends on PR being in place but not vice versa. This PR should be merge-able without #766 and then PR #766 should also pass its checks.
These had the larger default for the sim.
It's no longer necessary as DEFAULT_TASK_STACKSIZE
can have different default for each arch.
See also:
commit b1d44a81b4
This commit changes only ones with the default 2048 and
leaves the others.
E.g. this leaves SYSTEM_RAMTEST_STACKSIZE, whose default is 1024.
I guess those need to be inspected one-by-one.
For now, I left the following instances because it isn't
clear to me why they are using the different values.
Maybe they need one-by-one inspection.
examples/igmp/Makefile:STACKSIZE = 1024
examples/powerled/Makefile:STACKSIZE = 1024
examples/powermonitor/Makefile:STACKSIZE = 768
examples/relays/Makefile:STACKSIZE = 512
examples/smps/Makefile:STACKSIZE = 1024
graphics/screenshot/Makefile:STACKSIZE = 4096
system/flash_eraseall/Makefile:STACKSIZE = 1024
testing/cxxtest/Makefile:STACKSIZE = 4096
testing/smart_test/Makefile:STACKSIZE = 4096
Author: Xiang Xiao <xiaoxiang@xiaomi.com>
Check POLLHUP and POLLERR in telnet poll loop
to handle the remote end close correctly
Send "NVT"(network virtual terminal) as the default if getenv("TERM") return NULL
telnet should trigger the error handling if inet_pton return zero
since zero mean the string has format error
Don't return 1 in _environ_telnet to avoid trigger the compression
and remove the redundant TELNET_TELOPT_COMPRESS2 check
Change telnet_error_u to telnet_error_e required by the coding standard
Ensure telnet object get freed before the abnormal exit
* fix warning: format '%u' expects argument of type 'unsigned int *', but argument 3 has type 'uint16_t *
Change-Id: I3eccf8e2cd917f19b7a9edab233b327297d74bb7
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
* fix warning: format '%ld' expects argument of type 'long int', but argument 2 has type 'int'
Change-Id: Ic59a1e9e49256637fa73459c46b8cded036cf971
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
Introduce new configuration of CONFIG_SYSTEM_ZMODEM_SNDFILEBUF, which
allocates cache buffer for reading file to be sent. This option can
improve the performance of zmodem sending file by multiple bytes read
of file, especially when the single read of file is very slow.
Author: Gregory Nutt <gnutt@nuttx.org>
Run all .c and .h affected by this PR through nxstyle.
Author: Alin Jerpelea <alin.jerpelea@sony.com>
* system/usbmsc: Fix accessing uninitialized pointer
* fsutils/inifile: Fix a memory leak in inifile error case
* fsutils/mksmartfs: Fix uninitialized return code
* system/zmodem: Fix a compile error in zmodem debug enabled
* nshlib/nsh_fscmds.c: Add syntax check to cp command
If the destication of NutShell cp command is the same with the source,
it may cause the file corruption. Add the syntax check of argument to
avoid this problem.
1.Remove void cast for function because many place ignore the returned value witout cast
2.Replace void cast for variable with UNUSED macro
Change-Id: Ie644129a563244a6397036789c4c3ea83c4e9b09
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
Bugfix/spitool exch parse txdata
* friendlier I2C "knock-knock" uses only read request
While many I2C slave devices have multiple indexed registers, some have
only one register and it's not indexed. For example, the I2C bus switch
TCA9548A has only a Control Register, attempting to index to "Reg[0]"
alters its contents to 0x00 disabling all subordinate buses. This patch
fixes that problem by simply trying to read something/anything from the
slave. This also helps coax out slaves with register files that start
from a higher index, i.e. the AT24CS0x, FLASH chips with a UUID that
appears as a 2nd I2C slave at (address+8), report their serial number at
Reg[80]-Reg[8F] and will NAK a read of Reg[0].
* modify get/set to prevent write of reg index if not specifed
* correctly parse exch txdata args, if any
* should always call the board's deselect
Approved-by: Gregory Nutt <gnutt@nuttx.org>
Feature/i2c dump
* friendlier I2C "knock-knock" uses only read request
While many I2C slave devices have multiple indexed registers, some have
only one register and it's not indexed. For example, the I2C bus switch
TCA9548A has only a Control Register, attempting to index to "Reg[0]"
alters its contents to 0x00 disabling all subordinate buses. This patch
fixes that problem by simply trying to read something/anything from the
slave. This also helps coax out slaves with register files that start
from a higher index, i.e. the AT24CS0x, FLASH chips with a UUID that
appears as a 2nd I2C slave at (address+8), report their serial number at
Reg[80]-Reg[8F] and will NAK a read of Reg[0].
* modify get/set to prevent write of reg index if not specifed
* add 'dump' command to issue a single transaction
to retrieve multiple bytes from an I2C slave and register/offset.
* use NuttX' isprint()
* refactor to reduce coupling, hexdump only needs outstream
Approved-by: Gregory Nutt <gnutt@nuttx.org>
1. Check NSH_NETINIT for self network initialization
2. Check NSH_ARCHINIT for sel arch specific initialization
3. Always show help regardless of NSH_BUILTIN_APPS
4. Loop forever regardless of NSH_BUILTIN_APPS, user could:
a.change the default behavior by the command line argument
b.or ctrl+c to break out the loop
Bugfix/i2ctool dev clobbers slave config
* friendlier I2C "knock-knock" uses only read request
While many I2C slave devices have multiple indexed registers, some have
only one register and it's not indexed. For example, the I2C bus switch
TCA9548A has only a Control Register, attempting to index to "Reg[0]"
alters its contents to 0x00 disabling all subordinate buses. This patch
fixes that problem by simply trying to read something/anything from the
slave. This also helps coax out slaves with register files that start
from a higher index, i.e. the AT24CS0x, FLASH chips with a UUID that
appears as a 2nd I2C slave at (address+8), report their serial number at
Reg[80]-Reg[8F] and will NAK a read of Reg[0].
* modify get/set to prevent write of reg index if not specifed
Approved-by: Gregory Nutt <gnutt@nuttx.org>
include/ and netutils/: Remove references to CONFIG_DISABLE_SIGNALS. Signals can no longer be disabled.
nshlib/: Remove references to CONFIG_DISABLE_SIGNALS. Signals can no longer be disabled.
system/: Remove references to CONFIG_DISABLE_SIGNALS. Signals can no longer be disabled.
testing/: Remove references to CONFIG_DISABLE_SIGNALS. Signals can no longer be disabled.
examples/: Remove references to CONFIG_DISABLE_SIGNALS. Signals can no longer be disabled.
Squashed commit of the following:
apps/nshlib: Remove NSH initialization. Now uses the common apps/netutils/netinit logic (which was cloned from nshlib to begin with).
apps/netutils/netinit: Clone network initialization logic from NSH to this directory so that it can be available for general use.
apps/system/nxplayer: Fix some logical errors from recent comments. They broke the build of the nxplayer as a library vs. a task. apps/graphics/nxglyphs: Fix yet more namespace problems.
graphics/nxwm/src/nxwm_main.cxx: Move from graphics/nxwidgets/UnitTests/nxwm/nxwm_main.cxx.
apps/graphicx/nx*: Fixes numerous build issues mostly associated with include paths and namespaces.
apps/nxglyphs: Decouple (mostly) from nxwidgets and nxwm so that they can be used elsewhere. Creates include/graphics/nxglyphs.h
apps/graphics/nxglyphs: Put all NxWidgets and NxWM glyphs into a common directory where they can eventually be shared. Not very sharable at the moment due to header file entanglements. Need a separate nxglyps.hxx header file.
Separate nxwidets and nxwm into separate directories. Remove old, common NxWidgets directory.
system/vi: Condition KEY_CMDMODE_REPEAT with CONFIG_SYSTEM_VI_INCLUDE_COMMAND_REPEAT to avoid build error when option is not selected.
Approved-by: Gregory Nutt <gnutt@nuttx.org>
c26c62e remove some code when binary logs are disabled
4c8e0df src/el-pmemory.c: fix usage of uninitialized variable
9b641a4 src/el-pmemory.c: fix wrong options object used
eb1fcb4 options: fix g_options altered after el_ocleanup
f64ec5e add: printing memory without ascii table
c16e5cd make code more c89 compatible
d0f1a54 fix: remove comma at the end of enum list
9defd3f fix bad comment
with very minor features added:
f3c138b add: option to print to stdout
d7857c4 make embedlog print to stderr by default
