Commit Graph

30 Commits

Author SHA1 Message Date
Ken Pettit
1a82551036 apps/system/vi/vi.c: Fix an infinite loop bug that can show up in some coases (plus a couple of other items). 2019-01-22 08:51:32 -06:00
Ken Pettit ‎
cc8beb8578 Bug fixes and changes to existing functionality
===============================================

1.  Deletion of last line in file using 'dd' caused infinite loop searching for
    'nextline'.  Fixed.

2.  Insertion of line above 1st line using 'O' caused line to be inserted on
    2nd line.  Fixed.

3.  Paste buffer from 'dd' was being free'd after the 'p'aste operation,
    preventing multiple paste opportunity.  Fixed.

4.  The cursor was not being bound to the line end and was allowed to 'hover'
    over the '\n' EOL character.  This caused wierd (relative to standard vi)
    insertion locations and cursor movement with 'a'ppend and 'i'nsert.  Fixed.

5.  The 'vi_shrinkpos' position didn't take the end of file pointer into
    account when calculating 'curpos', 'prevpos' variables causing wierdness
    when deleting things near the end of the file.  Fixed.

6.  The 'yy'ank command was improperly deleting the text from the document
    instead of simply yanking to the paste buffer.  Fixed.

7.  The 'dd'elete line funciton was not copying the deleted line to the paste
    buffer as part of the delete operation.  Fixed.

8.  The bottom line of the screen was sometimes being used for document text
    and other times for command / find entry.  Fixed by reserving the bottom
    the bottom line for status / command only.

9.  When scrolling up / down through a file, the cursor position was not
    preserved and moved further and further to the left column based on the
    line lengths of the lines visited.  Fixed.

10. The display was being COMPLETELY redrawn with each keystroke, causing the
    responsiveness to be imbearable.  Fixed.  Added logic to dynamicall
    indicated which portions of the screen need to be updated (full display,
    current line to end of screen, current line only, none).

11. The individual display line updates were being performed a character at
    a time by calling the vi_putch() function, causing slow performance,
    especially in telnet or USBCDC sessions where there is a lot of overhead
    per packet.  Fixed by calling vi_write() instead with a block of
    characters with breaks as needed for TAB exansion.

12. The forward delete 'x' operation allowed deletion through '\n' characters
    causing lines to be joined.  This is different from standard vi where
    'x' at the end of a line performs a delete backward operation.  Fixed.

13. When in 'ex' or find sub-modes (':' or '/' bottom line modes), hitting
    backspace with empty text did not return the operation to command mode
    like it does in standard vi.  Fixed.

14. Performing a 'find' opertation would only search from the current cursor
    position to the end of the file and did not wrap like in standard vi.
    Fixed.

15. Loading a file that was larger than the initial text allocation would
    force a call to 'vi_extendtext', marking the file as modified when in
    fact it hadn't even been loaded yet.  Fixed.

16. Combined vi_insert_mode and vi_replace_mode into a single function to
    save code space since they are nearly identical routines.

17. In command mode, backspace was deleting characters which is different
    from standard vi.  Backspace in command mode normally simply moves the
    cursor left / to the previous line.  Fixed.

18. Added code to handle boundry conditions when the file is new and
    commands are applied to an empty file.

19. Fixed vi_shrinktext so it doesn't allocate a zero-length buffer when
    the last character in the file is deleted.

20. The 'x' command was not copying to the paste buffer.  Fixed.

21. Fixed parsecolon routine to properly deal with ":wq" command sequence.

New feature additions
=====================

1.  Vi startup feature to prepend the current working directory to the
    supplied filename if it does not start with '/' absolute path specifier.
    This allows editing files in the current directory without needing to
    fully qualify the filename.

2.  Standard '~' empty screen line characters for proper identification
    of empty '\n' only lines at the end of the file.

3.  Moving into insert or append mode now prints '--INSERT--' in the status
    line and clears it upon exit.

4.  Integration with termcurses to detect special keystrokes and to
    handle terminal type differences.  Haven't yet converted all vt100 print
    codes to termcurses equivalents.

5.  Support for up, down, left, right arrows, page-up, page-down keys
    in command mode.

6.  Added 'b' command to move cursor 'b'ack to previous word.  Honors the
    command repeat value for multiple word moves.

7.  Added 'w' command to move cursor to next 'w'ord.  Honors the command
    repeat value for multiple word moves.

8.  Added 'f' and 't' commands to find characters on the current line.
    Honors the command repeat value.

9.  Added the find 'n'ext command to repeat the previous find operation.

10. Added the 'H', 'M', and 'L' commands to move the cursor to top,
    middle and bottom of the display.

11. Extended yank/paste to manage a paste buffer with character mode in
    addition to line mode.  Character mode allows cut / paste of
    individual characters or groups of characters vs. full lines.

12. Added support in the 'd'elete and 'y'ank commands for character mode
    deletions such as 'dw', 'dfa', '2yw', etc.

13. Added support in paste routine for multiple paste using command value
    argument.

14. Added support for the 'D' and 'C' delete and change to end of line
    commands.

15. Added support for 's'ubstitute key ('x' followed by insert mode).

16. Modified yank / paste allocation scheme to avoid repeated alloc
    and free of paste buffer.  Uses a minimum allocation size scheme and
    only does free / realloc when paste does not fit.  If the paste is
    smaller than the current allocation and the current allocation is
    larger than the threshold, then the buffer is freed and a smaller
    buffer allocated.  Otherwise the existing buffer is used.

17. Support for 'P'aste before current cursor position.

18. Support for '?' reverse search mode.

19. Support for 'J'oin next line with current line command.

20. Printing of current row,col in status line of display.

21. Command repeat '.' support for commands that modifiy text.

22. Support in replace  / insert mode for arrow keys, PGUP / PGDN, HOME,
    and END.  Using these will cause the command repeat buffer to
    reset such that only the last text addition after a cursor movement
    is saved.

23. Added 'X' delete previous command.

24. Added "gg" go to top of document command sequence.

25. Added "ZZ" save and quit command (equivalent to :wq).

26. Implemented '^' goto first non-whitespace on current line, along
    with '+' and '-' goto first non-whitespace on next / previous line.

27. Added CR / LF goto first non-whitespace on next line in command mode.
2019-01-16 19:25:04 -06:00
anchao
42ce384259 apps/system/vi/vi.c: Do not print error if the file does not exist. 2018-11-07 11:43:04 -06:00
anchao
b5cfd93444 apps/: Modification to build system: Unified application compilation rules 2018-09-03 09:29:56 -06:00
anchao
220653f21c Squashed commit of the following:
Author: anchao <anchao@pinecone.net>

     apps/, most main() function: Correct CONFIG_BUILD_LOADABLE usage
     Loadable apps/: Correct loadable symbol table generate
     apps/system/ubloxmodem:  Fix build break
     apps/examples/ostest: start restart/waitpid/user test from main loop
     apps/nshlib:  Expand reboot and poweroff commands to include a second, optional mode argument

    Author: Gregory Nutt <gnutt@nuttx.org>

     An attempt to fix build issues.  Does not work.
     apps/examples/ostest:  Fix some inappropriate renaming of static functions introduced with recent patches.
     apps/builtin/exec_builtin.c:  Fix a error introduced by recent comments.  Found in build testing.

    Author: anchao <anchao@pinecone.net>

     apps/builtin/exec_builtin.c:  Try posix_spawn if builtin apps do not have have an entry point.
     apps/Application.mk: introduce MODULE config to simplify tristate(m)
     apps/nsh:  Change the nuttx shell module type to tristate
     apps:  Add loadable application support
     script/mksymtab:  Generate symbol table name by default
     apps/builtin:  Allow loadable applications can register with apps/builtin.
2018-08-23 11:06:15 -06:00
Gregory Nutt
2f982e9c77 Revert "Squashed commit of the following:"
This reverts commit 25b92edd9f.
2018-08-22 12:06:32 -06:00
anchao
25b92edd9f Squashed commit of the following:
apps/builtin/exec_builtin.c:  Try posix_spawn if builtin apps do not have have an entry point.
    apps/Application.mk: introduce MODULE config to simplify tristate(m)
    apps/nsh:  Change the nuttx shell module type to tristate
    apps:  Add loadable application support
    script/mksymtab:  Generate symbol table name by default
    apps/builtin:  Allow loadable applications can register with apps/builtin.
2018-08-22 09:30:38 -06:00
Gregory Nutt
a89f0e3a07 Add missing function names in function headers. 2018-08-13 15:52:59 -06:00
Gregory Nutt
13911d9b17 Fix lots of occurrences of 'the the', 'the there', 'the these', 'the then', 'the they. 2017-05-11 13:40:03 -06:00
Gregory Nutt
344c92e2a4 Replace all occurrences of vdbg with vinfo 2016-06-11 11:55:38 -06:00
Gregory Nutt
b2c867f214 More ccpcheck-related fixes 2014-11-25 17:28:22 -06:00
Gregory Nutt
ecc8c70f77 Fixes for more cppcheck complaints. 2014-11-25 15:41:34 -06:00
Gregory Nutt
2719815dd9 Update everything under apps/ to use the corrected syslog interfaces 2014-10-08 11:34:22 -06:00
Gregory Nutt
d8a239d649 Use more standard *argv[] instead easier **argv 2014-09-06 09:23:23 -06:00
Gregory Nutt
9f7c9b273f With kernel build, entry point to all tasks is main, not some xyz_main 2014-09-06 09:19:15 -06:00
Gregory Nutt
2b0f1ed109 Change all variadic macros to C99 style 2014-05-22 09:01:51 -06:00
Gregory Nutt
55ea1ef68e VI and CLE: Fix lots of typos in comments 2014-02-02 16:13:40 -06:00
Gregory Nutt
551e49dfec VI: cosmetic updates to comments 2014-02-01 16:30:38 -06:00
Gregory Nutt
bda5da38ce vi: Add missing BSD header 2014-01-31 07:13:51 -06:00
Gregory Nutt
4986c865b6 VI: Finally test vi file-related command, fixed bugs, and add file read command 2014-01-30 18:59:43 -06:00
Gregory Nutt
971d01ce81 VI: Fix loss of status line on display update 2014-01-21 11:49:37 -06:00
Gregory Nutt
c21071dfd3 VI: all commands not seem functional. Still at least on display artifact and probably some things not properly tested 2014-01-21 11:29:49 -06:00
Gregory Nutt
aadd63c7e7 VI: Several bug fixes 2014-01-21 09:57:43 -06:00
Gregory Nutt
c873c4b3f2 VI: Turn off cursor when updating screen; eliminate some warnings 2014-01-21 08:02:38 -06:00
Gregory Nutt
f4343e59aa VI: Send the BEL character on errors to make a noise on errors 2014-01-20 20:03:58 -06:00
Gregory Nutt
5f43b6c815 VI: Display origin for VT100 is (1,1), not (0,0) 2014-01-20 19:32:30 -06:00
Gregory Nutt
eefd9df8f5 VI: Fix some display and cursor position bugs... still plenty of bugs 2014-01-20 17:53:11 -06:00
Gregory Nutt
66d58428e0 Fix formatting of the VT100 escapte sequence 2014-01-20 16:58:14 -06:00
Gregory Nutt
1b37cdf95a VI: Add some debug instrumentation 2014-01-20 14:50:54 -06:00
Gregory Nutt
e5a0a2fafb apps/system/vi: Add new tiny VI work-alike editor. Still a work in progress. 2014-01-20 13:17:21 -06:00