Commit Graph

19 Commits

Author SHA1 Message Date
Xiang Xiao
8fd8aad5c4 Fix nxstyle warning
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2020-04-13 08:32:42 -06:00
Xiang Xiao
5720d72b71 apps: Fix the nightly build warning
src/cwindowfactory.cxx: In member function 'void Twm4Nx::CWindowFactory::redrawIcons(const nxgl_rect_s*)':
src/cwindowfactory.cxx:461:38: warning: 'iconPos.nxgl_point_s::y' may be used uninitialized in this function [-Wmaybe-uninitialized]
  461 |           iconBounds.pt2.y = iconPos.y + iconSize.h - 1;
      |                              ~~~~~~~~^
src/cwindowfactory.cxx:460:38: warning: 'iconPos.nxgl_point_s::x' may be used uninitialized in this function [-Wmaybe-uninitialized]
  460 |           iconBounds.pt2.x = iconPos.x + iconSize.w - 1;
      |                              ~~~~~~~~^

nsh_netcmds.c:424:20: warning: 'nsh_addrconv' defined but not used [-Wunused-function]
 static inline bool nsh_addrconv(FAR const char *hwstr,
                    ^
nsh_netcmds.c:446:20: warning: 'nsh_sethwaddr' defined but not used [-Wunused-function]
 static inline void nsh_sethwaddr(FAR const char *ifname,
                    ^

nsh_envcmds.c:94:21: warning: 'nsh_getdirpath' defined but not used [-Wunused-function]
 static inline char *nsh_getdirpath(FAR struct nsh_vtbl_s *vtbl,
                     ^

In file included from bas.c:84:0:
bas.c: In function 'bas_interpreter':
bas_error.h:110:37: warning: left-hand operand of comma expression has no effect [-Wunused-value]
 #define NOSUCHLINE         STATIC+40, _("No such line")
                                     ^
bas.c:2425:52: note: in expansion of macro 'NOSUCHLINE'
                           FS_putChars(STDCHANNEL, (NOSUCHLINE));
                                                    ^~~~~~~~~~
bas_fs.c:107:22: warning: 'g_vt100_colormap' defined but not used [-Wunused-const-variable=]
 static const uint8_t g_vt100_colormap[8] =
                      ^~~~~~~~~~~~~~~~
<stdout>:4048:16: warning: 'input' defined but not used [-Wunused-function]

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
Change-Id: I62610b4c90e67637250cbd0107c2935c8abc542f
2020-04-13 08:32:42 -06:00
Xiang Xiao
857158451b Unify the void cast usage
1.Remove void cast for function because many place ignore the returned value witout cast
2.Replace void cast for variable with UNUSED macro

Change-Id: Ie644129a563244a6397036789c4c3ea83c4e9b09
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2020-01-02 23:21:01 +08:00
Gregory Nutt
81645fe18f strcasecmp, strncasecmp, bzero, bcmp, and bcopy should be defined in strings.h, not string.h. bzero, bcmp, and bcopy are legacy functions; the contemporary counterparts should be used instead. 2017-02-16 15:58:15 -06:00
Gregory Nutt
e82a54bf18 Reserver the name 'err' for other purposes 2016-06-11 14:49:55 -06:00
Gregory Nutt
4db4ea2bbd Rename all C files in apps/interpreters/bas to begin with bas_ in order to avoid future name collisions in libapps.a 2014-11-11 12:34:00 -06:00
Gregory Nutt
894c32d306 BAS: output a new line when terminating to separate the last BAS output from the NSH prompt 2014-11-09 17:14:15 -06:00
Gregory Nutt
799de0c6b5 BAS: More name compatibility changes 2014-11-08 11:47:35 -06:00
Gregory Nutt
6e013e76fc More global variable name changes for NuttX coding standards compatibility. Make sure that g_bas_end is initially false 2014-11-08 11:23:13 -06:00
Gregory Nutt
021de85bfe BAS: Fix another case were allocated pointer not being nullified and, hence, crashing the next time referenced after restarting BAS. Also bring even more global varialbles and type names into NuttX coding standard 2014-11-08 09:08:20 -06:00
Gregory Nutt
e68498d04f BAS: Another file is close to the NuttX C coding style 2014-11-04 15:17:05 -06:00
Gregory Nutt
fc7d564ec3 BAS: Another file is closer to the NuttX coding style 2014-11-04 13:35:56 -06:00
Gregory Nutt
d7eaa25129 BAS: Remove config.h and INSTALL files. Add config options to Kconfig 2014-11-03 09:11:25 -06:00
Gregory Nutt
3b4976559e Remove dependencies on environ, fstat, GETTEXt, TERMCAP, ncurse, syscfg 2014-11-03 08:33:39 -06:00
Gregory Nutt
abf3770bb2 Remove dependencies on TGETENT, SIGINT, SIGKILL, and most terminal configuration logic. 2014-11-03 08:19:14 -06:00
Gregory Nutt
d18e4bb3ff BAS: Another file is closer to the NuttX coding style 2014-11-02 13:32:30 -06:00
Gregory Nutt
1655c81df0 BAS: Another file is closer to the coding style 2014-11-02 12:58:30 -06:00
Gregory Nutt
02b974859c A few baby steps toward getting closer to the coding standard 2014-11-01 18:06:28 -06:00
Gregory Nutt
5167631d29 Port of BAS 2.4 to NuttX by Alan Carvalho de Assis 2014-10-27 07:53:12 -06:00