Commit Graph

4724 Commits

Author SHA1 Message Date
Xiang Xiao
5720d72b71 apps: Fix the nightly build warning
src/cwindowfactory.cxx: In member function 'void Twm4Nx::CWindowFactory::redrawIcons(const nxgl_rect_s*)':
src/cwindowfactory.cxx:461:38: warning: 'iconPos.nxgl_point_s::y' may be used uninitialized in this function [-Wmaybe-uninitialized]
  461 |           iconBounds.pt2.y = iconPos.y + iconSize.h - 1;
      |                              ~~~~~~~~^
src/cwindowfactory.cxx:460:38: warning: 'iconPos.nxgl_point_s::x' may be used uninitialized in this function [-Wmaybe-uninitialized]
  460 |           iconBounds.pt2.x = iconPos.x + iconSize.w - 1;
      |                              ~~~~~~~~^

nsh_netcmds.c:424:20: warning: 'nsh_addrconv' defined but not used [-Wunused-function]
 static inline bool nsh_addrconv(FAR const char *hwstr,
                    ^
nsh_netcmds.c:446:20: warning: 'nsh_sethwaddr' defined but not used [-Wunused-function]
 static inline void nsh_sethwaddr(FAR const char *ifname,
                    ^

nsh_envcmds.c:94:21: warning: 'nsh_getdirpath' defined but not used [-Wunused-function]
 static inline char *nsh_getdirpath(FAR struct nsh_vtbl_s *vtbl,
                     ^

In file included from bas.c:84:0:
bas.c: In function 'bas_interpreter':
bas_error.h:110:37: warning: left-hand operand of comma expression has no effect [-Wunused-value]
 #define NOSUCHLINE         STATIC+40, _("No such line")
                                     ^
bas.c:2425:52: note: in expansion of macro 'NOSUCHLINE'
                           FS_putChars(STDCHANNEL, (NOSUCHLINE));
                                                    ^~~~~~~~~~
bas_fs.c:107:22: warning: 'g_vt100_colormap' defined but not used [-Wunused-const-variable=]
 static const uint8_t g_vt100_colormap[8] =
                      ^~~~~~~~~~~~~~~~
<stdout>:4048:16: warning: 'input' defined but not used [-Wunused-function]

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
Change-Id: I62610b4c90e67637250cbd0107c2935c8abc542f
2020-04-13 08:32:42 -06:00
Gregory Nutt
58085e5983 Run nxstyle against files modified in previous commit. 2020-04-12 19:17:49 +01:00
Gregory Nutt
f95d753759 Fix warnings noted in PR build checks.
userfs_main.c:547:7: warning: variable 'ret' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
      if (*relpath == '\0')
          ^~~~~~~~~~~~~~~~
    userfs_main.c:564:10: note: uninitialized use occurs here
      return ret;
             ^~~
    userfs_main.c:547:3: note: remove the 'if' if its condition is always false
      if (*relpath == '\0')
      ^~~~~~~~~~~~~~~~~~~~~
    userfs_main.c:543:10: note: initialize the variable 'ret' to silence this warning
      int ret;
             ^
              = 0

    test_motor.c:1068:14: warning: explicitly assigning value of variable of type 'float' to itself [-Wself-assign]
      expected_e = expected_e;
      ~~~~~~~~~~ ^ ~~~~~~~~~~
2020-04-12 19:17:49 +01:00
Gregory Nutt
3e73991857 nxstyle fixes for PR 170 2020-04-11 20:32:53 +01:00
Gregory Nutt
05f2253a33 Remove CONFIG_CAN_PASS_STRUCT
This is the companion to PR #766.  It removes the CONFIG_CAN_PASS_STRUCT option as recommended by Issue #620

NuttX PR #766 depends on PR being in place but not vice versa.  This PR should be merge-able without #766 and then PR #766 should also pass its checks.
2020-04-11 20:32:53 +01:00
Xiang Xiao
95efbf7e62 netlib: fix nxstyle issue for netlink related code
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2020-04-10 09:22:08 -06:00
Xiang Xiao
63157f3a4d nshlib: use rtgenmsg for netlib_get_arptable/netlib_get_nbtable lik Linux
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
Change-Id: I0b28eea6a70d0b5f6c5beef26f6624edfb3d6c86
2020-04-10 09:22:08 -06:00
Xiang Xiao
300bc2729a netlib: correct netlink usage to follow Linux convention
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
Change-Id: Iae98b0a008dc42dddb77f47d79511ae4fb4bbfca
2020-04-10 09:22:08 -06:00
Xiang Xiao
f5ea28e9ad netlib: Remove AF_FAMILY and PF_FAMILY definition
use the common one(NETLIB_SOCK_FAMILY)

Change-Id: Ifc255f82f169d3bb37604c49006361a40c9933d1
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2020-04-09 07:36:19 -06:00
YAMAMOTO Takashi
3b1b5648d2 CI: Add macOS builds
This is a sync from testing repo.
2020-04-09 20:01:57 +08:00
Brennan Ashton
6e02a2b20a Include some missing entries from the LICENSE file
Signed-off-by: Brennan Ashton <bashton@brennanashton.com>
2020-04-09 20:01:38 +08:00
YAMAMOTO Takashi
6e96e54b6b CI: sync with testing repo
Namely the following commit:

    commit 29f2116356451ee3430332df28b953f76da2d284
    Author: YAMAMOTO Takashi <yamamoto@midokura.com>
    Date:   Fri Apr 3 13:56:42 2020 +0900

        Use testbuild -G ("git clean" instead of "make distclean")
2020-04-08 22:09:05 -07:00
chao.an
c6b678fa60 netutils/dhcpc: fix nxstyle warning
Signed-off-by: chao.an <anchao@xiaomi.com>
2020-04-03 18:11:27 -06:00
chao.an
70bb13ce3b netutils/dhcpc: configurable timeout and retry count.
Change-Id: I92e77bd24ddd7ffff39de9215f4b7c05a7b55bee
Signed-off-by: chao.an <anchao@xiaomi.com>
2020-04-03 18:11:27 -06:00
Ouss4
d7df165c45 examples/udp: When a host PC is used, take its implementation of hton/ntoh functions. 2020-04-03 18:09:02 -06:00
raiden00pl
dd95e35787 examples/dsptest: fix nxstyle issues 2020-04-03 22:23:23 +01:00
chao.an
7cb5bc3b76 wapi: fix nxstyle warning
Signed-off-by: chao.an <anchao@xiaomi.com>
2020-04-03 13:29:19 +01:00
chao.an
6ab29d4ffb wapi: skip associate if ssid is invalid
Signed-off-by: chao.an <anchao@xiaomi.com>
2020-04-03 13:29:19 +01:00
chao.an
df1d0e73f8 wireless/wapi: add save_config/reconnect support
Signed-off-by: chao.an <anchao@xiaomi.com>
2020-04-03 13:29:19 +01:00
chao.an
6bafe90db4 wireless/wapi: independent scan and scan_results
add scan <ssid> support

Signed-off-by: chao.an <anchao@xiaomi.com>
2020-04-03 13:29:19 +01:00
liuhaitao
7c8c30537f CI: remove the additional pull docker container step
There is chance pull docker container failure in build jobs,
remove the additional pull docker container step may make it
more stable. Meanwhile, it also saves some time for build job.

Signed-off-by: liuhaitao <liuhaitao@xiaomi.com>
2020-04-03 19:20:00 +08:00
archer
52abe148ce
netutils/base64: correct the buffer type 2020-04-03 11:16:12 +01:00
chao.an
9968461c2b nsh/command: do not show the module application in built-in list
Change-Id: Ia6dd5dcf7d7eb829fde67c522f7ee2155a4051ce
Signed-off-by: chao.an <anchao@xiaomi.com>
2020-04-03 15:59:45 +09:00
YAMAMOTO Takashi
97b439f180 examples/udp: Avoid using non-standard s6_addr16
Also, fixes endian issues.
2020-04-02 11:39:59 +01:00
YAMAMOTO Takashi
d5ec9f91ae examples/udp: Avoid common symbols 2020-04-02 11:39:59 +01:00
YAMAMOTO Takashi
d55401d3fc examples/udp: Avoid conflicts with host OS definitions 2020-04-02 11:39:59 +01:00
YAMAMOTO Takashi
d79de16657 examples/udp: Appease nxstyle errors 2020-04-02 11:39:59 +01:00
liuhaitao
0640e072b0 CI: update matrix boards accordingly since testlist updated
Signed-off-by: liuhaitao <liuhaitao@xiaomi.com>
2020-04-01 14:44:02 +08:00
Xiang Xiao
595c72b38e
ping/ping6: Support the dual stack host correctly 2020-03-31 22:18:26 +01:00
YAMAMOTO Takashi
de25bfecf3 CI: Change the workflow name for build.yml 2020-04-01 00:10:36 +08:00
YAMAMOTO Takashi
405efe0897 CI: rename main.yml to build.yml 2020-04-01 00:10:36 +08:00
YAMAMOTO Takashi
1bfffc73ec CI: Use actions from testing repo 2020-04-01 00:10:36 +08:00
YAMAMOTO Takashi
2884f021dc main.yml: Reduce differences from other repos 2020-04-01 00:10:36 +08:00
YAMAMOTO Takashi
e6607179f8 CI: Separate the workflow into a few pieces 2020-04-01 00:10:36 +08:00
Ouss4
5e245cf34b examples/tcpblaster: When a host PC is used, take its implementation of hton/ntoh functions. 2020-03-31 14:35:57 +08:00
Xiang Xiao
b92a10ad74 nshlib/nsh_netcmds.c: fix nxstyle warning
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2020-03-30 09:43:49 -06:00
Xiang Xiao
8da81578b0 nsh: Call getaddrinfo in cmd_nslookup to support the dual stack host
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
Change-Id: Iac7a9a6b871d473e4720db1d6cbfeea3dc9796a0
2020-03-30 09:43:49 -06:00
YAMAMOTO Takashi
326c80db72 tcpblaster: Appease nxstyle complaints 2020-03-30 02:12:02 -05:00
YAMAMOTO Takashi
7e6e19d80c tcpblaster: Fix build on macOS
s6_addr is in standard. s6_addr16 is not.
See RFC 2553.
2020-03-30 02:12:02 -05:00
YAMAMOTO Takashi
5f91364d44 tcpblaster: Avoid conflicting with host OS definitions 2020-03-30 02:12:02 -05:00
YAMAMOTO Takashi
e8b0c903bc examples/udpblaster: Fix some nxstyle errors 2020-03-28 11:56:44 -05:00
YAMAMOTO Takashi
60378318d3 udpblaster: Fix build on macOS
s6_addr is in standard. s6_addr16 is not.
See RFC 2553.
2020-03-28 11:56:44 -05:00
liuhaitao
5c9df7bc7a Use new docker image container and add xtensa arch build support
Signed-off-by: liuhaitao <liuhaitao@xiaomi.com>
2020-03-28 11:37:44 -05:00
YAMAMOTO Takashi
4ac7744c2e Appease nxstyle complaints 2020-03-28 10:21:48 -05:00
YAMAMOTO Takashi
cf30257f1c examples/udpblaster: Avoid conflicts with host OS definitions 2020-03-28 10:21:48 -05:00
YAMAMOTO Takashi
3ba85167fe system/ramtest: Change the default of stack size to DEFAULT_TASK_STACKSIZE
Given what this program does, it's probably ok to allocate a few more
kilo bytes of the stack.
2020-03-27 02:43:11 -05:00
YAMAMOTO Takashi
eb083265f4 system/flash_eraseall: Bump stack size to DEFAULT_TASK_STACKSIZE 2020-03-27 02:43:11 -05:00
YAMAMOTO Takashi
c9c1d2bbc6 Change the default of stack size configs to DEFAULT_TASK_STACKSIZE
Where:
 * Under examples and testing
 * And the default value is less than 2048

Using a bit more memory for examples and tests should not
be a critical problem.
2020-03-27 02:43:11 -05:00
YAMAMOTO Takashi
35933d8131 examples: Replace hardcoded stack sizes to DEFAULT_TASK_STACKSIZE
Where the hardcoded values are less than 2048.
Using a bit more memory for examples should not be a critical problem.
2020-03-27 02:43:11 -05:00
YAMAMOTO Takashi
2ecdf4c554 Change the default of a few stack size configs to DEFAULT_TASK_STACKSIZE
These had the larger default for the sim.
It's no longer necessary as DEFAULT_TASK_STACKSIZE
can have different default for each arch.

See also:
    commit b1d44a81b450a23511dcbd31b783fe2cf4a935f9
2020-03-27 02:43:11 -05:00