sergiotarxz/nuttx-apps
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
5,326 Commits 1 Branch 0 Tags 24 MiB
be14592e84
Commit Graph

821 Commits

Author SHA1 Message Date
Xiang Xiao
9ab5e2ff45 nshlib: Add login argument to nsh_session for controling the login process 
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
 2020-04-19 08:07:06 -06:00
Xiang Xiao
9dbdc73df6 nshlib: Reset NSH_NP_SET_OPTIONS_INIT in nsh_initscript 
to ensure the reset get executed in all console implementation

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
 2020-04-19 08:07:06 -06:00
Xiang Xiao
ac5632fc50 nshlib: Move BOARDIOC_FINALINIT into nsh_initscript 
1.Avoid the code duplication
2.Call BOARDIOC_FINALINIT onnce and only once
3.Ensure BOARDIOC_FINALINIT get called in all case

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
 2020-04-19 08:07:06 -06:00
Xiang Xiao
6c4dc44e04 nshlib: Ensure nsh_initscript always follow usbtrace_enable immediately 
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
 2020-04-19 08:07:06 -06:00
chao.an
4adb83c754 nshlib: remove the dependency of date on RTC 
Change-Id: I98bd022fdc901ecb4e2e45a0faf779d83c260844
Signed-off-by: chao.an <anchao@xiaomi.com>
 2020-04-18 07:35:40 -06:00
Alan C. Assis
6e403fc343 Fix remaining issues with nxstyle 2020-04-16 20:39:47 -06:00
Alan C. Assis
d10eb2ae3a Fix nxstyle issue for Juha patch 2020-04-16 20:39:47 -06:00
Juha Niskanen
89b981bdb6 nshlib/nsh_codeccmd.c: fix potential NULL dereference and check malloc return values 2020-04-16 20:39:47 -06:00
Xiang Xiao
8fd8aad5c4 Fix nxstyle warning 
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
 2020-04-13 08:32:42 -06:00
Xiang Xiao
5720d72b71 apps: Fix the nightly build warning 
src/cwindowfactory.cxx: In member function 'void Twm4Nx::CWindowFactory::redrawIcons(const nxgl_rect_s*)':
src/cwindowfactory.cxx:461:38: warning: 'iconPos.nxgl_point_s::y' may be used uninitialized in this function [-Wmaybe-uninitialized]
  461 |           iconBounds.pt2.y = iconPos.y + iconSize.h - 1;
      |                              ~~~~~~~~^
src/cwindowfactory.cxx:460:38: warning: 'iconPos.nxgl_point_s::x' may be used uninitialized in this function [-Wmaybe-uninitialized]
  460 |           iconBounds.pt2.x = iconPos.x + iconSize.w - 1;
      |                              ~~~~~~~~^

nsh_netcmds.c:424:20: warning: 'nsh_addrconv' defined but not used [-Wunused-function]
 static inline bool nsh_addrconv(FAR const char *hwstr,
                    ^
nsh_netcmds.c:446:20: warning: 'nsh_sethwaddr' defined but not used [-Wunused-function]
 static inline void nsh_sethwaddr(FAR const char *ifname,
                    ^

nsh_envcmds.c:94:21: warning: 'nsh_getdirpath' defined but not used [-Wunused-function]
 static inline char *nsh_getdirpath(FAR struct nsh_vtbl_s *vtbl,
                     ^

In file included from bas.c:84:0:
bas.c: In function 'bas_interpreter':
bas_error.h:110:37: warning: left-hand operand of comma expression has no effect [-Wunused-value]
 #define NOSUCHLINE         STATIC+40, _("No such line")
                                     ^
bas.c:2425:52: note: in expansion of macro 'NOSUCHLINE'
                           FS_putChars(STDCHANNEL, (NOSUCHLINE));
                                                    ^~~~~~~~~~
bas_fs.c:107:22: warning: 'g_vt100_colormap' defined but not used [-Wunused-const-variable=]
 static const uint8_t g_vt100_colormap[8] =
                      ^~~~~~~~~~~~~~~~
<stdout>:4048:16: warning: 'input' defined but not used [-Wunused-function]

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
Change-Id: I62610b4c90e67637250cbd0107c2935c8abc542f
 2020-04-13 08:32:42 -06:00
chao.an
9968461c2b nsh/command: do not show the module application in built-in list 
Change-Id: Ia6dd5dcf7d7eb829fde67c522f7ee2155a4051ce
Signed-off-by: chao.an <anchao@xiaomi.com>
 2020-04-03 15:59:45 +09:00
Xiang Xiao
b92a10ad74 nshlib/nsh_netcmds.c: fix nxstyle warning 
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
 2020-03-30 09:43:49 -06:00
Xiang Xiao
8da81578b0 nsh: Call getaddrinfo in cmd_nslookup to support the dual stack host 
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
Change-Id: Iac7a9a6b871d473e4720db1d6cbfeea3dc9796a0
 2020-03-30 09:43:49 -06:00
YAMAMOTO Takashi
e7156be066 Change the defaults of stack size configs to DEFAULT_TASK_STACKSIZE 
This commit changes only ones with the default 2048 and
leaves the others.
E.g. this leaves SYSTEM_RAMTEST_STACKSIZE, whose default is 1024.
I guess those need to be inspected one-by-one.
 2020-03-27 02:43:11 -05:00
Xiang Xiao
1511403fdf Revert "Don't generate .depend anymore" 
This reverts commit cc5ad09caa.
 2020-03-22 23:09:40 -05:00
Xiang Xiao
cc5ad09caa
Don't generate .depend anymore 2020-03-22 18:15:21 +00:00
Gregory Nutt
da31673ddf Run nxstyle against all modified .c and .h files 2020-03-22 08:23:28 -05:00
Gregory Nutt
1a9444a68b Remove support for CONFIG_FS_WRITABLE and CONFIG_FS_READABLE 2020-03-22 08:23:28 -05:00
YAMAMOTO Takashi
e1d9e82273 nshlib: Fix a few strange whitespace in command help text 2020-03-18 00:39:17 -05:00
YAMAMOTO Takashi
382284b43c nsh_dbgcmds.c: Appease nxstyle complaints 2020-03-17 21:45:37 -06:00
YAMAMOTO Takashi
2b47187a83 nsh_command.c: Appease nxstyle complaints 2020-03-17 21:45:37 -06:00
Xiang Xiao
5f273b2c5c nshlib: cmd_nfsmount support the mount with TCP protocol 
And make TCP as the default like Linux
 2020-02-27 12:53:54 -06:00
Xiang Xiao
26a5fb0e74 nshlib: cmd_nfsmount support the mount through domain name 
Change-Id: I9e4bfd6aee9ac4bd625e3bc66b6e196b013ca172
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
 2020-02-27 12:49:54 -06:00
Xiang Xiao
11fedb6b95 nshlib: cmd_nfsmount should try IPv6 then IPv4 if dual stack is enabled 
Change-Id: I0126a97a74008a860beeff363090ee6933286d45
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
 2020-02-27 12:49:54 -06:00
chao.an
86bfe13399 net/bringup: late net init after nsh script done 2020-02-26 16:11:44 +00:00
Xiang Xiao
41d88f06e7 Run codespell -w with the latest dictonary again 2020-02-23 07:10:14 -06:00
Xiang Xiao
d660492289 Run codespell -w against all files 
and fix the wrong correction
 2020-02-22 14:41:36 -06:00
chao.an
9a28ccf836 nsh/parse: try the builtin configuration first 
In the case of enable the BUILTIN_APPS/FILE_APPS at the same time, try the builtin list first to ensure that the relevant configuration(stacksize, priority) can be set normally.
 2020-02-21 07:40:47 -06:00
Xiang Xiao
eb8678cfeb Remove CONFIG_DEV_LOWCONSOLE from source code 
Follow the nuttx side change
 2020-02-18 13:13:29 -06:00
YAMAMOTO Takashi
afa51c2e00 Fix documentation typos 2020-02-14 16:08:07 +08:00
Gregory Nutt
724a34bd3b Run all files modified by pr45 through nxstyle. 2020-02-03 07:38:57 -06:00
Xiang Xiao
37135e5dfe telnetd should listen both IPv4 and IPv6 for the dual stack 
Change-Id: Ic1c2878f2eda721ccdf667b0a634289c643f5220
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
 2020-02-03 07:17:22 -06:00
Xiang Xiao
c44f271195 Fix ret undefined error in nsh_telnetlogin when CONFIG_NSH_LOGIN_PLATFORM enable 
Change-Id: Ib1fa8ba6879a5b330201f1144a2e5827cc4b1d0a
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
 2020-02-03 07:17:22 -06:00
Xiang Xiao
1154735ca6 Refine the preprocess conditional guard style 2020-01-31 11:04:10 -06:00
Xiang Xiao
e0dcfa0c55 Remove extra whitespace from files (#43) 
* Remove multiple newlines at the end of file
* Remove the white space from the end of line
 2020-01-31 08:29:24 -06:00
Xiang Xiao
fd3775e068 Remove CONFIG_TIME_EXTENDED conditioning 
Remove CONFIG_TIME_EXTENDED related stuff since kernel remove this option
 2020-01-23 08:36:03 -06:00
Alin Jerpelea
5c936ce0e4 Various fixes (#6) 
Author: Gregory Nutt <gnutt@nuttx.org>

    Run all .c and .h affected by this PR through nxstyle.

Author: Alin Jerpelea <alin.jerpelea@sony.com>

    * system/usbmsc: Fix accessing uninitialized pointer
    * fsutils/inifile: Fix a memory leak in inifile error case
    * fsutils/mksmartfs: Fix uninitialized return code
    * system/zmodem: Fix a compile error in zmodem debug enabled
    * nshlib/nsh_fscmds.c: Add syntax check to cp command

    If the destication of NutShell cp command is the same with the source,
    it may cause the file corruption. Add the syntax check of argument to
    avoid this problem.
 2020-01-07 09:01:23 -06:00
Xiang Xiao
857158451b Unify the void cast usage 
1.Remove void cast for function because many place ignore the returned value witout cast
2.Replace void cast for variable with UNUSED macro

Change-Id: Ie644129a563244a6397036789c4c3ea83c4e9b09
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
 2020-01-02 23:21:01 +08:00
Gregory Nutt
0536c5b523 apps/nshlib/nsh_parse.c: Correct an error found in build testing. Commit 2a462c78aa was insufficient. It was a mistake to revert Xiang's change of commit 9defae8af6. But we are on a different vector now. 2019-12-24 12:18:30 -06:00
Gregory Nutt
2a462c78aa nshlib/nsh_parse.c: Replacement implementation for 9defae8af6. This addes conditional compilation on the definition of g_nullstring[] to avoid the warning. Suggested by SUZUKI Y <NBG03015@nifty.ne.jp> 2019-12-19 07:59:30 -06:00
Gregory Nutt
6bfd6166dd Revert "apps/nshlib/nsh_parse.c: Fix warning: 'g_nullstring defined but not used'. Use directly since the usage is triggered by a complex Kconfig combination." 
Per SUZUKI Y <NBG03015@nifty.ne.jp>, changing:

-      return (FAR char *)g_nullstring;
+      return "";

causes a bad return value because "" lies on the stack.

This reverts commit 9defae8af6.
 2019-12-19 07:52:00 -06:00
Xiang Xiao
9defae8af6 apps/nshlib/nsh_parse.c: Fix warning: 'g_nullstring defined but not used'. Use directly since the usage is triggered by a complex Kconfig combination. 2019-12-18 09:43:31 -06:00
Xiang Xiao
5ec8fc9427 apps/nshlib/nsh_fileapps.c: nsh_fileapp() should return 1 if the application task was spawned successfully but returned failure exit status. For example, nsh shouldn't output "/bin/ping: command not found": 
nsh> /bin/ping
ERROR: Missing required <ip-address> argument
...
nsh: /bin/ping: command not found
 2019-12-10 10:05:51 -06:00
Gregory Nutt
77a3b08302 apps/nshlib/nsh_parse.c: Ensure /bin/ping and ping work at the same time. Don't skip nsh_builtin even CONFIG_NSH_FILE_APPS or CONFIG_FS_BINFS equal y. 2019-12-10 08:40:29 -06:00
Gregory Nutt
e89a1aa54d README.txt: Update to include a description of the 'dmesg' command which was apparently never documented. 2019-11-21 12:23:50 -06:00
Juha Niskanen
eaeb6cc105 nshlib/Kconfig: Add missing NSH_DISABLE_DMESG, typos. 2019-11-08 07:52:22 -06:00
Dave Marples
dbd4e67241 apps/system/cle/cle.c: This commit modifies the cle to use the streams file interface more consistently and has removed the observed race conditions. It was previously a mix of streams and fileio. It also simplifies the VT100 cursor position handling. 2019-11-04 11:35:18 -06:00
Gregory Nutt
75c9ed72d1 apps/nshlib/README.txt: Update README to at least mention the new pmconfig command. 2019-11-04 07:48:51 -06:00
ligd
42aaecf1d1 apps/nshlib: Add new NSH command, 'pmconfig'. 2019-11-04 07:44:33 -06:00
Gregory Nutt
eca2171ab5 apps/nshlib/nsh_netcmds.c: Fix some alignment in output of 'arp -t' command. 2019-11-03 20:10:56 -06:00
Gregory Nutt
b65c3dac0e netutils/netlib/netlib_getarptab.c: Misc fixes from initial testing with the 'arp -t' commeand. 2019-11-03 19:29:20 -06:00
Gregory Nutt
400995dec6 nshlib/nsh_netcmds.c: Add a -t option to the arp command which will enable printing the entire ARP table. 2019-11-03 16:19:14 -06:00
Gregory Nutt
29160741d8 apps/nshlib/README.txt: Update to include the new rptun command. 2019-11-03 09:50:13 -06:00
Gregory Nutt
c3dd0b9c06 apps/nshlib/README.txt: Update to include the new rptun command. 2019-11-03 09:44:02 -06:00
ligd
611bc6c139 apps/nshlib: Add rptun cmd for boot remote core. 2019-11-03 09:36:49 -06:00
Xiang Xiao
93017735ef apps/nshlib/nsh.h: nsh: Remove the redundant check for netcmd. Checking FS_PROCFS and FS_PROCFS_EXCLUDE_NET is enough and make the type of network device could be shown by ifconfig. 2019-11-03 09:33:57 -06:00
Gregory Nutt
0dde32fb43 nshlib/nsh_romfsetc.c and graphics/traveler/trv_romfs.c: Replace direct calls to romdisk_register() with indirect calls via boardioctl(BOARDIOC_ROMDISK). This not only fixes the violation of the portable POSIX OS interface, but also permits use of ROM disks in PROTECTED and KERNEL modes. There are still multiple illegal calls to romdisk_register() from code under apps/examples. These all must also be converted to use boardioctl(BOARDIOC_ROMDISK) someday. 2019-10-26 13:47:03 -06:00
Gregory Nutt
06acc559a1 apps/nshlib: Tighten up some of the conditional logic for mkrd. 2019-10-26 12:26:16 -06:00
Gregory Nutt
e0dff13094 apps/nshlib/Kconfig and examples/mount/Kconfig: Automatically select CONFIG_DRVR_MKRD is it is needed by the configuration. 2019-10-26 11:45:00 -06:00
Gregory Nutt
0bc798c7a9 apps/examples/mount: Replace illegal call to ramdisk_register() with a call to boardctl(BOARDIOC_MKRD). 2019-10-26 10:22:34 -06:00
Gregory Nutt
c8a066f699 apps/nshlib/nsh_fscmds.c: The NSH mkrd command was in violation of the NuttX portable POSIX interface. it was calling the internal OS function ramdisk_register() directly. No only is this a violation of the interface specification, but also prevents use of mkrd in PROTECTED or KERNEL buils. 
With this commit, the NSH mkrd command now used the BOARDIOC_MKRD boardctl() command.  This command is availabe in all build modes.  The effect of this change is to move the hear of the NSH mkrd command into to OS and provide user-space access via boardctl().
 2019-10-26 09:42:51 -06:00
Xiang Xiao
403b4a0178 In all Make.defs files, append CONFIGURED_APPS with the consistent ifeq/ifneq. 2019-10-17 11:42:49 -06:00
Xiang Xiao
7808eb62d2 apps/: In all Make.def files, append to CONFIGURED_APPS patch with the absolute path. 2019-10-17 11:33:59 -06:00
Gregory Nutt
3a23523147 Makefiles: This reverts part of commit cf0365ea9. It restores 'conditional' inclusion of TOPDIR/Make.defs. Otherwise all make targets fail if the board has not been configured. That is okay most of the time, but not for things like clean and distclean which should not depend on being configured. 2019-10-15 09:25:48 +08:00
Dave Marples
b4134a674d nshlib/ and system/cle: Add basic color support to the CLE editor. 2019-10-12 00:47:29 +08:00
Xiang Xiao
cf0365ea92 Clean up Makefile under apps folder no functional changes. 2019-10-04 08:35:46 -06:00
Xiang Xiao
63c3772888 CONFIG_BUILD_LOADABLE: Check the kernel function callable by BUILD_KERNEL instead of BUILD_LOADABLE since BUILD_LOADABLE could be turned on even with BUILD_FLAT. 2019-10-03 14:10:32 -06:00
Gregory Nutt
3457c30c33 apps/nshlib: Fix some typos and minor coding staqndard problems. 2019-09-12 15:38:53 -06:00
Gregory Nutt
ac61c18fcc Move apps/builtins/builtin_forindex.c to nuttx/libs/libc/builtin since it is required by kernel logic as well. Other changes account for movement of builtin.h from nuttx/include/nuttx/binfmt/built.h to nuttx/include/lib/builtin.h. 2019-08-23 09:12:45 -06:00
Gregory Nutt
e6ba3ccff8 Update comments, README's, etc. to reflect changes to nuttx/boards directory reorganization. 2019-08-09 08:40:22 -06:00
Gregory Nutt
dd36f7ca4d Fix paths in README.txt files which have changed due to the restructuring of nuttx/boards directory. 2019-08-05 10:22:56 -06:00
Gregory Nutt
2a8dccb75d Change name configs/ to boards/ in comments, Documentation, Tools, etc. 2019-08-05 07:33:16 -06:00
Gregory Nutt
49e08ca3a9 apps/nshlib/nsh_fsutils.c: As noted by David S. Alessio, 'cat' should not output any additional newline at the end of the cat'ed file content. This was done to assure that the NSH prompt was presented on a new line. However, that is not the correct behavior of 'cat' per the IEEE std: "The standard output shall contain the sequence of bytes read from the input files. Nothing else shall be written to the standard output." Reference: https://pubs.opengroup.org/onlinepubs/009695399/utilities/cat.html 
This commit changes the function nsh_catfile() which underlies the 'cat' command and well as other NSH commands.  Although this is the correct behavior for 'cat' it may not be the correct behavor for other commands implemented via nsh_catfile().  That remains to be determined.
 2019-07-29 20:49:39 -06:00
Gregory Nutt
24e590b072 apps/nshlib/nsh_ddcmd.c: Seemingly nonsense change but somehow works around a compilation error using the ZDS-II toolchain. It was claiming that vtbl was undefined indd_outfopen(). 2019-06-03 11:32:56 -06:00
Gregory Nutt
8c36ec3f33 nshlib/nsh_parse.c: Fix a warning about an uninitialized variable from the ZDS-II compiler. 2019-06-03 09:29:44 -06:00
Gregory Nutt
6c815a8d48 apps/nshlib/nsh_ddcmd.c: Cosmetic edition of FAR 2019-06-03 09:19:09 -06:00
Gregory Nutt
7409dd57bb Fix a warning found in build testing. 2019-05-22 08:22:12 -06:00
Gregory Nutt
dd35a7cacc apps/: Removed all references to CONFIG_DISABLE_POLL. The standard POSIX poll() can not longer be disabled. 2019-05-21 19:08:12 -06:00
Valmantas Paliksa
5cad41c973 apps/nshlib: Fix all places where cle() and readline() are used. readline() returns EOF on a failure. cle() returns a negated errno value. Checking only for EOF causes failues to be missed (and infinite loops ensuing). 2019-05-21 08:43:09 -06:00
Gregory Nutt
8f5944c4a8 Squashed commit of the following: 
include/ and netutils/:  Remove references to CONFIG_DISABLE_SIGNALS.  Signals can no longer be disabled.
    nshlib/:  Remove references to CONFIG_DISABLE_SIGNALS.  Signals can no longer be disabled.
    system/:  Remove references to CONFIG_DISABLE_SIGNALS.  Signals can no longer be disabled.
    testing/:  Remove references to CONFIG_DISABLE_SIGNALS.  Signals can no longer be disabled.
    examples/:  Remove references to CONFIG_DISABLE_SIGNALS.  Signals can no longer be disabled.
 2019-04-29 14:53:38 -06:00
Gregory Nutt
94a0d92b54 This commit removes the private network initialization logic from NSH and puts in a common location at apps/netutils/netinit. Now that netork initialization logic can be used by applications that do not include NSH. 
Squashed commit of the following:

    apps/nshlib:  Remove NSH initialization.  Now uses the common apps/netutils/netinit logic (which was cloned from nshlib to begin with).

    apps/netutils/netinit:  Clone network initialization logic from NSH to this directory so that it can be available for general use.
 2019-04-29 10:22:56 -06:00
raiden00pl
0a6726bc3e Merged in raiden00/apps (pull request #174) 
Small fixes

examples/pca9635/pca9635_main.c: fix compilation

Approved-by: Gregory Nutt <gnutt@nuttx.org>
 2019-04-28 11:33:21 +00:00
Valmantas Palikša
5484407877 nshlib/nsh_timcmds.c: Initialized struct tm cause 'date -s' to fail. 2019-03-18 08:04:40 -06:00
Gregory Nutt
b2f46360de apps/: Remove/replace all conditional logic based on CONFIG_NSOCKET_DESCRIPTORS == 0. That value is always greater than zero now. In places just replace with #ifdef CONFIG_NET. 2019-02-11 16:23:55 -06:00
Gregory Nutt
fe41f72a95 Fix typo found in building testing. There will probably be a few more. 2019-02-11 13:25:48 -06:00
Gregory Nutt
9db029e318 The file system can no longer be disabled. Remove all conditional logic based on CONFIG_NFILE_DESCRIPTORS==0 2019-02-11 13:10:10 -06:00
Gregory Nutt
b1352458ab apps/nshlib/nsh_netinit.c: Update for changes to signal notification structures. 2019-01-27 16:45:56 -06:00
David Sidrane
7db2a352fb nshlib/nsh_console.h: Fix copy paste errors. Some Kconfig configuration names needed CONFIG_ prefix. 2019-01-24 06:36:26 -06:00
Gregory Nutt
6fb399fd65 Update README 2019-01-19 08:54:01 -06:00
Masayuki Ishikawa
060a8fff4b Merged in masayuki2009/nuttx.apps/fix_redirection_error (pull request #167) 
apps/nshlib: Fix buffer overrun when redirected to a file.

SAVE_SIZE must be the same as sizeof(struct serialsave_s)

Signed-off-by: Masayuki Ishikawa <Masayuki.Ishikawa@jp.sony.com>

Approved-by: GregoryN <gnutt@nuttx.org>
 2019-01-19 12:38:49 +00:00
Anthony Merlino
7cde7e921d Merged in antmerlino/apps/addroute-default-gw (pull request #166) 
addroute: Adds command for setting default gateway. addroute default <ipaddr> <interface>

Approved-by: GregoryN <gnutt@nuttx.org>
 2019-01-13 14:20:15 +00:00
Ken Pettit
e08d100919 apps/nshlib/nsh_parse.c: Fixes an error in the NSH parser. There was a bug when executing an nsh shell script which contains a redirection. When the command in the script is executed, it sets the vtbl->np.np_redirect flag (as it should), but then doesn't restore it, leaving it set at the end of the script execution. Then the vtbl->np.np_redirect flag is set when the 'sh' command completes, causing a restore from un-initialized variables, thus leading to a crash. See the code snippet below for an example test case. 
Test case:

NuttShell (NSH)
nsh> mkrd -s 1024 40
nsh> mkfatfs /dev/ram0
nsh> mount -t vfat /dev/ram0 /tmp
nsh> echo "echo 1 > /dev/null" > /tmp/test.sh
nsh> cat /tmp/test.sh
echo 1 > /dev/null
nsh> sh /tmp/test.sh
...

The nsh prompt doesn't get printed.  You can type a couple of commands, but then the system will crash because of bad pointers.
 2019-01-12 10:56:48 -06:00
Gregory Nutt
eaec674e7b apps/nshlib/nsh_command.c: In all multi-column help output, make the number of rows presented dependent upon the maximum width of the widest column. 2019-01-11 09:21:59 -06:00
Gregory Nutt
d789194836 apps/nshlib/nsh_command.c: In all multi-column help output, calculate an optimal column width rather than using a hard-coded width that may or may not be appropriate. 2019-01-11 08:59:36 -06:00
Gregory Nutt
806ba4ee83 apps/nshlib/nsh_command.c: Fix a few long lines 2019-01-11 07:39:23 -06:00
Ken Pettit
a6d056cf76 apps/nshlib/nsh_command.c: display built-in apps using multi-column mode like the nsh commands 2019-01-11 07:35:04 -06:00
Gregory Nutt
3257ea42d5 apps/nshlib/nsh_parrse.c: Correct some coding standard problems in last PR. 2019-01-06 10:00:19 -06:00
Daniel Agar
c700bf9739 Merged in dagar/nuttx-apps/pr-nshlib (pull request #163) 
[WIP] nshlib add var expansion in nsh parse

Approved-by: GregoryN <gnutt@nuttx.org>
 2019-01-06 15:52:18 +00:00
GregoryN
3bf4b6d245 Merged altconsole into master 2018-12-08 18:53:54 -06:00
David Sidrane
8eb249eea5 apps/nshlib/nsh_romfsetc.c: Add support for CROMFS start-up script 2018-12-06 15:41:18 -06:00