Commit Graph

4066 Commits

Author SHA1 Message Date
Masayuki Ishikawa
060a8fff4b Merged in masayuki2009/nuttx.apps/fix_redirection_error (pull request #167)
apps/nshlib: Fix buffer overrun when redirected to a file.

SAVE_SIZE must be the same as sizeof(struct serialsave_s)

Signed-off-by: Masayuki Ishikawa <Masayuki.Ishikawa@jp.sony.com>

Approved-by: GregoryN <gnutt@nuttx.org>
2019-01-19 12:38:49 +00:00
Gregory Nutt
38205729f2 Update ChangeLog in preparation for the nuttx-7.28 release. 2019-01-18 10:52:21 -06:00
Ken Pettit
edbf31a341 system/termcurses/tcurses_vt100.c: Fix spelling error in last commit. 2019-01-17 09:13:00 -06:00
Ken Pettit
42f3c06389 system/termcurses/tcurses_vt100.c: Eliminate a warning. 2019-01-17 08:58:11 -06:00
Gregory Nutt
a79b89202e system/termcurses/tcurses_vt100.c: Costmetic vertical alignment. 2019-01-17 08:39:29 -06:00
Ken Pettit ‎
cc8beb8578 Bug fixes and changes to existing functionality
===============================================

1.  Deletion of last line in file using 'dd' caused infinite loop searching for
    'nextline'.  Fixed.

2.  Insertion of line above 1st line using 'O' caused line to be inserted on
    2nd line.  Fixed.

3.  Paste buffer from 'dd' was being free'd after the 'p'aste operation,
    preventing multiple paste opportunity.  Fixed.

4.  The cursor was not being bound to the line end and was allowed to 'hover'
    over the '\n' EOL character.  This caused wierd (relative to standard vi)
    insertion locations and cursor movement with 'a'ppend and 'i'nsert.  Fixed.

5.  The 'vi_shrinkpos' position didn't take the end of file pointer into
    account when calculating 'curpos', 'prevpos' variables causing wierdness
    when deleting things near the end of the file.  Fixed.

6.  The 'yy'ank command was improperly deleting the text from the document
    instead of simply yanking to the paste buffer.  Fixed.

7.  The 'dd'elete line funciton was not copying the deleted line to the paste
    buffer as part of the delete operation.  Fixed.

8.  The bottom line of the screen was sometimes being used for document text
    and other times for command / find entry.  Fixed by reserving the bottom
    the bottom line for status / command only.

9.  When scrolling up / down through a file, the cursor position was not
    preserved and moved further and further to the left column based on the
    line lengths of the lines visited.  Fixed.

10. The display was being COMPLETELY redrawn with each keystroke, causing the
    responsiveness to be imbearable.  Fixed.  Added logic to dynamicall
    indicated which portions of the screen need to be updated (full display,
    current line to end of screen, current line only, none).

11. The individual display line updates were being performed a character at
    a time by calling the vi_putch() function, causing slow performance,
    especially in telnet or USBCDC sessions where there is a lot of overhead
    per packet.  Fixed by calling vi_write() instead with a block of
    characters with breaks as needed for TAB exansion.

12. The forward delete 'x' operation allowed deletion through '\n' characters
    causing lines to be joined.  This is different from standard vi where
    'x' at the end of a line performs a delete backward operation.  Fixed.

13. When in 'ex' or find sub-modes (':' or '/' bottom line modes), hitting
    backspace with empty text did not return the operation to command mode
    like it does in standard vi.  Fixed.

14. Performing a 'find' opertation would only search from the current cursor
    position to the end of the file and did not wrap like in standard vi.
    Fixed.

15. Loading a file that was larger than the initial text allocation would
    force a call to 'vi_extendtext', marking the file as modified when in
    fact it hadn't even been loaded yet.  Fixed.

16. Combined vi_insert_mode and vi_replace_mode into a single function to
    save code space since they are nearly identical routines.

17. In command mode, backspace was deleting characters which is different
    from standard vi.  Backspace in command mode normally simply moves the
    cursor left / to the previous line.  Fixed.

18. Added code to handle boundry conditions when the file is new and
    commands are applied to an empty file.

19. Fixed vi_shrinktext so it doesn't allocate a zero-length buffer when
    the last character in the file is deleted.

20. The 'x' command was not copying to the paste buffer.  Fixed.

21. Fixed parsecolon routine to properly deal with ":wq" command sequence.

New feature additions
=====================

1.  Vi startup feature to prepend the current working directory to the
    supplied filename if it does not start with '/' absolute path specifier.
    This allows editing files in the current directory without needing to
    fully qualify the filename.

2.  Standard '~' empty screen line characters for proper identification
    of empty '\n' only lines at the end of the file.

3.  Moving into insert or append mode now prints '--INSERT--' in the status
    line and clears it upon exit.

4.  Integration with termcurses to detect special keystrokes and to
    handle terminal type differences.  Haven't yet converted all vt100 print
    codes to termcurses equivalents.

5.  Support for up, down, left, right arrows, page-up, page-down keys
    in command mode.

6.  Added 'b' command to move cursor 'b'ack to previous word.  Honors the
    command repeat value for multiple word moves.

7.  Added 'w' command to move cursor to next 'w'ord.  Honors the command
    repeat value for multiple word moves.

8.  Added 'f' and 't' commands to find characters on the current line.
    Honors the command repeat value.

9.  Added the find 'n'ext command to repeat the previous find operation.

10. Added the 'H', 'M', and 'L' commands to move the cursor to top,
    middle and bottom of the display.

11. Extended yank/paste to manage a paste buffer with character mode in
    addition to line mode.  Character mode allows cut / paste of
    individual characters or groups of characters vs. full lines.

12. Added support in the 'd'elete and 'y'ank commands for character mode
    deletions such as 'dw', 'dfa', '2yw', etc.

13. Added support in paste routine for multiple paste using command value
    argument.

14. Added support for the 'D' and 'C' delete and change to end of line
    commands.

15. Added support for 's'ubstitute key ('x' followed by insert mode).

16. Modified yank / paste allocation scheme to avoid repeated alloc
    and free of paste buffer.  Uses a minimum allocation size scheme and
    only does free / realloc when paste does not fit.  If the paste is
    smaller than the current allocation and the current allocation is
    larger than the threshold, then the buffer is freed and a smaller
    buffer allocated.  Otherwise the existing buffer is used.

17. Support for 'P'aste before current cursor position.

18. Support for '?' reverse search mode.

19. Support for 'J'oin next line with current line command.

20. Printing of current row,col in status line of display.

21. Command repeat '.' support for commands that modifiy text.

22. Support in replace  / insert mode for arrow keys, PGUP / PGDN, HOME,
    and END.  Using these will cause the command repeat buffer to
    reset such that only the last text addition after a cursor movement
    is saved.

23. Added 'X' delete previous command.

24. Added "gg" go to top of document command sequence.

25. Added "ZZ" save and quit command (equivalent to :wq).

26. Implemented '^' goto first non-whitespace on current line, along
    with '+' and '-' goto first non-whitespace on next / previous line.

27. Added CR / LF goto first non-whitespace on next line in command mode.
2019-01-16 19:25:04 -06:00
Ken Pettit ‎
b285dd9b68 Perform a bounds check to fix a random Termcurses crash that I haven't been able to track down. The result of of the subtraction for priv->keycount should never be negative, but I think sometimes it is, so better to catch it and avoid a crash until I can track it down. 2019-01-16 18:22:16 -06:00
Gregory Nutt
93de0c232b apps/system/readline_common.c: Correct spelling, matches vs maches. 2019-01-16 10:15:18 -06:00
Anthony Merlino
7cde7e921d Merged in antmerlino/apps/addroute-default-gw (pull request #166)
addroute: Adds command for setting default gateway. addroute default <ipaddr> <interface>

Approved-by: GregoryN <gnutt@nuttx.org>
2019-01-13 14:20:15 +00:00
Anthony Merlino
c895593fc1 Merged in antmerlino/apps/i8sak-daemon-fixea (pull request #165)
wireless/ieee802154/i8sak: Fixes issues related to re-running daemon. Releases lock when releasing daemon. Re-sets daemon_shutdown so that a subsequent daemon launch does not immediately return.

Approved-by: GregoryN <gnutt@nuttx.org>
2019-01-13 14:19:43 +00:00
Ken Pettit
e08d100919 apps/nshlib/nsh_parse.c: Fixes an error in the NSH parser. There was a bug when executing an nsh shell script which contains a redirection. When the command in the script is executed, it sets the vtbl->np.np_redirect flag (as it should), but then doesn't restore it, leaving it set at the end of the script execution. Then the vtbl->np.np_redirect flag is set when the 'sh' command completes, causing a restore from un-initialized variables, thus leading to a crash. See the code snippet below for an example test case.
Test case:

NuttShell (NSH)
nsh> mkrd -s 1024 40
nsh> mkfatfs /dev/ram0
nsh> mount -t vfat /dev/ram0 /tmp
nsh> echo "echo 1 > /dev/null" > /tmp/test.sh
nsh> cat /tmp/test.sh
echo 1 > /dev/null
nsh> sh /tmp/test.sh
...

The nsh prompt doesn't get printed.  You can type a couple of commands, but then the system will crash because of bad pointers.
2019-01-12 10:56:48 -06:00
Gregory Nutt
eaec674e7b apps/nshlib/nsh_command.c: In all multi-column help output, make the number of rows presented dependent upon the maximum width of the widest column. 2019-01-11 09:21:59 -06:00
Gregory Nutt
d789194836 apps/nshlib/nsh_command.c: In all multi-column help output, calculate an optimal column width rather than using a hard-coded width that may or may not be appropriate. 2019-01-11 08:59:36 -06:00
Ken Pettit
cb4974cee8 apps/system/termcurses/tcurses_vt100.c: Fix an issue where the first curses 'getch()' call sometimes (usually) hangs waiting for a keypress. This bug was introduced when I fixed the keyboard 'paste' overflow error. 2019-01-11 07:41:04 -06:00
Gregory Nutt
806ba4ee83 apps/nshlib/nsh_command.c: Fix a few long lines 2019-01-11 07:39:23 -06:00
Ken Pettit
a6d056cf76 apps/nshlib/nsh_command.c: display built-in apps using multi-column mode like the nsh commands 2019-01-11 07:35:04 -06:00
Ken Pettit
8132c38064 graphics/pdcurs34: This commit adds a configuration option to pdcurses to enable line-drawing character (ALTCHARSET) when using the short 16-bit chtype. This is done by limiting the characters to 7-bit ASCII values and using the 8-th bit as the A_ALTCHARSET bit. This allows a significant RAM savings 4K - 20K depending on terminal size) while still allowing the nicer line-graphic characters for border drawing. 2019-01-08 08:28:27 -06:00
Ken Pettit
e1237bfefd apps/graphics/pdcurs34/nuttx and system/termcurses: This commit fixes two issues:
1. A memory corruption issue that occurs from a paste operation that would overflow the fixed buffer size for keyboard processing.

2. A stall in getch() processing when there are cached keycodes in the termcurses emulation (tcurses_vt100.c).
2019-01-08 08:28:27 -06:00
Masayuki Ishikawa
3cdb6ec4ba &Merged in masayuki2009/nuttx.apps/nxplayer_mainthread_stacksize (pull request #164)
apps/system/nxplayer: Introduce CONFIG_NXPLAYER_MAINTHREAD_STACKSIZE

Signed-off-by: Masayuki Ishikawa <Masayuki.Ishikawa@jp.sony.com>

Approved-by: GregoryN <gnutt@nuttx.org>
2019-01-07 01:51:36 +00:00
Gregory Nutt
3257ea42d5 apps/nshlib/nsh_parrse.c: Correct some coding standard problems in last PR. 2019-01-06 10:00:19 -06:00
Daniel Agar
c700bf9739 Merged in dagar/nuttx-apps/pr-nshlib (pull request #163)
[WIP] nshlib add var expansion in nsh parse

Approved-by: GregoryN <gnutt@nuttx.org>
2019-01-06 15:52:18 +00:00
Gregory Nutt
298c76e611 apps/system/termcurses/tcurses_vt100.c: Fix an error introduced during review of recent patch. 2019-01-05 13:52:51 -06:00
Ken Pettit
c776901ac2 apps/examples/pdcurses: Minor fixes to examples/pdcurses apps to support multi-threading, cleanup RAM, etc. 2019-01-05 13:28:06 -06:00
Ken Pettit
73fc5eb199 apps/graphics/pdcurs34: Integration of termcurses into pdcurses, plus pdcurses updates for multi-thread support 2019-01-05 13:25:12 -06:00
Ken Pettit
fcd15d8786 apps/system/termcurses: Addition of termcurses libraries in apps/system/termcurses 2019-01-05 12:40:26 -06:00
Alan Carvalho de Assis
25c0387c44 apps/examples/battery: Add Battery Charger Monitor Example 2019-01-04 12:15:05 -06:00
Gregory Nutt
5182dbc4b1 apps/testing/ostest: Add test for pthread-specific data. 2018-12-28 14:17:40 -06:00
Gregory Nutt
0c615ed586 Fix a few typos. 2018-12-27 08:48:52 -06:00
Masayuki Ishikawa
9b548e8ea2 Merged in masayuki2009/nuttx.apps/add_dep_to_smp (pull request #162)
apps/examples/smp: Add dependency on SMP in Kconfig

Signed-off-by: Masayuki Ishikawa <Masayuki.Ishikawa@jp.sony.com>

Approved-by: GregoryN <gnutt@nuttx.org>
2018-12-25 14:15:16 +00:00
Ken Pettit
88c78b6a0c apps/system/configdata: Adds an "cfgdata" command which allows manipulation of the /dev/config items via the command line. One such use for this utility would be to set a "macaddr" configdata item, etc. The utility is sort-of like a u-boot env variable edit function:
For instance, to set a "macaddr" when the new CONFIG_MTD_CONFIG_NAMED option is selected, you would do:

nsh> cfgdata set macaddr [0xfc 0x01 0x0b 0x45 0xa1 0x12] <-- brackets denotes an array of bytes
nsh> cfgdata set hostname myboard

or using the old ID,INSTANCE numeric method:

nsh> cfgdata set 0,0 [0xfc 0x01 0x0b 0x45 0xa1 0x12]      <-- brackets denotes an array of bytes
nsh> cfgdata set 1,0 myboard

You can also display all config items:

nsh> cfgdata print all
Name                    Len   Data
macaddr                 6     0xFC 0x01 0x0B 0x45 0xA1 0x12
hostname                8     myboard
2018-12-20 14:24:51 -06:00
Gregory Nutt
40874bbe8b apps/system/nsh/nsh_main.c: Set NSH priorirty if the NSH task was scheduled at a different priority than the configured priority. 2018-12-20 10:50:29 -06:00
Lwazi Dube
a3c8f17522 apps/wireless/bluetooth/btsak/btsak_scan.c: Fix reversed address 2018-12-17 11:20:16 -06:00
Gregory Nutt
1bb723d60c Trivial update to README. 2018-12-12 17:57:37 -06:00
Gregory Nutt
1ea316b46c apps/testing: Move apps/examples/ostest to apps/testing/ostest. 2018-12-12 16:37:38 -06:00
GregoryN
3bf4b6d245 Merged altconsole into master 2018-12-08 18:53:54 -06:00
Lwazi Dube
c8a252d4ed apps/wireless/bluetooth/btsak: Remove unnecessary gatt get commands 2018-12-08 13:02:19 -06:00
David Sidrane
8eb249eea5 apps/nshlib/nsh_romfsetc.c: Add support for CROMFS start-up script 2018-12-06 15:41:18 -06:00
Lwazi Dube
09a108b507 apps/wireless/bluetooth/btsak: Add connect and disconnect commands to btsak 2018-12-02 11:01:28 -06:00
Alan Carvalho de Assis
368f14852e apps/nshlib: Change the way SLCD is supported. Works better 2018-11-30 18:05:18 -06:00
Lwazi Dube
2b8685b63f wireless/bluetooth/btsak/btsak_main.c: Fix address parsing 2018-11-30 06:28:36 -06:00
Gregory Nutt
c0f64622e4 nshlib/nsh_slcd.c: Use file descriptor zero for the NSH console. 2018-11-30 06:18:44 -06:00
Alan Carvalho de Assis
c21d640eaf apps/nshlib: Add support to use SLCD as NSH Console 2018-11-29 18:42:02 -06:00
Daniel Pereira Carvalho
521052ae1f apps/system/critmon/Makefile: Stack size and priority reversed. 2018-11-29 11:06:31 -06:00
Anthony Merlino
1c7d0303e8 Merged in antmerlino/apps/system-fix (pull request #161)
system: Fixes build error; There is no result variable, use errcode instead.

Approved-by: GregoryN <gnutt@nuttx.org>
2018-11-28 17:25:13 +00:00
Lwazi Dube
6af45bdee0 wireless/bluetooth/btsak: Fix some errors in btsak 2018-11-27 08:02:43 -06:00
Gregory Nutt
3adf8af266 netutils/webserver/httpd.c: Eliminate some warnings found in build testing. 2018-11-25 18:43:09 -06:00
Alan Carvalho de Assis
7ddbe8c235 Various initialization functions in configs/: Change /dev/slcd to /dev/slcd0 for consistency 2018-11-25 14:01:37 -06:00
Lwazi
d927f50e79 apps/wireless/bluetooth/btsak: 'bt bnep0 info' outputs a reversed addr. It should print BDAddr: aa:bb:cc:dd:ee:ff instead of BDAddr: ff:ee:dd:cc:bb:aa 2018-11-25 09:54:09 -06:00
Gregory Nutt
2b53c50552 system/critmon/critmon.c: Another improvement to output format. 2018-11-25 09:50:21 -06:00
Gregory Nutt
411a047f9c apps/system/critmon: Make output more compact and usable. 2018-11-25 07:42:47 -06:00