Commit Graph

4923 Commits

Author SHA1 Message Date
Gregory Nutt
c8dbd59e9a netutils/telnetd/telnetd_daemon.c: Avoid a warning if CONFIG_NET_SOCKOPTS=n 2020-02-09 00:33:39 +08:00
Gregory Nutt
d2522e2821 apps/netutils/telnetd: Fix undefined reference to setsockopt.
Recent change from Xiao Xiang enabled the SO_REUSEADDR socket option unconditionally.  This, of course, causes link time failures if socket options are not enabled:

apps/netutils/telnetd/telnetd_daemon.c:182: undefined reference to 'setsockopt'.

Observed during build testing with configuration rddrone-uavcan144:nsh
2020-02-09 00:33:39 +08:00
Xiang Xiao
f14aead53e Shouldn't use local readline in telnet
Shouldn't use local readline in telnet since the host has more powerful intelligent
2020-02-08 07:58:04 -06:00
Miguel Herranz
960a92c652 Make SO_REUSEADDR not mandatory in netlib
This functionality is not available in NuttX so far.
2020-02-06 23:43:37 +01:00
Miguel Herranz
a5dff52a71 Change unimplemented requests behaviour in gs2200m
The ASSERT is too strong, as it cannot be disabled, so changing to
DEBUGASSERT, as calling these functions should not be a problem as
long as the application logic handle the error correctly.

The error code is changed to ENOSYS, as it seems to better reflect
the fact that the call itself would be valid, but the functionality
is not implemented (see [1] or `man errno`).

[1] https://www.gnu.org/software/libc/manual/html_node/Error-Codes.html
2020-02-06 23:43:37 +01:00
YAMAMOTO Takashi
2f4b309b1b gs2200m: Retry indefinately on GS2200M_IOC_ASSOC failure
Author: Alan Carvalho de Assis <engenharia03@siam.ind.br>

    Run nxstyle again gs2200m_main.c file and fix issues

Author: YAMAMOTO Takashi <yamamoto@midokura.com>

    gs2200m: Retry indefinately on GS2200M_IOC_ASSOC failure

    The ioctl doesn't return why it failed.
    It might or might not be a transient failure.

    In my environment, gs2200m often returns the following for AT+WA.
    It usually works after a few retries.

    [   12.110000] _parse_pkt_in_s1: +++++ 0:(msize=19, msg=WLAN CONNECT ERROR|)
    [   12.110000] _parse_pkt_in_s1: +++++ 1:(msize=6, msg=ERROR|)
2020-02-05 18:45:43 -03:00
liuhaitao
e738fbedba graphics/littlevgl/Makefile: update lvgl.h dependency to fix parallel build break
Parallel build imxrt1060-evk:lvgl with the below error:
make[3]: *** No rule to make target 'lvgl/lvgl.h', needed by '/home/jenkins/jenkins-slave/
workspace/NuttX-Nightly-Build/apps/include/graphics/lvgl.h'.

Signed-off-by: liuhaitao <liuhaitao@xiaomi.com>
2020-02-05 05:50:56 -08:00
Masayuki Ishikawa
bb3cd0a496 apps: elf: Fix stack corruption in task test
Signed-off-by: Masayuki Ishikawa <Masayuki.Ishikawa@jp.sony.com>
2020-02-04 20:56:52 -08:00
Xiang Xiao
bf3e6e2367 Improvements for telnet server
Author: Xiang Xiao <xiaoxiang@xiaomi.com>

    Check POLLHUP and POLLERR in telnet poll loop

      to handle the remote end close correctly

    Send "NVT"(network virtual terminal) as the default if getenv("TERM") return NULL

      telnet should trigger the error handling if inet_pton return zero
      since zero mean the string has format error

    Don't return 1 in _environ_telnet to avoid trigger the compression
    and remove the redundant TELNET_TELOPT_COMPRESS2 check

    Change telnet_error_u to telnet_error_e required by the coding standard

    Ensure telnet object get freed before the abnormal exit
2020-02-04 19:09:22 -03:00
YAMAMOTO Takashi
43a36996ca nettest: Avoid conflicts with host definitions 2020-02-04 09:36:50 -06:00
YAMAMOTO Takashi
bcc0f5c0a9 nettest: Avoid common symbols 2020-02-04 09:36:08 -06:00
Xiang Xiao
e0adf5ee0b Remove all CONFIG_NET_HAVE_REUSEADDR guard 2020-02-03 15:13:19 -06:00
Xiang Xiao
1d6fcfac13 Build system: Reference tools/define.sh through DEFINE macro 2020-02-03 15:09:33 -06:00
Gregory Nutt
724a34bd3b Run all files modified by pr45 through nxstyle. 2020-02-03 07:38:57 -06:00
Xiang Xiao
37135e5dfe telnetd should listen both IPv4 and IPv6 for the dual stack
Change-Id: Ic1c2878f2eda721ccdf667b0a634289c643f5220
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2020-02-03 07:17:22 -06:00
Xiang Xiao
c44f271195 Fix ret undefined error in nsh_telnetlogin when CONFIG_NSH_LOGIN_PLATFORM enable
Change-Id: Ib1fa8ba6879a5b330201f1144a2e5827cc4b1d0a
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2020-02-03 07:17:22 -06:00
Xiang Xiao
72bbc27b0f Free daemon struct in all telnetd_daemon error path
Change-Id: I7f014dc5f327a6ae6adf9cdbea8089ffab2efe37
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2020-02-03 07:17:22 -06:00
Xiang Xiao
d6e450e39a Skip to close acceptsd since it is already closed in SIOCTELNET handler
Change-Id: I669224fd5cd44162bb67c8316b56348f7f298883
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2020-02-03 07:17:22 -06:00
Xiang Xiao
579327a972 Remove CONFIG_NET_HAVE_REUSEADDR check from telnetd_daemon
since this option doesn't exist at all

Change-Id: I9ee8e61d0a8af1c9eb690b2f2945a7f7f7b5f834
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2020-02-03 07:17:22 -06:00
Xiang Xiao
28891ef27e Remove the global variable in telnetd_daemon
Change-Id: I264d10c0f141109ada6ac90afb2ba3e8cfad4404
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2020-02-03 07:17:22 -06:00
Xiang Xiao
1154735ca6 Refine the preprocess conditional guard style 2020-01-31 11:04:10 -06:00
Xiang Xiao
e0dcfa0c55 Remove extra whitespace from files (#43)
* Remove multiple newlines at the end of file
* Remove the white space from the end of line
2020-01-31 08:29:24 -06:00
Xiang Xiao
3dbf8d5652
testing/cxxtest/Make.defs: Append cxxtest to CONFIGURED_APPS (#42) 2020-01-31 14:35:32 +01:00
patacongo
8c9663b6c1
apps/examples/userfs/userfs_main.c: Fix warning (#41)
Fixes warning:

    CC:  userfs_main.c
    userfs_main.c:182:3: warning: initialization from incompatible pointer type [-Wincompatible-pointer-types]
       ufstest_truncate,
       ^
    userfs_main.c:182:3: note: (near initialization for ‘g_ufstest_ops.truncate’)

Co-authored-by: Gregory Nutt <gnutt@nuttx.org>
2020-01-30 18:58:03 +01:00
patacongo
7a8790f1b4
apps/testing/mm: Make stacksize configurable (#40)
Make stacksize as well as program name and priority configurable.  The defaults are the same as the previous hardcoded values.

The default stacksize of 2048 bytes is more than enough for most target applications.  However, when running on the simulator, much large stack sizes are needed.
2020-01-30 17:43:04 +01:00
patacongo
ba6377078b
apps/testing/mm: Move from apps/examples/mm (#39) 2020-01-30 17:07:00 +01:00
Gregory Nutt
4e509c8659 Revert "examples: hello: Show CPU index when running in SMP mode"
Cannot call up_cpu_index() or any other nonstandard OS application interface.  This not only breaks the portable POSIX OS interface but also would break any PROTECTED or KERNEL mode SMP implementation.

If you want to do something like this in user space, the appropriate thing to do would be to extend prctl().  That is non-posix, but is at least Linux-like and will work in all build modes.

This reverts commit 715517b1a0.
2020-01-30 05:41:13 -06:00
Masayuki Ishikawa
715517b1a0 examples: hello: Show CPU index when running in SMP mode
Signed-off-by: Masayuki Ishikawa <Masayuki.Ishikawa@jp.sony.com>
2020-01-30 09:23:12 +01:00
Alin Jerpelea
59b763add4 netutils/netlib: Fix buffer overflow 2020-01-29 00:29:30 -08:00
YAMAMOTO Takashi
b6890df58d Fix a build on macOS
On some platforms like macOS, we can't create an empty archive.
2020-01-29 09:03:01 +01:00
Masayuki Ishikawa
e4af73ec56 wireless: gs2200m: Fix sendto_request() in gs2200m_main.c
Signed-off-by: Masayuki Ishikawa <<Masayuki.Ishikawa@jp.sony.com>
2020-01-28 10:35:50 +01:00
Ouss4
eb1af03259 examples/sendmail: Few fixes to make the example run on a local SMTP
server.
2020-01-25 16:39:21 -06:00
Gregory Nutt
72a934c6c2 Add configuration settings for apps/examples/sendmail.
The sendmail example hasn't been used in years.  I am not sure it was ever debugged.  It is so old that it still expects hand editted .config files.  As a result, all of the configuration settings were missing from the Kconfig file.

This commit adds the missing apps/examples/sendmail configuration settings so that the example at least builds.  I cannot test it because I have no smtp server that I am willing to spam.

This configuration also adds missing configuration dependencies and runs the C files in apps/examples/sendmail and apps/netutils/smtp through nxstyle.

This commit resolves an issue reported by surya prakash rased in the Google group:  https://groups.google.com/forum/#!topic/nuttx/idr-M164Y24
2020-01-24 19:07:54 -03:00
Alin Jerpelea
0395cf9c88
Merge pull request #31 from taikoyaP/testbuild
fix message typo on system/zmodem/zm_state.c
2020-01-24 14:33:33 +01:00
Satoshi Togawa
012031bc8e fix typo 2020-01-24 22:12:06 +09:00
Xiang Xiao
fd3775e068 Remove CONFIG_TIME_EXTENDED conditioning
Remove CONFIG_TIME_EXTENDED related stuff since kernel remove this option
2020-01-23 08:36:03 -06:00
Alin Jerpelea
285f7b4072
Merge pull request #30 from xiaoxiang781216/fix-NXGLYPHS_BACKGROUNDCOLOR-invalid
Set NXGLYPHS_BACKGROUNDCOLOR default value
2020-01-23 09:23:55 +01:00
Xiang Xiao
6cd8ba3cf8 Set NXGLYPHS_BACKGROUNDCOLOR default value
to avoid warning: symbol value '' invalid for NXGLYPHS_BACKGROUNDCOLOR

Change-Id: I56e83a88b41d26a6833131a8dc89afe0dcf25d96
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2020-01-23 15:30:19 +08:00
chao.an
7612221df6 apps/wireless/wapi/scan: Add frequency/rssi printf
Scan print layout:

nsh> wapi scan wlan0
bssid / frequency / signal level / ssid
**:**:**:**:**:**       2437    -38     <ssid>
**:**:**:**:**:**       2427    -36     <ssid>
...
2020-01-22 07:53:02 -06:00
liuguo09
270b97190b Makefile: Fix more warning: jobserver unavailable: using -j1. Add '+' to parent make rule. (#27)
Signed-off-by: liuhaitao <liuhaitao@xiaomi.com>
2020-01-21 17:44:45 +01:00
liuguo09
50a86f9bc7 examples/posix_spawn: update dependency to fix parallel build break (#26)
In stm32f4discovery:posix_spawn and lc823450-xgevk:posix_spawn parallel build,
it failed since apps/examples/posix_spawn/filesystem/romfs/hello is not available
which is needed by examples/posix_spawn/filesystem/symtab.c.

Change-Id: I588317396f8e3ca4d69d4ec8db8ccad219207048
Signed-off-by: liuhaitao <liuhaitao@xiaomi.com>
2020-01-21 15:45:32 +01:00
Alin Jerpelea
18f4870a0a
Merge pull request #25 from masayuki2009/improve_gs2200m_throughput
apps: gs2200m: Remove unnecessary usleep() to improve throughput
2020-01-21 08:51:18 +01:00
Masayuki Ishikawa
ebf666100a apps: gs2200m: Remove unnecessary usleep() to improve throughput
Signed-off-by: Masayuki Ishikawa <Masayuki.Ishikawa@jp.sony.com>
2020-01-21 16:03:41 +09:00
liuhaitao
97fd133025 Add install dependency on chardev BIN to fix parallel build break
chardev bin may not availabe before make install in parallel build,
so add install dependency on chardev BIN here.

Change-Id: If28451ceeeed0a6463544d8c342871cecda5a057
Signed-off-by: liuhaitao <liuhaitao@xiaomi.com>
2020-01-20 08:16:34 -06:00
liuhaitao
02dbab7679 Makefile: Fix warning: jobserver unavailable: using -j1. Add '+' to parent make rule.
Change-Id: I73d156f55bc82778c64defe5a8dd84bb478c9008
Signed-off-by: liuhaitao <liuhaitao@xiaomi.com>
2020-01-19 07:24:21 -06:00
patacongo
8e21be5223 apps/Application.mk: Fix path calculation. (#22)
The GNU make CURDIR will always be a POSIX-like path with forward slashes as path segment separators.  If we know that this is a native build, then we need to fix up the path so the DELIM will match the actual delimiter.
2020-01-17 23:44:46 +01:00
Gregory Nutt
367b4d7e5b apps/Makefile: Fix APPDIR path for native build.
A recent change gets the APPSDIR root directory path from:

        APPSDIR = $(CURDIR)

    Where CURDIR is a special variable maintained by GNU make.  In the native build, GNU make is provided by GNUWin32.  The value of CURDIR provided by the GNUWin32 CURDIR is not POSIX, but not quite windows compatible either.  It does return paths that start with C: or D:, but uses forward slashes for path segment delimiters, not backsalshes as required by Windows tools.

    This fix here is to use $(CURDIR) to get the APPSDIR path for file inclusions, that part is fine.  But then, if we find out we are doing a native build, the update the APPSDIR using shell %CD% environment variable which is the authoritative source of the current working directory under Windows.
2020-01-17 16:22:54 -03:00
Ouss4
de836fed72 examples/lis3dsh_reader/lis3dsh_reader_main.c: Make an infinite loop
look similair to the rest.
2020-01-16 13:39:56 -06:00
raiden00pl
77985058f3 examples/: Add simple HTS221, LSM303 and LSM6DSL examples #19 2020-01-16 20:24:32 +00:00
Xiang Xiao
6d22dd0013 Author: Gregory Nutt <gnutt@nuttx.org>
Run all .c and .h files in last PR through nxstyle and fix all complaints.

Author: Xiang Xiao <xiaoxiang@xiaomi.com>

    Wapi improvement (#16)

    * wireless: add passphrase control
    * wireless: add disconnect control
2020-01-16 12:21:45 -06:00