sergiotarxz/nuttx
sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

drivers/serial: Fix wrong ECHO flag

Browse Source 
There is a rookie mistake introduced by https://github.com/apache/nuttx/pull/8691,
ECHO flag is a part of Local Mode (c_lflags) instead of c_iflags.

nuttx-apps should do the same change in nsh_login and termcurse_vt100.

Signed-off-by: Huang Qi <huangqi3@xiaomi.com>
This commit is contained in:
Huang Qi 2023-03-13 17:20:27 +08:00 committed by Alan Carvalho de Assis
parent 74158db707
commit 061e98aa98
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/serial/serial.c
View File

@ -893,7 +893,7 @@ static ssize_t uart_read(FAR struct file *filep,
if (
#ifdef CONFIG_SERIAL_TERMIOS
dev->tc_iflag & ECHO
dev->tc_lflag & ECHO
#else
dev->isconsole
#endif
@ -1822,9 +1822,9 @@ int uart_register(FAR const char *path, FAR uart_dev_t *dev)
if (dev->isconsole)
{
/* Enable signals by default */
/* Enable signals and echo by default */
dev->tc_lflag |= ISIG;
dev->tc_lflag |= ISIG | ECHO;
/* Enable \n -> \r\n translation for the console */
@ -1832,7 +1832,7 @@ int uart_register(FAR const char *path, FAR uart_dev_t *dev)
/* Convert CR to LF by default for console */
dev->tc_iflag |= ICRNL | ECHO;
dev->tc_iflag |= ICRNL;
/* Clear escape counter */