sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

lib_remove:Repair the logical judgment

Browse Source 
Summary:
  When the deleted path is a file, the return value of get_errno is -EISDIR, so in Condition Two
(get_errno() ! = EPERM && /* .... . try to remove it. */
       rmdir(path) ! = 0)
The judgment holds directly, so it can't actually execute to rmdir

Signed-off-by: chenrun1 <chenrun1@xiaomi.com>
This commit is contained in:
chenrun1 2024-07-11 16:44:17 +08:00 committed by Xiang Xiao
parent e6962942cb
commit 0a4770b44a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libs/libc/stdio/lib_remove.c
View File

@ -56,7 +56,7 @@ int remove(FAR const char *path)
*/ */
if (unlink(path) != 0 && /* If it is indeed a directory... */ if (unlink(path) != 0 && /* If it is indeed a directory... */
(get_errno() != EPERM || /* ...try to remove it. */ (get_errno() != EISDIR || /* ...try to remove it. */
rmdir(path) != 0)) rmdir(path) != 0))
{ {
/* Cannot remove the object for whatever reason. */ /* Cannot remove the object for whatever reason. */