sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

libc/textdomain: Fix error behaviour

Browse Source 
- textdomain should set errno to ENOMEM in case if it is not
  possible to store domainname
- fix buffer overflow in textdomain if domainname is a string
  of NAME_MAX length
- improve textdomain error detection in case if domainname
  points to non null terminated buffer

Signed-off-by: Petro Karashchenko <petro.karashchenko@gmail.com>
This commit is contained in:
Petro Karashchenko 2021-12-13 21:22:59 +02:00 committed by Xiang Xiao
parent 69468b700d
commit 12b3491208
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
libs/libc/locale/lib_gettext.c
View File

@ -373,10 +373,10 @@ FAR char *textdomain(FAR const char *domainname)
return *domain ? domain : "messages"; return *domain ? domain : "messages";
} }
domainlen = strlen(domainname); domainlen = strnlen(domainname, NAME_MAX);
if (domainlen > NAME_MAX) if (domainlen == NAME_MAX)
{ {
set_errno(EINVAL); set_errno(ENOMEM);
return NULL; return NULL;
} }