sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

drivers/mtd/ftl.c: Reduce size of stack buffer from 64 to a maximum size as determined from NAME_MAX

Browse Source
This commit is contained in:
Gregory Nutt 2018-08-28 08:19:15 -06:00
parent 70a0bf0849
commit 15a1e44586
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/mtd/ftl.c
View File

@ -46,6 +46,7 @@
#include <stdbool.h> #include <stdbool.h>
#include <stdio.h> #include <stdio.h>
#include <stdlib.h> #include <stdlib.h>
#include <limits.h>
#include <string.h> #include <string.h>
#include <debug.h> #include <debug.h>
#include <errno.h> #include <errno.h>
@ -60,10 +61,18 @@
* Pre-processor Definitions * Pre-processor Definitions
****************************************************************************/ ****************************************************************************/
/* Check if read/write buffer support is needed */
#if defined(CONFIG_FTL_READAHEAD) || defined(CONFIG_FTL_WRITEBUFFER) #if defined(CONFIG_FTL_READAHEAD) || defined(CONFIG_FTL_WRITEBUFFER)
# define FTL_HAVE_RWBUFFER 1 # define FTL_HAVE_RWBUFFER 1
#endif #endif
/* The maximum length of the device name paths is the maximum length of a
* name plus 5 for the the length of "/dev/" and a NUL terminator.
*/
#define DEV_NAME_MAX (NAME_MAX + 5)
/**************************************************************************** /****************************************************************************
* Private Types * Private Types
****************************************************************************/ ****************************************************************************/
@ -515,7 +524,7 @@ static int ftl_ioctl(FAR struct inode *inode, int cmd, unsigned long arg)
int ftl_initialize_by_name(FAR const char *name, FAR struct mtd_dev_s *mtd) int ftl_initialize_by_name(FAR const char *name, FAR struct mtd_dev_s *mtd)
{ {
struct ftl_struct_s *dev; struct ftl_struct_s *dev;
char devname[64]; char devname[DEV_NAME_MAX];
int ret = -ENOMEM; int ret = -ENOMEM;
#ifdef CONFIG_DEBUG_FEATURES #ifdef CONFIG_DEBUG_FEATURES
@ -597,7 +606,7 @@ int ftl_initialize_by_name(FAR const char *name, FAR struct mtd_dev_s *mtd)
/* Create a MTD block device name */ /* Create a MTD block device name */
snprintf(devname, 64, "/dev/mtd%s", name); snprintf(devname, DEV_NAME_MAX, "/dev/mtd%s", name);
/* Inode private data is a reference to the FTL device structure */ /* Inode private data is a reference to the FTL device structure */