From 1603e40607ff7998039b545b31abe924b4de39a3 Mon Sep 17 00:00:00 2001 From: xuxin19 Date: Wed, 24 Jul 2024 14:20:14 +0800 Subject: [PATCH] cmake:bugfix refine gen sim link script to independent cmake module fix SIM start crash on Ubuntu22, becase the previous CMake linker script has missing handling of C++ global constructor sections in the new Glibc version on ubuntu22 it will cause a prior c++ constructor call error: 0x00000000400317f6 in nxsched_get_stackinfo (pid=0, stackinfo=0x7fffffffdbc0) at /media/liujinye/ssd/vela-dev/nuttx/sched/sched/sched_get_stackinfo.c:101 0x000000004002de0d in tls_get_info () at /media/liujinye/ssd/vela-dev/nuttx/libs/libc/tls/tls_getinfo.c:61 0x000000004002ddc8 in task_get_info () at /media/liujinye/ssd/vela-dev/nuttx/libs/libc/tls/task_getinfo.c:50 0x000000004002c74e in atexit_register (type=4, func=0x40044eac , arg=0x40061418 , dso=0x40060000) at /media/liujinye/ssd/vela-dev/nuttx/libs/libc/stdlib/lib_atexit.c:68 0x000000004002ca34 in __cxa_atexit (func=0x40044eac , arg=0x40061418 , dso_handle=0x40060000) at /media/liujinye/ssd/vela-dev/nuttx/libs/libc/stdlib/lib_atexit.c:268 0x000000004004502b in __static_initialization_and_destruction_0 () at /media/liujinye/ssd/vela-dev/apps/examples/helloxx/helloxx_main.cxx:93 0x000000004004503e in _GLOBAL__sub_I_helloxx_main () at /media/liujinye/ssd/vela-dev/apps/examples/helloxx/helloxx_main.cxx:129 0x00007ffff7829ebb in call_init (env=, argv=0x7fffffffdd18, argc=1) at ../csu/libc-start.c:145 __libc_start_main_impl (main=0x40004dc8
, argc=1, argv=0x7fffffffdd18, init=, fini=, rtld_fini=, stack_end=0x7fffffffdd08) at ../csu/libc-start.c:379 0x0000000040004285 in _start () Signed-off-by: xuxin19 --- CMakeLists.txt | 39 +++---------------- cmake/nuttx_generate_sim_ld.cmake | 65 +++++++++++++++++++++++++++++++ 2 files changed, 71 insertions(+), 33 deletions(-) create mode 100644 cmake/nuttx_generate_sim_ld.cmake diff --git a/CMakeLists.txt b/CMakeLists.txt index 02c9f6ef9b..5d2d39470d 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -688,44 +688,17 @@ elseif(WIN32) target_link_libraries(nuttx PRIVATE $ ${CMAKE_BINARY_DIR}/nuttx_all.lib) else() + + if(NOT APPLE) + # generate SIM ld.script for cheat C++ global construction + include(nuttx_generate_sim_ld) + endif() + # On sim platform the link step is a little different. NuttX is first built # into a partially linked relocatable object nuttx.rel with no interface to # host OS. Then, the names of symbols that conflict with libc symbols are # renamed. The final nuttx binary is built by linking the host-specific # objects with the relocatable binary. - - # C++ global objects are constructed before main get executed, but it isn't a - # good point for simulator because NuttX doesn't finish the kernel - # initialization yet. So we have to skip the standard facilities and do the - # construction by ourself. But how to achieve the goal? 1.Command linker - # generate the default script(-verbose) 2.Replace - # __init_array_start/__init_array_end with _sinit/_einit 3.Append - # __init_array_start = .; __init_array_end = .; Step 2 let nxtask_startup find - # objects need to construct Step 3 cheat the host there is no object to - # construct Note: the destructor can be fixed in the same way. - - if(NOT APPLE) - add_custom_command( - OUTPUT nuttx.ld - COMMAND - ${CMAKE_C_COMPILER} ${CMAKE_EXE_LINKER_FLAGS} - $<$:-m32> -Wl,-verbose 2> /dev/null > - nuttx-orig.ld || true - COMMAND - cat nuttx-orig.ld | sed -e '/====/,/====/!d\;//d' -e - 's/__executable_start/_stext/g' -e 's/__init_array_start/_sinit/g' -e - 's/__init_array_end/_einit/g' -e 's/__fini_array_start/_sfini/g' -e - 's/__fini_array_end/_efini/g' > nuttx.ld - COMMAND - echo ARGS - '__init_array_start = .\; __init_array_end = .\; __fini_array_start = .\; __fini_array_end = .\;' - >> nuttx.ld - COMMAND sed -i '/\\.data *:/i " ${CONFIG_SIM_CUSTOM_DATA_SECTION} " ' - nuttx.ld) - endif() - - # conflicting symbols to rename - include(nuttx_redefine_symbols) # TODO: do with single function call? diff --git a/cmake/nuttx_generate_sim_ld.cmake b/cmake/nuttx_generate_sim_ld.cmake new file mode 100644 index 0000000000..c59301dd6c --- /dev/null +++ b/cmake/nuttx_generate_sim_ld.cmake @@ -0,0 +1,65 @@ +# ############################################################################## +# cmake/nuttx_generate_sim_ld.cmake +# +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements. See the NOTICE file distributed with this work for +# additional information regarding copyright ownership. The ASF licenses this +# file to you under the Apache License, Version 2.0 (the "License"); you may not +# use this file except in compliance with the License. You may obtain a copy of +# the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations under +# the License. +# +# ############################################################################## + +# cmake-format: off +# C++ global objects are constructed before main get executed, but it isn't a +# good point for simulator because NuttX doesn't finish the kernel +# initialization yet. +# So we have to skip the standard facilities and do the construction by ourself. +# But how to achieve the goal? +# 1.Command linker generate the default script(-verbose) +# 2.Replace __init_array_start/__init_array_end with _sinit/_einit +# 3.Append __init_array_start = .; __init_array_end = .; +# Step 2 let nxtask_startup find objects need to construct +# Step 3 cheat the host there is no object to construct +# Note: the destructor can be fixed in the same way. +set(PROCESS_SIM_LD_SCRIPT + [[ + #!/bin/sh + original_ld="$1" + target_ld="$2" + cat $original_ld | \ + sed -e '/====/,/====/!d;//d' \ + -e '/__executable_start/s/$/PROVIDE(_stext = .);/' \ + -e 's/^\(\s\+\)\(\.init_array\)/\1\2 : { }\n\1.sinit/g' \ + -e 's/^\(\s\+\)\(\.fini_array\)/\1\2 : { }\n\1.einit/g' \ + -e 's/__init_array_start/_sinit/g' -e 's/__init_array_end/_einit/g' \ + -e 's/__fini_array_start/_sfini/g' -e 's/__fini_array_end/_efini/g' > "$target_ld" + echo "__init_array_start = .; __init_array_end = .; __fini_array_start = .; __fini_array_end = .;" >> "$target_ld" +]]) +# cmake-format: on + +file(WRITE ${CMAKE_BINARY_DIR}/process_sim_ld_script.sh + "${PROCESS_SIM_LD_SCRIPT}") +file( + COPY ${CMAKE_BINARY_DIR}/process_sim_ld_script.sh + DESTINATION ${CMAKE_BINARY_DIR} + FILE_PERMISSIONS OWNER_EXECUTE OWNER_WRITE OWNER_READ) + +add_custom_command( + OUTPUT nuttx.ld + COMMAND + ${CMAKE_C_COMPILER} ${CMAKE_EXE_LINKER_FLAGS} + $<$:-m32> -Wl,-verbose 2> /dev/null > nuttx-orig.ld + || true + COMMAND sh process_sim_ld_script.sh nuttx-orig.ld nuttx.ld + COMMAND sed -i '/\\.data *:/i " ${CONFIG_SIM_CUSTOM_DATA_SECTION} " ' nuttx.ld + COMMENT "Generating sim linker script nuttx.ld" + WORKING_DIRECTORY ${CMAKE_BINARY_DIR})