sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

arch/intel64: fix stack alignment

Browse Source 
The stack pointer must be aligned to 16 bytes, otherwise the system crash on the first unaligned data access with vector instruction.
The problem is only observable with optimization enabled, when vector instructions are generated.

Signed-off-by: p-szafonimateusz <p-szafonimateusz@xiaomi.com>
Signed-off-by: Bowen Wang <wangbowen6@xiaomi.com>
This commit is contained in:
p-szafonimateusz 2024-02-07 15:00:42 +01:00 committed by Alan Carvalho de Assis
parent c3d41195c7
commit 16e47d6c8b
3 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
arch/x86_64/src/intel64/intel64_createstack.c
View File

@ -192,8 +192,9 @@ int up_create_stack(struct tcb_s *tcb, size_t stack_size, uint8_t ttype)
/* The intel64 stack must be aligned at word (16 byte) boundaries. If
* necessary top_of_stack must be rounded down to the next boundary.
* We intentionally align at 8 byte boundary, because at task_start,
* only frame pointer will be pushed, not instruction pointer.
* We intentionally align at 8 byte boundary (look at up_stack_frame())
* , because at task_start, only frame pointer will be pushed, not
* instruction pointer.
*/
top_of_stack &= ~0x0f;

2
arch/x86_64/src/intel64/intel64_stackframe.c
View File

@ -90,7 +90,7 @@ void *up_stack_frame(struct tcb_s *tcb, size_t frame_size)
/* Save the adjusted stack values in the struct tcb_s */
tcb->stack_base_ptr = (uint8_t *)tcb->stack_base_ptr + frame_size;
tcb->adj_stack_size -= frame_size;
tcb->adj_stack_size -= frame_size + 8;
/* And return the pointer to the allocated region */

5
arch/x86_64/src/intel64/intel64_usestack.c
View File

@ -110,8 +110,9 @@ int up_use_stack(struct tcb_s *tcb, void *stack, size_t stack_size)
/* The intel64 stack must be aligned at word (16 byte) boundaries. If
* necessary top_of_stack must be rounded down to the next boundary.
* We intentionally align at 8 byte boundary, because at task_start, only
* frame pointer will be pushed, not instruction pointer.
* We intentionally align at 8 byte boundary (look at up_stack_frame()),
* because at task_start, only frame pointer will be pushed, not
* instruction pointer.
*/
top_of_stack &= ~0x0f;