sergiotarxz/nuttx
sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix compler error in tickless code when round robin scheduling is enabled. Other cosmetic fixes to comments

Browse Source
This commit is contained in:
Gregory Nutt 2014-08-07 14:14:09 -06:00
parent 822a4fafeb
commit 17ea50b45e
2 changed files with 5 additions and 4 deletions

6
sched/Kconfig

@ -66,7 +66,7 @@ config SCHED_TICKLESS
defined include/nuttx/arch.h defined include/nuttx/arch.h
config USEC_PER_TICK config USEC_PER_TICK
int "Milliseconds per system timer tick" int "System timer tick period (microseconds)"
default 10000 if !SCHED_TICKLESS default 10000 if !SCHED_TICKLESS
default 100 if SCHED_TICKLESS default 100 if SCHED_TICKLESS
---help--- ---help---
@ -81,12 +81,12 @@ config USEC_PER_TICK
rates. Rather, it only determines the resolution of time reported rates. Rather, it only determines the resolution of time reported
by clock_systimer() and the resolution of times that can be set for by clock_systimer() and the resolution of times that can be set for
certain delays including watchdog timers and delayed work. In this certain delays including watchdog timers and delayed work. In this
case there is a tradeoff: It is better to have the USEC_PER_TICK as case there is a trade-off: It is better to have the USEC_PER_TICK as
low as possible for higher timing resolution. However, the the time low as possible for higher timing resolution. However, the the time
is currently held in 'unsigned int' on some systems, this may be is currently held in 'unsigned int' on some systems, this may be
16-bits but on most contemporary systems it will be 32-bits. In 16-bits but on most contemporary systems it will be 32-bits. In
either case, smaller values of USEC_PER_TICK will reduce the range either case, smaller values of USEC_PER_TICK will reduce the range
of values that delays that can be represented. So the tradeoff is of values that delays that can be represented. So the trade-off is
between range and resolution (you could also modify the code to use between range and resolution (you could also modify the code to use
a 64-bit value if you really want both). a 64-bit value if you really want both).

3
sched/sched_unlock.c

@ -39,6 +39,7 @@
#include <nuttx/config.h> #include <nuttx/config.h>
#include <nuttx/clock.h>
#include <nuttx/arch.h> #include <nuttx/arch.h>
#include "os_internal.h" #include "os_internal.h"
@ -132,7 +133,7 @@ int sched_unlock(void)
*/ */
if ((rtcb->flags & TCB_FLAG_ROUND_ROBIN) != 0 && if ((rtcb->flags & TCB_FLAG_ROUND_ROBIN) != 0 &&
rctb->timeslice == 0) rtcb->timeslice == 0)
{ {
/* Yes.. that is the situation. But one more thing. The call /* Yes.. that is the situation. But one more thing. The call
* to up_release_pending() above may have actually replaced * to up_release_pending() above may have actually replaced